WARNING: 'appropiate' may be misspelled - perhaps 'appropriate'? #59: can inspect the kernel module to see if they have the appropiate ^^^^^^^^^^ WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #71: new file mode 100644 CHECK: Alignment should match open parenthesis #150: FILE: net/rds/af_rds.c:877: +static ssize_t supported_show(struct kobject *kobj, struct kobj_attribute *attr, + char *buf) ERROR: Macros with complex values should be enclosed in parentheses #173: FILE: net/rds/af_rds.c:900: +#define ATTR_LIST(_name) &rds_attr_##_name.attr BUT SEE: do {} while (0) advice is over-stated in a few situations: The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name. More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions. Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper. Enjoy this qualification while we work to improve our heuristics. total: 1 errors, 2 warnings, 1 checks, 148 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 96c3b31bc673 ("rds: Expose feature parameters via sysfs (and ELF)") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.