====== Checking before the patch ====== ====== Checking the tree with the patch ====== tools/testing/selftests/net/tfo_passive.sh is a new file, but not shellcheck compliant New errors added --- /tmp/tmp.0NsrZx3Nxk 2025-06-17 15:40:20.241980857 -0700 +++ /tmp/tmp.JXn6ZOFKtT 2025-06-17 15:40:20.951976950 -0700 @@ -0,0 +1,111 @@ + +In tfo_passive.sh line 30: + ip link set $NSIM_SV_NAME netns nssv + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip link set "$NSIM_SV_NAME" netns nssv + + +In tfo_passive.sh line 31: + ip link set $NSIM_CL_NAME netns nscl + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip link set "$NSIM_CL_NAME" netns nscl + + +In tfo_passive.sh line 33: + ip netns exec nssv ip addr add "${SERVER_IP}/24" dev $NSIM_SV_NAME + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec nssv ip addr add "${SERVER_IP}/24" dev "$NSIM_SV_NAME" + + +In tfo_passive.sh line 34: + ip netns exec nscl ip addr add "${CLIENT_IP}/24" dev $NSIM_CL_NAME + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec nscl ip addr add "${CLIENT_IP}/24" dev "$NSIM_CL_NAME" + + +In tfo_passive.sh line 36: + ip netns exec nssv ip link set dev $NSIM_SV_NAME up + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec nssv ip link set dev "$NSIM_SV_NAME" up + + +In tfo_passive.sh line 37: + ip netns exec nscl ip link set dev $NSIM_CL_NAME up + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip netns exec nscl ip link set dev "$NSIM_CL_NAME" up + + +In tfo_passive.sh line 63: +setup_ns +^------^ SC2119 (info): Use setup_ns "$@" if function's $1 should mean script's $1. + + +In tfo_passive.sh line 67: +NSIM_SV_IFIDX=$(ip netns exec nssv cat /sys/class/net/$NSIM_SV_NAME/ifindex) + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +NSIM_SV_IFIDX=$(ip netns exec nssv cat /sys/class/net/"$NSIM_SV_NAME"/ifindex) + + +In tfo_passive.sh line 71: +NSIM_CL_IFIDX=$(ip netns exec nscl cat /sys/class/net/$NSIM_CL_NAME/ifindex) + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +NSIM_CL_IFIDX=$(ip netns exec nscl cat /sys/class/net/"$NSIM_CL_NAME"/ifindex) + + +In tfo_passive.sh line 76: +if [ $? -ne 0 ]; then + ^-- SC2320 (warning): This $? refers to echo/printf, not a previous command. Assign to variable to avoid it being overwritten. + ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. + + +In tfo_passive.sh line 87: + -o ${out_file}& + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + -o "${out_file}"& + + +In tfo_passive.sh line 95: +res=$(cat $out_file) + ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +res=$(cat "$out_file") + + +In tfo_passive.sh line 96: +rm $out_file + ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +rm "$out_file" + + +In tfo_passive.sh line 98: +if [ $res -eq 0 ]; then + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +if [ "$res" -eq 0 ]; then + +For more information: + https://www.shellcheck.net/wiki/SC2320 -- This $? refers to echo/printf, no... + https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... + https://www.shellcheck.net/wiki/SC2119 -- Use setup_ns "$@" if function's $...