ShellCheck - shell script analysis tool version: 0.10.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.4eAFOWUmYD and /tmp/tmp.Hr3su39h7q Tree base: c3398ac53cc5 ("selftests: net: use slowwait to stabilize vrf_route_leaking test") Now at: 1695d6692441 ("selftests: net: use slowwait to make sure IPv6 setup finished") ====== Checking before the patch ====== Checking tools/testing/selftests/net/test_vxlan_vnifiltering.sh - d3ca010dedbfc51134e59ef2aaaa93a6b865e0797b5ea0cb941bed85ad1060f8 In test_vxlan_vnifiltering.sh line 97: which ping6 > /dev/null 2>&1 && ping6=$(which ping6) || ping6=$(which ping) ^---^ SC2034 (warning): ping6 appears unused. Verify use (or export if used externally). In test_vxlan_vnifiltering.sh line 105: if [ ${rc} -eq ${expected} ]; then ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${rc}" -eq "${expected}" ]; then In test_vxlan_vnifiltering.sh line 115: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In test_vxlan_vnifiltering.sh line 123: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In test_vxlan_vnifiltering.sh line 135: printf "COMMAND: $cmd\n" ^---------------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In test_vxlan_vnifiltering.sh line 139: out=$(eval $cmd $stderr) ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: out=$(eval "$cmd" "$stderr") In test_vxlan_vnifiltering.sh line 141: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In test_vxlan_vnifiltering.sh line 145: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In test_vxlan_vnifiltering.sh line 149: ip netns exec $hv_1 ping -c 1 -W 1 $1 &>/dev/null ^---^ SC2154 (warning): hv_1 is referenced but not assigned. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$hv_1" ping -c 1 -W 1 "$1" &>/dev/null In test_vxlan_vnifiltering.sh line 151: ip netns exec $hv_1 ping -c 1 -W 1 $2 &>/dev/null ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$hv_1" ping -c 1 -W 1 "$2" &>/dev/null In test_vxlan_vnifiltering.sh line 157: run_cmd "ip netns exec $vm_11 ping -c 1 -W 1 10.0.10.12" ^----^ SC2154 (warning): vm_11 is referenced but not assigned. In test_vxlan_vnifiltering.sh line 160: run_cmd "ip netns exec $vm_21 ping -c 1 -W 1 10.0.10.22" ^----^ SC2154 (warning): vm_21 is referenced but not assigned. In test_vxlan_vnifiltering.sh line 168: cleanup_ns $hv_1 $hv_2 $vm_11 $vm_21 $vm_12 $vm_22 $vm_31 $vm_32 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2154 (warning): hv_2 is referenced but not assigned. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2154 (warning): vm_12 is referenced but not assigned. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2154 (warning): vm_22 is referenced but not assigned. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2154 (warning): vm_31 is referenced but not assigned. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2154 (warning): vm_32 is referenced but not assigned. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cleanup_ns "$hv_1" "$hv_2" "$vm_11" "$vm_21" "$vm_12" "$vm_22" "$vm_31" "$vm_32" In test_vxlan_vnifiltering.sh line 180: ip link set veth-hv-$id netns ${hv[$id]} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set veth-hv-"$id" netns "${hv[$id]}" In test_vxlan_vnifiltering.sh line 181: ip -netns ${hv[$id]} link set veth-hv-$id name veth0 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$id]}" link set veth-hv-"$id" name veth0 In test_vxlan_vnifiltering.sh line 182: ip -netns ${hv[$id]} addr add $local1/$mask1 dev veth0 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$id]}" addr add "$local1"/"$mask1" dev veth0 In test_vxlan_vnifiltering.sh line 183: ip -netns ${hv[$id]} addr add $local2/$mask2 dev veth0 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$id]}" addr add "$local2"/"$mask2" dev veth0 In test_vxlan_vnifiltering.sh line 184: ip -netns ${hv[$id]} link set veth0 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$id]}" link set veth0 up In test_vxlan_vnifiltering.sh line 206: ip -netns ${hv[$hvid]} link add br$brid type bridge vlan_filtering 1 vlan_default_pvid 0 \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$hvid]}" link add br"$brid" type bridge vlan_filtering 1 vlan_default_pvid 0 \ In test_vxlan_vnifiltering.sh line 208: ip -netns ${hv[$hvid]} link set br$brid up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$hvid]}" link set br"$brid" up In test_vxlan_vnifiltering.sh line 214: ip link add $hvvethif type veth peer name $vmvethif ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add "$hvvethif" type veth peer name "$vmvethif" In test_vxlan_vnifiltering.sh line 215: ip link set $hvvethif netns ${hv[$hvid]} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$hvvethif" netns "${hv[$hvid]}" In test_vxlan_vnifiltering.sh line 216: ip link set $vmvethif netns ${vm[$vmid]} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$vmvethif" netns "${vm[$vmid]}" In test_vxlan_vnifiltering.sh line 217: ip -netns ${hv[$hvid]} link set $hvvethif up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$hvid]}" link set "$hvvethif" up In test_vxlan_vnifiltering.sh line 218: ip -netns ${vm[$vmid]} link set $vmvethif up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${vm[$vmid]}" link set "$vmvethif" up In test_vxlan_vnifiltering.sh line 219: ip -netns ${hv[$hvid]} link set $hvvethif master br$brid ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$hvid]}" link set "$hvvethif" master br"$brid" In test_vxlan_vnifiltering.sh line 222: for vmap in $(echo $vattrs | cut -d "," -f1- --output-delimiter=' ') ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: for vmap in $(echo "$vattrs" | cut -d "," -f1- --output-delimiter=' ') In test_vxlan_vnifiltering.sh line 224: local vid=$(echo $vmap | awk -F'-' '{print ($1)}') ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local vid=$(echo "$vmap" | awk -F'-' '{print ($1)}') In test_vxlan_vnifiltering.sh line 225: local family=$(echo $vmap | awk -F'-' '{print ($2)}') ^----^ SC2034 (warning): family appears unused. Verify use (or export if used externally). ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local family=$(echo "$vmap" | awk -F'-' '{print ($2)}') In test_vxlan_vnifiltering.sh line 226: local localip=$(echo $vmap | awk -F'-' '{print ($3)}') ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local localip=$(echo "$vmap" | awk -F'-' '{print ($3)}') In test_vxlan_vnifiltering.sh line 227: local group=$(echo $vmap | awk -F'-' '{print ($4)}') ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local group=$(echo "$vmap" | awk -F'-' '{print ($4)}') In test_vxlan_vnifiltering.sh line 228: local vtype=$(echo $vmap | awk -F'-' '{print ($5)}') ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local vtype=$(echo "$vmap" | awk -F'-' '{print ($5)}') In test_vxlan_vnifiltering.sh line 229: local port=$(echo $vmap | awk -F'-' '{print ($6)}') ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local port=$(echo "$vmap" | awk -F'-' '{print ($6)}') In test_vxlan_vnifiltering.sh line 231: ip -netns ${vm[$vmid]} link add name $vmvethif.$vid link $vmvethif type vlan id $vid ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${vm[$vmid]}" link add name "$vmvethif"."$vid" link "$vmvethif" type vlan id "$vid" In test_vxlan_vnifiltering.sh line 232: ip -netns ${vm[$vmid]} addr add 10.0.$vid.$vmid/24 dev $vmvethif.$vid ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${vm[$vmid]}" addr add 10.0."$vid"."$vmid"/24 dev "$vmvethif"."$vid" In test_vxlan_vnifiltering.sh line 233: ip -netns ${vm[$vmid]} link set $vmvethif.$vid up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${vm[$vmid]}" link set "$vmvethif"."$vid" up In test_vxlan_vnifiltering.sh line 251: if [ $mcast -eq 1 ]; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$mcast" -eq 1 ]; then In test_vxlan_vnifiltering.sh line 265: ip -netns ${hv[$hvid]} link add $vxlandev type vxlan local $localip $vxlandevflags dev veth0 2>/dev/null ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$hvid]}" link add "$vxlandev" type vxlan local "$localip" "$vxlandevflags" dev veth0 2>/dev/null In test_vxlan_vnifiltering.sh line 266: ip -netns ${hv[$hvid]} link set $vxlandev master br$brid ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$hvid]}" link set "$vxlandev" master br"$brid" In test_vxlan_vnifiltering.sh line 267: ip -netns ${hv[$hvid]} link set $vxlandev up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$hvid]}" link set "$vxlandev" up In test_vxlan_vnifiltering.sh line 272: bridge -netns ${hv[$hvid]} vlan add vid $vid dev $hvvethif ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -netns "${hv[$hvid]}" vlan add vid "$vid" dev "$hvvethif" In test_vxlan_vnifiltering.sh line 273: bridge -netns ${hv[$hvid]} vlan add vid $vid pvid dev $vxlandev ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -netns "${hv[$hvid]}" vlan add vid "$vid" pvid dev "$vxlandev" In test_vxlan_vnifiltering.sh line 277: bridge -netns ${hv[$hvid]} link set dev $vxlandev vlan_tunnel on ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -netns "${hv[$hvid]}" link set dev "$vxlandev" vlan_tunnel on In test_vxlan_vnifiltering.sh line 278: bridge -netns ${hv[$hvid]} vlan add dev $vxlandev vid $vid tunnel_info id $tid ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -netns "${hv[$hvid]}" vlan add dev "$vxlandev" vid "$vid" tunnel_info id "$tid" In test_vxlan_vnifiltering.sh line 282: bridge -netns ${hv[$hvid]} fdb add 00:00:00:00:00:00 dev $vxlandev \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -netns "${hv[$hvid]}" fdb add 00:00:00:00:00:00 dev "$vxlandev" \ In test_vxlan_vnifiltering.sh line 283: src_vni $tid vni $tid dst $group self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: src_vni "$tid" vni "$tid" dst "$group" self In test_vxlan_vnifiltering.sh line 286: bridge -netns ${hv[$hvid]} vni add dev $vxlandev vni $tid ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -netns "${hv[$hvid]}" vni add dev "$vxlandev" vni "$tid" In test_vxlan_vnifiltering.sh line 290: if [ $mcast -eq 1 ]; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$mcast" -eq 1 ]; then In test_vxlan_vnifiltering.sh line 291: bridge -netns ${hv[$hvid]} vni add dev $vxlandev vni $tid group $group ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -netns "${hv[$hvid]}" vni add dev "$vxlandev" vni "$tid" group "$group" In test_vxlan_vnifiltering.sh line 293: bridge -netns ${hv[$hvid]} vni add dev $vxlandev vni $tid remote $group ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -netns "${hv[$hvid]}" vni add dev "$vxlandev" vni "$tid" remote "$group" In test_vxlan_vnifiltering.sh line 304: ip link set veth-testns netns $testns ^-----^ SC2154 (warning): testns is referenced but not assigned. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set veth-testns netns "$testns" In test_vxlan_vnifiltering.sh line 310: ip netns del $testns 2>/dev/null || true ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" 2>/dev/null || true In test_vxlan_vnifiltering.sh line 391: setup-hv-networking 1 $hv1addr1 24 $hv1addr2 64 $hv2addr1 $hv2addr2 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 1 "$hv1addr1" 24 "$hv1addr2" 64 "$hv2addr1" "$hv2addr2" In test_vxlan_vnifiltering.sh line 392: setup-hv-networking 2 $hv2addr1 24 $hv2addr2 64 $hv1addr1 $hv1addr2 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 2 "$hv2addr1" 24 "$hv2addr2" 64 "$hv1addr1" "$hv1addr2" In test_vxlan_vnifiltering.sh line 401: setup-vm 1 11 1 10-v4-$hv1addr1-$hv2addr1-vnifilter,20-v4-$hv1addr1-$hv2addr1-vnifilter 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 11 1 10-v4-"$hv1addr1"-"$hv2addr1"-vnifilter,20-v4-"$hv1addr1"-"$hv2addr1"-vnifilter 0 In test_vxlan_vnifiltering.sh line 402: setup-vm 1 21 2 10-v6-$hv1addr2-$hv2addr2-vnifilter,20-v6-$hv1addr2-$hv2addr2-vnifilter 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 21 2 10-v6-"$hv1addr2"-"$hv2addr2"-vnifilter,20-v6-"$hv1addr2"-"$hv2addr2"-vnifilter 0 In test_vxlan_vnifiltering.sh line 404: setup-vm 2 12 1 10-v4-$hv2addr1-$hv1addr1-vnifilter,20-v4-$hv2addr1-$hv1addr1-vnifilter 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 12 1 10-v4-"$hv2addr1"-"$hv1addr1"-vnifilter,20-v4-"$hv2addr1"-"$hv1addr1"-vnifilter 0 In test_vxlan_vnifiltering.sh line 405: setup-vm 2 22 2 10-v6-$hv2addr2-$hv1addr2-vnifilter,20-v6-$hv2addr2-$hv1addr2-vnifilter 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 22 2 10-v6-"$hv2addr2"-"$hv1addr2"-vnifilter,20-v6-"$hv2addr2"-"$hv1addr2"-vnifilter 0 In test_vxlan_vnifiltering.sh line 424: setup-hv-networking 1 $hv1addr1 24 $hv1addr2 64 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 1 "$hv1addr1" 24 "$hv1addr2" 64 In test_vxlan_vnifiltering.sh line 425: setup-hv-networking 2 $hv2addr1 24 $hv2addr2 64 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 2 "$hv2addr1" 24 "$hv2addr2" 64 In test_vxlan_vnifiltering.sh line 434: setup-vm 1 11 1 10-v4-$hv1addr1-$hv2addr1-vnifilterg,20-v4-$hv1addr1-$hv2addr1-vnifilterg 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 11 1 10-v4-"$hv1addr1"-"$hv2addr1"-vnifilterg,20-v4-"$hv1addr1"-"$hv2addr1"-vnifilterg 0 In test_vxlan_vnifiltering.sh line 435: setup-vm 1 21 2 10-v6-$hv1addr2-$hv2addr2-vnifilterg,20-v6-$hv1addr2-$hv2addr2-vnifilterg 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 21 2 10-v6-"$hv1addr2"-"$hv2addr2"-vnifilterg,20-v6-"$hv1addr2"-"$hv2addr2"-vnifilterg 0 In test_vxlan_vnifiltering.sh line 437: setup-vm 2 12 1 10-v4-$hv2addr1-$hv1addr1-vnifilterg,20-v4-$hv2addr1-$hv1addr1-vnifilterg 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 12 1 10-v4-"$hv2addr1"-"$hv1addr1"-vnifilterg,20-v4-"$hv2addr1"-"$hv1addr1"-vnifilterg 0 In test_vxlan_vnifiltering.sh line 438: setup-vm 2 22 2 10-v6-$hv2addr2-$hv1addr2-vnifilterg,20-v6-$hv2addr2-$hv1addr2-vnifilterg 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 22 2 10-v6-"$hv2addr2"-"$hv1addr2"-vnifilterg,20-v6-"$hv2addr2"-"$hv1addr2"-vnifilterg 0 In test_vxlan_vnifiltering.sh line 457: setup-hv-networking 1 $hv1addr1 24 $hv1addr2 64 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 1 "$hv1addr1" 24 "$hv1addr2" 64 In test_vxlan_vnifiltering.sh line 458: setup-hv-networking 2 $hv2addr1 24 $hv2addr2 64 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 2 "$hv2addr1" 24 "$hv2addr2" 64 In test_vxlan_vnifiltering.sh line 467: setup-vm 1 11 1 10-v4-$hv1addr1-$group-vnifilter,20-v4-$hv1addr1-$group-vnifilter 1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 11 1 10-v4-"$hv1addr1"-"$group"-vnifilter,20-v4-"$hv1addr1"-"$group"-vnifilter 1 In test_vxlan_vnifiltering.sh line 470: setup-vm 2 12 1 10-v4-$hv2addr1-$group-vnifilter,20-v4-$hv2addr1-$group-vnifilter 1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 12 1 10-v4-"$hv2addr1"-"$group"-vnifilter,20-v4-"$hv2addr1"-"$group"-vnifilter 1 In test_vxlan_vnifiltering.sh line 471: setup-vm 2 22 2 10-v6-$hv2addr2-$group6-vnifilter,20-v6-$hv2addr2-$group6-vnifilter 1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 22 2 10-v6-"$hv2addr2"-"$group6"-vnifilter,20-v6-"$hv2addr2"-"$group6"-vnifilter 1 In test_vxlan_vnifiltering.sh line 489: setup-hv-networking 1 $hv1addr1 24 $hv1addr2 64 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 1 "$hv1addr1" 24 "$hv1addr2" 64 In test_vxlan_vnifiltering.sh line 490: setup-hv-networking 2 $hv2addr1 24 $hv2addr2 64 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 2 "$hv2addr1" 24 "$hv2addr2" 64 In test_vxlan_vnifiltering.sh line 499: setup-vm 1 11 1 10-v4-$hv1addr1-$group-vnifilterg,20-v4-$hv1addr1-$group-vnifilterg 1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 11 1 10-v4-"$hv1addr1"-"$group"-vnifilterg,20-v4-"$hv1addr1"-"$group"-vnifilterg 1 In test_vxlan_vnifiltering.sh line 500: setup-vm 1 21 2 10-v6-$hv1addr2-$group6-vnifilterg,20-v6-$hv1addr2-$group6-vnifilterg 1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 21 2 10-v6-"$hv1addr2"-"$group6"-vnifilterg,20-v6-"$hv1addr2"-"$group6"-vnifilterg 1 In test_vxlan_vnifiltering.sh line 502: setup-vm 2 12 1 10-v4-$hv2addr1-$group-vnifilterg,20-v4-$hv2addr1-$group-vnifilterg 1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 12 1 10-v4-"$hv2addr1"-"$group"-vnifilterg,20-v4-"$hv2addr1"-"$group"-vnifilterg 1 In test_vxlan_vnifiltering.sh line 503: setup-vm 2 22 2 10-v6-$hv2addr2-$group6-vnifilterg,20-v6-$hv2addr2-$group6-vnifilterg 1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 22 2 10-v6-"$hv2addr2"-"$group6"-vnifilterg,20-v6-"$hv2addr2"-"$group6"-vnifilterg 1 In test_vxlan_vnifiltering.sh line 519: setup-hv-networking 1 $hv1addr1 24 $hv1addr2 64 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 1 "$hv1addr1" 24 "$hv1addr2" 64 In test_vxlan_vnifiltering.sh line 520: setup-hv-networking 2 $hv2addr1 24 $hv2addr2 64 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 2 "$hv2addr1" 24 "$hv2addr2" 64 In test_vxlan_vnifiltering.sh line 531: setup-vm 1 11 1 10-v4-$hv1addr1-$hv2addr1-vnifilter,20-v4-$hv1addr1-$hv2addr1-vnifilter 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 11 1 10-v4-"$hv1addr1"-"$hv2addr1"-vnifilter,20-v4-"$hv1addr1"-"$hv2addr1"-vnifilter 0 In test_vxlan_vnifiltering.sh line 532: setup-vm 1 21 2 10-v6-$hv1addr2-$hv2addr2-vnifilter,20-v6-$hv1addr2-$hv2addr2-vnifilter 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 21 2 10-v6-"$hv1addr2"-"$hv2addr2"-vnifilter,20-v6-"$hv1addr2"-"$hv2addr2"-vnifilter 0 In test_vxlan_vnifiltering.sh line 533: setup-vm 1 31 3 30-v4-$hv1addr1-$hv2addr1-default-4790,40-v6-$hv1addr2-$hv2addr2-default-4790,50-v4-$hv1addr1-$hv2addr1-metadata-4791 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 31 3 30-v4-"$hv1addr1"-"$hv2addr1"-default-4790,40-v6-"$hv1addr2"-"$hv2addr2"-default-4790,50-v4-"$hv1addr1"-"$hv2addr1"-metadata-4791 0 In test_vxlan_vnifiltering.sh line 536: setup-vm 2 12 1 10-v4-$hv2addr1-$hv1addr1-vnifilter,20-v4-$hv2addr1-$hv1addr1-vnifilter 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 12 1 10-v4-"$hv2addr1"-"$hv1addr1"-vnifilter,20-v4-"$hv2addr1"-"$hv1addr1"-vnifilter 0 In test_vxlan_vnifiltering.sh line 537: setup-vm 2 22 2 10-v6-$hv2addr2-$hv1addr2-vnifilter,20-v6-$hv2addr2-$hv1addr2-vnifilter 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 22 2 10-v6-"$hv2addr2"-"$hv1addr2"-vnifilter,20-v6-"$hv2addr2"-"$hv1addr2"-vnifilter 0 In test_vxlan_vnifiltering.sh line 538: setup-vm 2 32 3 30-v4-$hv2addr1-$hv1addr1-default-4790,40-v6-$hv2addr2-$hv1addr2-default-4790,50-v4-$hv2addr1-$hv1addr1-metadata-4791 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 32 3 30-v4-"$hv2addr1"-"$hv1addr1"-default-4790,40-v6-"$hv2addr2"-"$hv1addr2"-default-4790,50-v4-"$hv2addr1"-"$hv1addr1"-metadata-4791 0 In test_vxlan_vnifiltering.sh line 559: v) VERBOSE=$(($VERBOSE + 1));; ^------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In test_vxlan_vnifiltering.sh line 579: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In test_vxlan_vnifiltering.sh line 586: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In test_vxlan_vnifiltering.sh line 603: printf "\nTests passed: %3d\n" ${nsuccess} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf "\nTests passed: %3d\n" "${nsuccess}" In test_vxlan_vnifiltering.sh line 604: printf "Tests failed: %3d\n" ${nfail} ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf "Tests failed: %3d\n" "${nfail}" For more information: https://www.shellcheck.net/wiki/SC2034 -- family appears unused. Verify use... https://www.shellcheck.net/wiki/SC2154 -- hv_1 is referenced but not assign... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/test_vxlan_vnifiltering.sh - d3ca010dedbfc51134e59ef2aaaa93a6b865e0797b5ea0cb941bed85ad1060f8 In test_vxlan_vnifiltering.sh line 97: which ping6 > /dev/null 2>&1 && ping6=$(which ping6) || ping6=$(which ping) ^---^ SC2034 (warning): ping6 appears unused. Verify use (or export if used externally). In test_vxlan_vnifiltering.sh line 105: if [ ${rc} -eq ${expected} ]; then ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${rc}" -eq "${expected}" ]; then In test_vxlan_vnifiltering.sh line 115: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In test_vxlan_vnifiltering.sh line 123: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In test_vxlan_vnifiltering.sh line 135: printf "COMMAND: $cmd\n" ^---------------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In test_vxlan_vnifiltering.sh line 139: out=$(eval $cmd $stderr) ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: out=$(eval "$cmd" "$stderr") In test_vxlan_vnifiltering.sh line 141: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In test_vxlan_vnifiltering.sh line 145: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In test_vxlan_vnifiltering.sh line 149: slowwait 5 ip netns exec $hv_1 ping -c 1 -W 1 $1 &>/dev/null ^---^ SC2154 (warning): hv_1 is referenced but not assigned. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: slowwait 5 ip netns exec "$hv_1" ping -c 1 -W 1 "$1" &>/dev/null In test_vxlan_vnifiltering.sh line 150: slowwait 5 ip netns exec $hv_1 ping -c 1 -W 1 $2 &>/dev/null ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: slowwait 5 ip netns exec "$hv_1" ping -c 1 -W 1 "$2" &>/dev/null In test_vxlan_vnifiltering.sh line 156: slowwait 5 run_cmd "ip netns exec $vm_11 ping -c 1 -W 1 10.0.10.12" ^----^ SC2154 (warning): vm_11 is referenced but not assigned. In test_vxlan_vnifiltering.sh line 159: slowwait 5 run_cmd "ip netns exec $vm_21 ping -c 1 -W 1 10.0.10.22" ^----^ SC2154 (warning): vm_21 is referenced but not assigned. In test_vxlan_vnifiltering.sh line 167: cleanup_ns $hv_1 $hv_2 $vm_11 $vm_21 $vm_12 $vm_22 $vm_31 $vm_32 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2154 (warning): hv_2 is referenced but not assigned. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2154 (warning): vm_12 is referenced but not assigned. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2154 (warning): vm_22 is referenced but not assigned. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2154 (warning): vm_31 is referenced but not assigned. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2154 (warning): vm_32 is referenced but not assigned. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cleanup_ns "$hv_1" "$hv_2" "$vm_11" "$vm_21" "$vm_12" "$vm_22" "$vm_31" "$vm_32" In test_vxlan_vnifiltering.sh line 179: ip link set veth-hv-$id netns ${hv[$id]} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set veth-hv-"$id" netns "${hv[$id]}" In test_vxlan_vnifiltering.sh line 180: ip -netns ${hv[$id]} link set veth-hv-$id name veth0 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$id]}" link set veth-hv-"$id" name veth0 In test_vxlan_vnifiltering.sh line 181: ip -netns ${hv[$id]} addr add $local1/$mask1 dev veth0 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$id]}" addr add "$local1"/"$mask1" dev veth0 In test_vxlan_vnifiltering.sh line 182: ip -netns ${hv[$id]} addr add $local2/$mask2 dev veth0 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$id]}" addr add "$local2"/"$mask2" dev veth0 In test_vxlan_vnifiltering.sh line 183: ip -netns ${hv[$id]} link set veth0 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$id]}" link set veth0 up In test_vxlan_vnifiltering.sh line 205: ip -netns ${hv[$hvid]} link add br$brid type bridge vlan_filtering 1 vlan_default_pvid 0 \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$hvid]}" link add br"$brid" type bridge vlan_filtering 1 vlan_default_pvid 0 \ In test_vxlan_vnifiltering.sh line 207: ip -netns ${hv[$hvid]} link set br$brid up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$hvid]}" link set br"$brid" up In test_vxlan_vnifiltering.sh line 213: ip link add $hvvethif type veth peer name $vmvethif ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add "$hvvethif" type veth peer name "$vmvethif" In test_vxlan_vnifiltering.sh line 214: ip link set $hvvethif netns ${hv[$hvid]} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$hvvethif" netns "${hv[$hvid]}" In test_vxlan_vnifiltering.sh line 215: ip link set $vmvethif netns ${vm[$vmid]} ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$vmvethif" netns "${vm[$vmid]}" In test_vxlan_vnifiltering.sh line 216: ip -netns ${hv[$hvid]} link set $hvvethif up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$hvid]}" link set "$hvvethif" up In test_vxlan_vnifiltering.sh line 217: ip -netns ${vm[$vmid]} link set $vmvethif up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${vm[$vmid]}" link set "$vmvethif" up In test_vxlan_vnifiltering.sh line 218: ip -netns ${hv[$hvid]} link set $hvvethif master br$brid ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$hvid]}" link set "$hvvethif" master br"$brid" In test_vxlan_vnifiltering.sh line 221: for vmap in $(echo $vattrs | cut -d "," -f1- --output-delimiter=' ') ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: for vmap in $(echo "$vattrs" | cut -d "," -f1- --output-delimiter=' ') In test_vxlan_vnifiltering.sh line 223: local vid=$(echo $vmap | awk -F'-' '{print ($1)}') ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local vid=$(echo "$vmap" | awk -F'-' '{print ($1)}') In test_vxlan_vnifiltering.sh line 224: local family=$(echo $vmap | awk -F'-' '{print ($2)}') ^----^ SC2034 (warning): family appears unused. Verify use (or export if used externally). ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local family=$(echo "$vmap" | awk -F'-' '{print ($2)}') In test_vxlan_vnifiltering.sh line 225: local localip=$(echo $vmap | awk -F'-' '{print ($3)}') ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local localip=$(echo "$vmap" | awk -F'-' '{print ($3)}') In test_vxlan_vnifiltering.sh line 226: local group=$(echo $vmap | awk -F'-' '{print ($4)}') ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local group=$(echo "$vmap" | awk -F'-' '{print ($4)}') In test_vxlan_vnifiltering.sh line 227: local vtype=$(echo $vmap | awk -F'-' '{print ($5)}') ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local vtype=$(echo "$vmap" | awk -F'-' '{print ($5)}') In test_vxlan_vnifiltering.sh line 228: local port=$(echo $vmap | awk -F'-' '{print ($6)}') ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local port=$(echo "$vmap" | awk -F'-' '{print ($6)}') In test_vxlan_vnifiltering.sh line 230: ip -netns ${vm[$vmid]} link add name $vmvethif.$vid link $vmvethif type vlan id $vid ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${vm[$vmid]}" link add name "$vmvethif"."$vid" link "$vmvethif" type vlan id "$vid" In test_vxlan_vnifiltering.sh line 231: ip -netns ${vm[$vmid]} addr add 10.0.$vid.$vmid/24 dev $vmvethif.$vid ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${vm[$vmid]}" addr add 10.0."$vid"."$vmid"/24 dev "$vmvethif"."$vid" In test_vxlan_vnifiltering.sh line 232: ip -netns ${vm[$vmid]} link set $vmvethif.$vid up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${vm[$vmid]}" link set "$vmvethif"."$vid" up In test_vxlan_vnifiltering.sh line 250: if [ $mcast -eq 1 ]; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$mcast" -eq 1 ]; then In test_vxlan_vnifiltering.sh line 264: ip -netns ${hv[$hvid]} link add $vxlandev type vxlan local $localip $vxlandevflags dev veth0 2>/dev/null ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$hvid]}" link add "$vxlandev" type vxlan local "$localip" "$vxlandevflags" dev veth0 2>/dev/null In test_vxlan_vnifiltering.sh line 265: ip -netns ${hv[$hvid]} link set $vxlandev master br$brid ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$hvid]}" link set "$vxlandev" master br"$brid" In test_vxlan_vnifiltering.sh line 266: ip -netns ${hv[$hvid]} link set $vxlandev up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${hv[$hvid]}" link set "$vxlandev" up In test_vxlan_vnifiltering.sh line 271: bridge -netns ${hv[$hvid]} vlan add vid $vid dev $hvvethif ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -netns "${hv[$hvid]}" vlan add vid "$vid" dev "$hvvethif" In test_vxlan_vnifiltering.sh line 272: bridge -netns ${hv[$hvid]} vlan add vid $vid pvid dev $vxlandev ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -netns "${hv[$hvid]}" vlan add vid "$vid" pvid dev "$vxlandev" In test_vxlan_vnifiltering.sh line 276: bridge -netns ${hv[$hvid]} link set dev $vxlandev vlan_tunnel on ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -netns "${hv[$hvid]}" link set dev "$vxlandev" vlan_tunnel on In test_vxlan_vnifiltering.sh line 277: bridge -netns ${hv[$hvid]} vlan add dev $vxlandev vid $vid tunnel_info id $tid ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -netns "${hv[$hvid]}" vlan add dev "$vxlandev" vid "$vid" tunnel_info id "$tid" In test_vxlan_vnifiltering.sh line 281: bridge -netns ${hv[$hvid]} fdb add 00:00:00:00:00:00 dev $vxlandev \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -netns "${hv[$hvid]}" fdb add 00:00:00:00:00:00 dev "$vxlandev" \ In test_vxlan_vnifiltering.sh line 282: src_vni $tid vni $tid dst $group self ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: src_vni "$tid" vni "$tid" dst "$group" self In test_vxlan_vnifiltering.sh line 285: bridge -netns ${hv[$hvid]} vni add dev $vxlandev vni $tid ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -netns "${hv[$hvid]}" vni add dev "$vxlandev" vni "$tid" In test_vxlan_vnifiltering.sh line 289: if [ $mcast -eq 1 ]; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$mcast" -eq 1 ]; then In test_vxlan_vnifiltering.sh line 290: bridge -netns ${hv[$hvid]} vni add dev $vxlandev vni $tid group $group ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -netns "${hv[$hvid]}" vni add dev "$vxlandev" vni "$tid" group "$group" In test_vxlan_vnifiltering.sh line 292: bridge -netns ${hv[$hvid]} vni add dev $vxlandev vni $tid remote $group ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -netns "${hv[$hvid]}" vni add dev "$vxlandev" vni "$tid" remote "$group" In test_vxlan_vnifiltering.sh line 303: ip link set veth-testns netns $testns ^-----^ SC2154 (warning): testns is referenced but not assigned. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set veth-testns netns "$testns" In test_vxlan_vnifiltering.sh line 309: ip netns del $testns 2>/dev/null || true ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" 2>/dev/null || true In test_vxlan_vnifiltering.sh line 390: setup-hv-networking 1 $hv1addr1 24 $hv1addr2 64 $hv2addr1 $hv2addr2 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 1 "$hv1addr1" 24 "$hv1addr2" 64 "$hv2addr1" "$hv2addr2" In test_vxlan_vnifiltering.sh line 391: setup-hv-networking 2 $hv2addr1 24 $hv2addr2 64 $hv1addr1 $hv1addr2 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 2 "$hv2addr1" 24 "$hv2addr2" 64 "$hv1addr1" "$hv1addr2" In test_vxlan_vnifiltering.sh line 400: setup-vm 1 11 1 10-v4-$hv1addr1-$hv2addr1-vnifilter,20-v4-$hv1addr1-$hv2addr1-vnifilter 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 11 1 10-v4-"$hv1addr1"-"$hv2addr1"-vnifilter,20-v4-"$hv1addr1"-"$hv2addr1"-vnifilter 0 In test_vxlan_vnifiltering.sh line 401: setup-vm 1 21 2 10-v6-$hv1addr2-$hv2addr2-vnifilter,20-v6-$hv1addr2-$hv2addr2-vnifilter 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 21 2 10-v6-"$hv1addr2"-"$hv2addr2"-vnifilter,20-v6-"$hv1addr2"-"$hv2addr2"-vnifilter 0 In test_vxlan_vnifiltering.sh line 403: setup-vm 2 12 1 10-v4-$hv2addr1-$hv1addr1-vnifilter,20-v4-$hv2addr1-$hv1addr1-vnifilter 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 12 1 10-v4-"$hv2addr1"-"$hv1addr1"-vnifilter,20-v4-"$hv2addr1"-"$hv1addr1"-vnifilter 0 In test_vxlan_vnifiltering.sh line 404: setup-vm 2 22 2 10-v6-$hv2addr2-$hv1addr2-vnifilter,20-v6-$hv2addr2-$hv1addr2-vnifilter 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 22 2 10-v6-"$hv2addr2"-"$hv1addr2"-vnifilter,20-v6-"$hv2addr2"-"$hv1addr2"-vnifilter 0 In test_vxlan_vnifiltering.sh line 423: setup-hv-networking 1 $hv1addr1 24 $hv1addr2 64 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 1 "$hv1addr1" 24 "$hv1addr2" 64 In test_vxlan_vnifiltering.sh line 424: setup-hv-networking 2 $hv2addr1 24 $hv2addr2 64 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 2 "$hv2addr1" 24 "$hv2addr2" 64 In test_vxlan_vnifiltering.sh line 433: setup-vm 1 11 1 10-v4-$hv1addr1-$hv2addr1-vnifilterg,20-v4-$hv1addr1-$hv2addr1-vnifilterg 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 11 1 10-v4-"$hv1addr1"-"$hv2addr1"-vnifilterg,20-v4-"$hv1addr1"-"$hv2addr1"-vnifilterg 0 In test_vxlan_vnifiltering.sh line 434: setup-vm 1 21 2 10-v6-$hv1addr2-$hv2addr2-vnifilterg,20-v6-$hv1addr2-$hv2addr2-vnifilterg 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 21 2 10-v6-"$hv1addr2"-"$hv2addr2"-vnifilterg,20-v6-"$hv1addr2"-"$hv2addr2"-vnifilterg 0 In test_vxlan_vnifiltering.sh line 436: setup-vm 2 12 1 10-v4-$hv2addr1-$hv1addr1-vnifilterg,20-v4-$hv2addr1-$hv1addr1-vnifilterg 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 12 1 10-v4-"$hv2addr1"-"$hv1addr1"-vnifilterg,20-v4-"$hv2addr1"-"$hv1addr1"-vnifilterg 0 In test_vxlan_vnifiltering.sh line 437: setup-vm 2 22 2 10-v6-$hv2addr2-$hv1addr2-vnifilterg,20-v6-$hv2addr2-$hv1addr2-vnifilterg 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 22 2 10-v6-"$hv2addr2"-"$hv1addr2"-vnifilterg,20-v6-"$hv2addr2"-"$hv1addr2"-vnifilterg 0 In test_vxlan_vnifiltering.sh line 456: setup-hv-networking 1 $hv1addr1 24 $hv1addr2 64 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 1 "$hv1addr1" 24 "$hv1addr2" 64 In test_vxlan_vnifiltering.sh line 457: setup-hv-networking 2 $hv2addr1 24 $hv2addr2 64 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 2 "$hv2addr1" 24 "$hv2addr2" 64 In test_vxlan_vnifiltering.sh line 466: setup-vm 1 11 1 10-v4-$hv1addr1-$group-vnifilter,20-v4-$hv1addr1-$group-vnifilter 1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 11 1 10-v4-"$hv1addr1"-"$group"-vnifilter,20-v4-"$hv1addr1"-"$group"-vnifilter 1 In test_vxlan_vnifiltering.sh line 469: setup-vm 2 12 1 10-v4-$hv2addr1-$group-vnifilter,20-v4-$hv2addr1-$group-vnifilter 1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 12 1 10-v4-"$hv2addr1"-"$group"-vnifilter,20-v4-"$hv2addr1"-"$group"-vnifilter 1 In test_vxlan_vnifiltering.sh line 470: setup-vm 2 22 2 10-v6-$hv2addr2-$group6-vnifilter,20-v6-$hv2addr2-$group6-vnifilter 1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 22 2 10-v6-"$hv2addr2"-"$group6"-vnifilter,20-v6-"$hv2addr2"-"$group6"-vnifilter 1 In test_vxlan_vnifiltering.sh line 488: setup-hv-networking 1 $hv1addr1 24 $hv1addr2 64 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 1 "$hv1addr1" 24 "$hv1addr2" 64 In test_vxlan_vnifiltering.sh line 489: setup-hv-networking 2 $hv2addr1 24 $hv2addr2 64 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 2 "$hv2addr1" 24 "$hv2addr2" 64 In test_vxlan_vnifiltering.sh line 498: setup-vm 1 11 1 10-v4-$hv1addr1-$group-vnifilterg,20-v4-$hv1addr1-$group-vnifilterg 1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 11 1 10-v4-"$hv1addr1"-"$group"-vnifilterg,20-v4-"$hv1addr1"-"$group"-vnifilterg 1 In test_vxlan_vnifiltering.sh line 499: setup-vm 1 21 2 10-v6-$hv1addr2-$group6-vnifilterg,20-v6-$hv1addr2-$group6-vnifilterg 1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 21 2 10-v6-"$hv1addr2"-"$group6"-vnifilterg,20-v6-"$hv1addr2"-"$group6"-vnifilterg 1 In test_vxlan_vnifiltering.sh line 501: setup-vm 2 12 1 10-v4-$hv2addr1-$group-vnifilterg,20-v4-$hv2addr1-$group-vnifilterg 1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 12 1 10-v4-"$hv2addr1"-"$group"-vnifilterg,20-v4-"$hv2addr1"-"$group"-vnifilterg 1 In test_vxlan_vnifiltering.sh line 502: setup-vm 2 22 2 10-v6-$hv2addr2-$group6-vnifilterg,20-v6-$hv2addr2-$group6-vnifilterg 1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 22 2 10-v6-"$hv2addr2"-"$group6"-vnifilterg,20-v6-"$hv2addr2"-"$group6"-vnifilterg 1 In test_vxlan_vnifiltering.sh line 518: setup-hv-networking 1 $hv1addr1 24 $hv1addr2 64 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 1 "$hv1addr1" 24 "$hv1addr2" 64 In test_vxlan_vnifiltering.sh line 519: setup-hv-networking 2 $hv2addr1 24 $hv2addr2 64 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-hv-networking 2 "$hv2addr1" 24 "$hv2addr2" 64 In test_vxlan_vnifiltering.sh line 530: setup-vm 1 11 1 10-v4-$hv1addr1-$hv2addr1-vnifilter,20-v4-$hv1addr1-$hv2addr1-vnifilter 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 11 1 10-v4-"$hv1addr1"-"$hv2addr1"-vnifilter,20-v4-"$hv1addr1"-"$hv2addr1"-vnifilter 0 In test_vxlan_vnifiltering.sh line 531: setup-vm 1 21 2 10-v6-$hv1addr2-$hv2addr2-vnifilter,20-v6-$hv1addr2-$hv2addr2-vnifilter 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 21 2 10-v6-"$hv1addr2"-"$hv2addr2"-vnifilter,20-v6-"$hv1addr2"-"$hv2addr2"-vnifilter 0 In test_vxlan_vnifiltering.sh line 532: setup-vm 1 31 3 30-v4-$hv1addr1-$hv2addr1-default-4790,40-v6-$hv1addr2-$hv2addr2-default-4790,50-v4-$hv1addr1-$hv2addr1-metadata-4791 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 1 31 3 30-v4-"$hv1addr1"-"$hv2addr1"-default-4790,40-v6-"$hv1addr2"-"$hv2addr2"-default-4790,50-v4-"$hv1addr1"-"$hv2addr1"-metadata-4791 0 In test_vxlan_vnifiltering.sh line 535: setup-vm 2 12 1 10-v4-$hv2addr1-$hv1addr1-vnifilter,20-v4-$hv2addr1-$hv1addr1-vnifilter 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 12 1 10-v4-"$hv2addr1"-"$hv1addr1"-vnifilter,20-v4-"$hv2addr1"-"$hv1addr1"-vnifilter 0 In test_vxlan_vnifiltering.sh line 536: setup-vm 2 22 2 10-v6-$hv2addr2-$hv1addr2-vnifilter,20-v6-$hv2addr2-$hv1addr2-vnifilter 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 22 2 10-v6-"$hv2addr2"-"$hv1addr2"-vnifilter,20-v6-"$hv2addr2"-"$hv1addr2"-vnifilter 0 In test_vxlan_vnifiltering.sh line 537: setup-vm 2 32 3 30-v4-$hv2addr1-$hv1addr1-default-4790,40-v6-$hv2addr2-$hv1addr2-default-4790,50-v4-$hv2addr1-$hv1addr1-metadata-4791 0 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup-vm 2 32 3 30-v4-"$hv2addr1"-"$hv1addr1"-default-4790,40-v6-"$hv2addr2"-"$hv1addr2"-default-4790,50-v4-"$hv2addr1"-"$hv1addr1"-metadata-4791 0 In test_vxlan_vnifiltering.sh line 558: v) VERBOSE=$(($VERBOSE + 1));; ^------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In test_vxlan_vnifiltering.sh line 578: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In test_vxlan_vnifiltering.sh line 585: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In test_vxlan_vnifiltering.sh line 602: printf "\nTests passed: %3d\n" ${nsuccess} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf "\nTests passed: %3d\n" "${nsuccess}" In test_vxlan_vnifiltering.sh line 603: printf "Tests failed: %3d\n" ${nfail} ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf "Tests failed: %3d\n" "${nfail}" For more information: https://www.shellcheck.net/wiki/SC2034 -- family appears unused. Verify use... https://www.shellcheck.net/wiki/SC2154 -- hv_1 is referenced but not assign... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...