ShellCheck - shell script analysis tool version: 0.10.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.aP0Z3Yh4Ho and /tmp/tmp.3r1qK4FlXD Tree base: dd4a5780f7d9 ("net: enetc: replace PCVLANR1/2 with SICVLANR1/2 and remove dead branch") Now at: c3398ac53cc5 ("selftests: net: use slowwait to stabilize vrf_route_leaking test") ====== Checking before the patch ====== Checking tools/testing/selftests/net/vrf_route_leaking.sh - 1d3d2f86ea7db6ff64c60e8f920ff5b58e0a6ae9967ae0efdb6853cb382c7fb6 In vrf_route_leaking.sh line 175: cleanup_ns $h1 $h2 $r1 $r2 ^-^ SC2154 (warning): h1 is referenced but not assigned. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2154 (warning): h2 is referenced but not assigned. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2154 (warning): r1 is referenced but not assigned. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2154 (warning): r2 is referenced but not assigned. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cleanup_ns "$h1" "$h2" "$r1" "$r2" In vrf_route_leaking.sh line 214: if echo $ns | grep -q h[12]-; then ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2062 (warning): Quote the grep pattern so the shell won't interpret it. Did you mean: if echo "$ns" | grep -q h[12]-; then In vrf_route_leaking.sh line 215: ip netns exec $ns sysctl -q -w net.ipv6.conf.all.forwarding=0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -q -w net.ipv6.conf.all.forwarding=0 In vrf_route_leaking.sh line 216: ip netns exec $ns sysctl -q -w net.ipv6.conf.all.keep_addr_on_down=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -q -w net.ipv6.conf.all.keep_addr_on_down=1 In vrf_route_leaking.sh line 218: ip netns exec $ns sysctl -q -w net.ipv4.ip_forward=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -q -w net.ipv4.ip_forward=1 In vrf_route_leaking.sh line 219: ip netns exec $ns sysctl -q -w net.ipv6.conf.all.forwarding=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -q -w net.ipv6.conf.all.forwarding=1 In vrf_route_leaking.sh line 226: ip -netns $h1 link add eth0 type veth peer name r1h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link add eth0 type veth peer name r1h1 In vrf_route_leaking.sh line 227: ip -netns $h1 link set r1h1 netns $r1 name eth0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link set r1h1 netns "$r1" name eth0 up In vrf_route_leaking.sh line 229: ip -netns $h2 link add eth0 type veth peer name r1h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link add eth0 type veth peer name r1h2 In vrf_route_leaking.sh line 230: ip -netns $h2 link set r1h2 netns $r1 name eth1 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link set r1h2 netns "$r1" name eth1 up In vrf_route_leaking.sh line 235: ip -netns $h1 addr add dev eth0 ${H1_N1_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" addr add dev eth0 ${H1_N1_IP}/24 In vrf_route_leaking.sh line 236: ip -netns $h1 -6 addr add dev eth0 ${H1_N1_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" -6 addr add dev eth0 ${H1_N1_IP6}/64 nodad In vrf_route_leaking.sh line 237: ip -netns $h1 link set eth0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link set eth0 up In vrf_route_leaking.sh line 240: ip -netns $h1 route add ${H2_N2} via ${R1_N1_IP} dev eth0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" route add ${H2_N2} via ${R1_N1_IP} dev eth0 In vrf_route_leaking.sh line 241: ip -netns $h1 -6 route add ${H2_N2_6} via "${R1_N1_IP6}" dev eth0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" -6 route add ${H2_N2_6} via "${R1_N1_IP6}" dev eth0 In vrf_route_leaking.sh line 246: ip -netns $h2 addr add dev eth0 ${H2_N2_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" addr add dev eth0 ${H2_N2_IP}/24 In vrf_route_leaking.sh line 247: ip -netns $h2 -6 addr add dev eth0 ${H2_N2_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" -6 addr add dev eth0 ${H2_N2_IP6}/64 nodad In vrf_route_leaking.sh line 248: ip -netns $h2 link set eth0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link set eth0 up In vrf_route_leaking.sh line 251: ip -netns $h2 route add default via ${R1_N2_IP} dev eth0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" route add default via ${R1_N2_IP} dev eth0 In vrf_route_leaking.sh line 252: ip -netns $h2 -6 route add default via ${R1_N2_IP6} dev eth0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" -6 route add default via ${R1_N2_IP6} dev eth0 In vrf_route_leaking.sh line 257: setup_vrf $r1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vrf "$r1" In vrf_route_leaking.sh line 258: create_vrf $r1 blue 1101 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: create_vrf "$r1" blue 1101 In vrf_route_leaking.sh line 259: create_vrf $r1 red 1102 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: create_vrf "$r1" red 1102 In vrf_route_leaking.sh line 260: ip -netns $r1 link set mtu 1400 dev eth1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" link set mtu 1400 dev eth1 In vrf_route_leaking.sh line 261: ip -netns $r1 link set eth0 vrf blue up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" link set eth0 vrf blue up In vrf_route_leaking.sh line 262: ip -netns $r1 link set eth1 vrf red up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" link set eth1 vrf red up In vrf_route_leaking.sh line 263: ip -netns $r1 addr add dev eth0 ${R1_N1_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" addr add dev eth0 ${R1_N1_IP}/24 In vrf_route_leaking.sh line 264: ip -netns $r1 -6 addr add dev eth0 ${R1_N1_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" -6 addr add dev eth0 ${R1_N1_IP6}/64 nodad In vrf_route_leaking.sh line 265: ip -netns $r1 addr add dev eth1 ${R1_N2_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" addr add dev eth1 ${R1_N2_IP}/24 In vrf_route_leaking.sh line 266: ip -netns $r1 -6 addr add dev eth1 ${R1_N2_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" -6 addr add dev eth1 ${R1_N2_IP6}/64 nodad In vrf_route_leaking.sh line 269: ip -netns $r1 route add vrf blue ${H2_N2} dev red ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" route add vrf blue ${H2_N2} dev red In vrf_route_leaking.sh line 270: ip -netns $r1 -6 route add vrf blue ${H2_N2_6} dev red ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" -6 route add vrf blue ${H2_N2_6} dev red In vrf_route_leaking.sh line 273: ip -netns $r1 route add vrf red ${H1_N1} dev blue ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" route add vrf red ${H1_N1} dev blue In vrf_route_leaking.sh line 274: ip -netns $r1 -6 route add vrf red ${H1_N1_6} dev blue ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" -6 route add vrf red ${H1_N1_6} dev blue In vrf_route_leaking.sh line 292: if echo $ns | grep -q h[12]-; then ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2062 (warning): Quote the grep pattern so the shell won't interpret it. Did you mean: if echo "$ns" | grep -q h[12]-; then In vrf_route_leaking.sh line 293: ip netns exec $ns sysctl -q -w net.ipv6.conf.all.forwarding=0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -q -w net.ipv6.conf.all.forwarding=0 In vrf_route_leaking.sh line 294: ip netns exec $ns sysctl -q -w net.ipv6.conf.all.keep_addr_on_down=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -q -w net.ipv6.conf.all.keep_addr_on_down=1 In vrf_route_leaking.sh line 296: ip netns exec $ns sysctl -q -w net.ipv4.ip_forward=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -q -w net.ipv4.ip_forward=1 In vrf_route_leaking.sh line 297: ip netns exec $ns sysctl -q -w net.ipv6.conf.all.forwarding=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -q -w net.ipv6.conf.all.forwarding=1 In vrf_route_leaking.sh line 304: ip -netns $h1 link add eth0 type veth peer name r1h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link add eth0 type veth peer name r1h1 In vrf_route_leaking.sh line 305: ip -netns $h1 link set r1h1 netns $r1 name eth0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link set r1h1 netns "$r1" name eth0 up In vrf_route_leaking.sh line 307: ip -netns $h1 link add eth1 type veth peer name r2h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link add eth1 type veth peer name r2h1 In vrf_route_leaking.sh line 308: ip -netns $h1 link set r2h1 netns $r2 name eth0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link set r2h1 netns "$r2" name eth0 up In vrf_route_leaking.sh line 310: ip -netns $h2 link add eth0 type veth peer name r1h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link add eth0 type veth peer name r1h2 In vrf_route_leaking.sh line 311: ip -netns $h2 link set r1h2 netns $r1 name eth1 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link set r1h2 netns "$r1" name eth1 up In vrf_route_leaking.sh line 313: ip -netns $h2 link add eth1 type veth peer name r2h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link add eth1 type veth peer name r2h2 In vrf_route_leaking.sh line 314: ip -netns $h2 link set r2h2 netns $r2 name eth1 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link set r2h2 netns "$r2" name eth1 up In vrf_route_leaking.sh line 319: ip -netns $h1 link add br0 type bridge ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link add br0 type bridge In vrf_route_leaking.sh line 320: ip -netns $h1 link set br0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link set br0 up In vrf_route_leaking.sh line 321: ip -netns $h1 addr add dev br0 ${H1_N1_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" addr add dev br0 ${H1_N1_IP}/24 In vrf_route_leaking.sh line 322: ip -netns $h1 -6 addr add dev br0 ${H1_N1_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" -6 addr add dev br0 ${H1_N1_IP6}/64 nodad In vrf_route_leaking.sh line 323: ip -netns $h1 link set eth0 master br0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link set eth0 master br0 up In vrf_route_leaking.sh line 324: ip -netns $h1 link set eth1 master br0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link set eth1 master br0 up In vrf_route_leaking.sh line 327: ip -netns $h1 route add ${H2_N2} via ${R1_N1_IP} dev br0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" route add ${H2_N2} via ${R1_N1_IP} dev br0 In vrf_route_leaking.sh line 328: ip -netns $h1 -6 route add ${H2_N2_6} via "${R1_N1_IP6}" dev br0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" -6 route add ${H2_N2_6} via "${R1_N1_IP6}" dev br0 In vrf_route_leaking.sh line 333: ip -netns $h2 link add br0 type bridge ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link add br0 type bridge In vrf_route_leaking.sh line 334: ip -netns $h2 link set br0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link set br0 up In vrf_route_leaking.sh line 335: ip -netns $h2 addr add dev br0 ${H2_N2_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" addr add dev br0 ${H2_N2_IP}/24 In vrf_route_leaking.sh line 336: ip -netns $h2 -6 addr add dev br0 ${H2_N2_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" -6 addr add dev br0 ${H2_N2_IP6}/64 nodad In vrf_route_leaking.sh line 337: ip -netns $h2 link set eth0 master br0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link set eth0 master br0 up In vrf_route_leaking.sh line 338: ip -netns $h2 link set eth1 master br0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link set eth1 master br0 up In vrf_route_leaking.sh line 341: ip -netns $h2 route add default via ${R2_N2_IP} dev br0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" route add default via ${R2_N2_IP} dev br0 In vrf_route_leaking.sh line 342: ip -netns $h2 -6 route add default via ${R2_N2_IP6} dev br0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" -6 route add default via ${R2_N2_IP6} dev br0 In vrf_route_leaking.sh line 347: setup_vrf $r1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vrf "$r1" In vrf_route_leaking.sh line 348: create_vrf $r1 blue 1101 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: create_vrf "$r1" blue 1101 In vrf_route_leaking.sh line 349: create_vrf $r1 red 1102 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: create_vrf "$r1" red 1102 In vrf_route_leaking.sh line 350: ip -netns $r1 link set mtu 1400 dev eth1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" link set mtu 1400 dev eth1 In vrf_route_leaking.sh line 351: ip -netns $r1 link set eth0 vrf blue up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" link set eth0 vrf blue up In vrf_route_leaking.sh line 352: ip -netns $r1 link set eth1 vrf red up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" link set eth1 vrf red up In vrf_route_leaking.sh line 353: ip -netns $r1 addr add dev eth0 ${R1_N1_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" addr add dev eth0 ${R1_N1_IP}/24 In vrf_route_leaking.sh line 354: ip -netns $r1 -6 addr add dev eth0 ${R1_N1_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" -6 addr add dev eth0 ${R1_N1_IP6}/64 nodad In vrf_route_leaking.sh line 355: ip -netns $r1 addr add dev eth1 ${R1_N2_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" addr add dev eth1 ${R1_N2_IP}/24 In vrf_route_leaking.sh line 356: ip -netns $r1 -6 addr add dev eth1 ${R1_N2_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" -6 addr add dev eth1 ${R1_N2_IP6}/64 nodad In vrf_route_leaking.sh line 359: ip -netns $r1 route add vrf blue ${H2_N2} dev red ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" route add vrf blue ${H2_N2} dev red In vrf_route_leaking.sh line 360: ip -netns $r1 -6 route add vrf blue ${H2_N2_6} dev red ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" -6 route add vrf blue ${H2_N2_6} dev red In vrf_route_leaking.sh line 367: ip -netns $r2 addr add dev eth0 ${R2_N1_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r2" addr add dev eth0 ${R2_N1_IP}/24 In vrf_route_leaking.sh line 368: ip -netns $r2 -6 addr add dev eth0 ${R2_N1_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r2" -6 addr add dev eth0 ${R2_N1_IP6}/64 nodad In vrf_route_leaking.sh line 369: ip -netns $r2 addr add dev eth1 ${R2_N2_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r2" addr add dev eth1 ${R2_N2_IP}/24 In vrf_route_leaking.sh line 370: ip -netns $r2 -6 addr add dev eth1 ${R2_N2_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r2" -6 addr add dev eth1 ${R2_N2_IP6}/64 nodad In vrf_route_leaking.sh line 378: ip netns exec $h1 ping -c1 -w1 ${H2_N2_IP} >/dev/null 2>&1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$h1" ping -c1 -w1 ${H2_N2_IP} >/dev/null 2>&1 In vrf_route_leaking.sh line 385: ip netns exec $h1 "${ping6}" -c1 -w1 ${H2_N2_IP6} >/dev/null 2>&1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$h1" "${ping6}" -c1 -w1 ${H2_N2_IP6} >/dev/null 2>&1 In vrf_route_leaking.sh line 410: [ "x$ttype" = "x" ] && ttype="$DEFAULT_TTYPE" ^-------^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose. Did you mean: [ "$ttype" = "" ] && ttype="$DEFAULT_TTYPE" In vrf_route_leaking.sh line 420: run_cmd_grep "${R1_N1_IP}" ip netns exec $h1 traceroute ${H2_N2_IP} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "${R1_N1_IP}" ip netns exec "$h1" traceroute ${H2_N2_IP} In vrf_route_leaking.sh line 433: [ "x$ttype" = "x" ] && ttype="$DEFAULT_TTYPE" ^-------^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose. Did you mean: [ "$ttype" = "" ] && ttype="$DEFAULT_TTYPE" In vrf_route_leaking.sh line 443: run_cmd_grep "${R1_N1_IP6}" ip netns exec $h1 traceroute6 ${H2_N2_IP6} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "${R1_N1_IP6}" ip netns exec "$h1" traceroute6 ${H2_N2_IP6} In vrf_route_leaking.sh line 456: [ "x$ttype" = "x" ] && ttype="$DEFAULT_TTYPE" ^-------^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose. Did you mean: [ "$ttype" = "" ] && ttype="$DEFAULT_TTYPE" In vrf_route_leaking.sh line 464: run_cmd_grep "Time to live exceeded" ip netns exec $h1 ping -t1 -c1 -W2 ${H2_N2_IP} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "Time to live exceeded" ip netns exec "$h1" ping -t1 -c1 -W2 ${H2_N2_IP} In vrf_route_leaking.sh line 477: [ "x$ttype" = "x" ] && ttype="$DEFAULT_TTYPE" ^-------^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose. Did you mean: [ "$ttype" = "" ] && ttype="$DEFAULT_TTYPE" In vrf_route_leaking.sh line 485: run_cmd_grep "Frag needed" ip netns exec $h1 ping -s 1450 -Mdo -c1 -W2 ${H2_N2_IP} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "Frag needed" ip netns exec "$h1" ping -s 1450 -Mdo -c1 -W2 ${H2_N2_IP} In vrf_route_leaking.sh line 498: [ "x$ttype" = "x" ] && ttype="$DEFAULT_TTYPE" ^-------^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose. Did you mean: [ "$ttype" = "" ] && ttype="$DEFAULT_TTYPE" In vrf_route_leaking.sh line 506: run_cmd_grep "Time exceeded: Hop limit" ip netns exec $h1 "${ping6}" -t1 -c1 -W2 ${H2_N2_IP6} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "Time exceeded: Hop limit" ip netns exec "$h1" "${ping6}" -t1 -c1 -W2 ${H2_N2_IP6} In vrf_route_leaking.sh line 519: [ "x$ttype" = "x" ] && ttype="$DEFAULT_TTYPE" ^-------^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose. Did you mean: [ "$ttype" = "" ] && ttype="$DEFAULT_TTYPE" In vrf_route_leaking.sh line 527: run_cmd_grep "Packet too big" ip netns exec $h1 "${ping6}" -s 1450 -Mdo -c1 -W2 ${H2_N2_IP6} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "Packet too big" ip netns exec "$h1" "${ping6}" -s 1450 -Mdo -c1 -W2 ${H2_N2_IP6} In vrf_route_leaking.sh line 544: run_cmd ip netns exec $r1 ip vrf exec blue ping -c1 -w1 ${H2_N2_IP} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$r1" ip vrf exec blue ping -c1 -w1 ${H2_N2_IP} In vrf_route_leaking.sh line 584: run_cmd ip netns exec $r1 ip vrf exec blue ${ping6} -c1 -w1 ${H2_N2_IP6} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$r1" ip vrf exec blue "${ping6}" -c1 -w1 ${H2_N2_IP6} For more information: https://www.shellcheck.net/wiki/SC2062 -- Quote the grep pattern so the she... https://www.shellcheck.net/wiki/SC2154 -- h1 is referenced but not assigned. https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/vrf_route_leaking.sh - 1d3d2f86ea7db6ff64c60e8f920ff5b58e0a6ae9967ae0efdb6853cb382c7fb6 In vrf_route_leaking.sh line 175: cleanup_ns $h1 $h2 $r1 $r2 ^-^ SC2154 (warning): h1 is referenced but not assigned. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2154 (warning): h2 is referenced but not assigned. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2154 (warning): r1 is referenced but not assigned. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2154 (warning): r2 is referenced but not assigned. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cleanup_ns "$h1" "$h2" "$r1" "$r2" In vrf_route_leaking.sh line 214: if echo $ns | grep -q h[12]-; then ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2062 (warning): Quote the grep pattern so the shell won't interpret it. Did you mean: if echo "$ns" | grep -q h[12]-; then In vrf_route_leaking.sh line 215: ip netns exec $ns sysctl -q -w net.ipv6.conf.all.forwarding=0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -q -w net.ipv6.conf.all.forwarding=0 In vrf_route_leaking.sh line 216: ip netns exec $ns sysctl -q -w net.ipv6.conf.all.keep_addr_on_down=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -q -w net.ipv6.conf.all.keep_addr_on_down=1 In vrf_route_leaking.sh line 218: ip netns exec $ns sysctl -q -w net.ipv4.ip_forward=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -q -w net.ipv4.ip_forward=1 In vrf_route_leaking.sh line 219: ip netns exec $ns sysctl -q -w net.ipv6.conf.all.forwarding=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -q -w net.ipv6.conf.all.forwarding=1 In vrf_route_leaking.sh line 226: ip -netns $h1 link add eth0 type veth peer name r1h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link add eth0 type veth peer name r1h1 In vrf_route_leaking.sh line 227: ip -netns $h1 link set r1h1 netns $r1 name eth0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link set r1h1 netns "$r1" name eth0 up In vrf_route_leaking.sh line 229: ip -netns $h2 link add eth0 type veth peer name r1h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link add eth0 type veth peer name r1h2 In vrf_route_leaking.sh line 230: ip -netns $h2 link set r1h2 netns $r1 name eth1 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link set r1h2 netns "$r1" name eth1 up In vrf_route_leaking.sh line 235: ip -netns $h1 addr add dev eth0 ${H1_N1_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" addr add dev eth0 ${H1_N1_IP}/24 In vrf_route_leaking.sh line 236: ip -netns $h1 -6 addr add dev eth0 ${H1_N1_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" -6 addr add dev eth0 ${H1_N1_IP6}/64 nodad In vrf_route_leaking.sh line 237: ip -netns $h1 link set eth0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link set eth0 up In vrf_route_leaking.sh line 240: ip -netns $h1 route add ${H2_N2} via ${R1_N1_IP} dev eth0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" route add ${H2_N2} via ${R1_N1_IP} dev eth0 In vrf_route_leaking.sh line 241: ip -netns $h1 -6 route add ${H2_N2_6} via "${R1_N1_IP6}" dev eth0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" -6 route add ${H2_N2_6} via "${R1_N1_IP6}" dev eth0 In vrf_route_leaking.sh line 246: ip -netns $h2 addr add dev eth0 ${H2_N2_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" addr add dev eth0 ${H2_N2_IP}/24 In vrf_route_leaking.sh line 247: ip -netns $h2 -6 addr add dev eth0 ${H2_N2_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" -6 addr add dev eth0 ${H2_N2_IP6}/64 nodad In vrf_route_leaking.sh line 248: ip -netns $h2 link set eth0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link set eth0 up In vrf_route_leaking.sh line 251: ip -netns $h2 route add default via ${R1_N2_IP} dev eth0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" route add default via ${R1_N2_IP} dev eth0 In vrf_route_leaking.sh line 252: ip -netns $h2 -6 route add default via ${R1_N2_IP6} dev eth0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" -6 route add default via ${R1_N2_IP6} dev eth0 In vrf_route_leaking.sh line 257: setup_vrf $r1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vrf "$r1" In vrf_route_leaking.sh line 258: create_vrf $r1 blue 1101 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: create_vrf "$r1" blue 1101 In vrf_route_leaking.sh line 259: create_vrf $r1 red 1102 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: create_vrf "$r1" red 1102 In vrf_route_leaking.sh line 260: ip -netns $r1 link set mtu 1400 dev eth1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" link set mtu 1400 dev eth1 In vrf_route_leaking.sh line 261: ip -netns $r1 link set eth0 vrf blue up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" link set eth0 vrf blue up In vrf_route_leaking.sh line 262: ip -netns $r1 link set eth1 vrf red up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" link set eth1 vrf red up In vrf_route_leaking.sh line 263: ip -netns $r1 addr add dev eth0 ${R1_N1_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" addr add dev eth0 ${R1_N1_IP}/24 In vrf_route_leaking.sh line 264: ip -netns $r1 -6 addr add dev eth0 ${R1_N1_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" -6 addr add dev eth0 ${R1_N1_IP6}/64 nodad In vrf_route_leaking.sh line 265: ip -netns $r1 addr add dev eth1 ${R1_N2_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" addr add dev eth1 ${R1_N2_IP}/24 In vrf_route_leaking.sh line 266: ip -netns $r1 -6 addr add dev eth1 ${R1_N2_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" -6 addr add dev eth1 ${R1_N2_IP6}/64 nodad In vrf_route_leaking.sh line 269: ip -netns $r1 route add vrf blue ${H2_N2} dev red ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" route add vrf blue ${H2_N2} dev red In vrf_route_leaking.sh line 270: ip -netns $r1 -6 route add vrf blue ${H2_N2_6} dev red ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" -6 route add vrf blue ${H2_N2_6} dev red In vrf_route_leaking.sh line 273: ip -netns $r1 route add vrf red ${H1_N1} dev blue ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" route add vrf red ${H1_N1} dev blue In vrf_route_leaking.sh line 274: ip -netns $r1 -6 route add vrf red ${H1_N1_6} dev blue ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" -6 route add vrf red ${H1_N1_6} dev blue In vrf_route_leaking.sh line 278: slowwait 5 ip netns exec $h1 "${ping6}" -c1 -w1 ${H2_N2_IP6} >/dev/null 2>&1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: slowwait 5 ip netns exec "$h1" "${ping6}" -c1 -w1 ${H2_N2_IP6} >/dev/null 2>&1 In vrf_route_leaking.sh line 292: if echo $ns | grep -q h[12]-; then ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2062 (warning): Quote the grep pattern so the shell won't interpret it. Did you mean: if echo "$ns" | grep -q h[12]-; then In vrf_route_leaking.sh line 293: ip netns exec $ns sysctl -q -w net.ipv6.conf.all.forwarding=0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -q -w net.ipv6.conf.all.forwarding=0 In vrf_route_leaking.sh line 294: ip netns exec $ns sysctl -q -w net.ipv6.conf.all.keep_addr_on_down=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -q -w net.ipv6.conf.all.keep_addr_on_down=1 In vrf_route_leaking.sh line 296: ip netns exec $ns sysctl -q -w net.ipv4.ip_forward=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -q -w net.ipv4.ip_forward=1 In vrf_route_leaking.sh line 297: ip netns exec $ns sysctl -q -w net.ipv6.conf.all.forwarding=1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$ns" sysctl -q -w net.ipv6.conf.all.forwarding=1 In vrf_route_leaking.sh line 304: ip -netns $h1 link add eth0 type veth peer name r1h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link add eth0 type veth peer name r1h1 In vrf_route_leaking.sh line 305: ip -netns $h1 link set r1h1 netns $r1 name eth0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link set r1h1 netns "$r1" name eth0 up In vrf_route_leaking.sh line 307: ip -netns $h1 link add eth1 type veth peer name r2h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link add eth1 type veth peer name r2h1 In vrf_route_leaking.sh line 308: ip -netns $h1 link set r2h1 netns $r2 name eth0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link set r2h1 netns "$r2" name eth0 up In vrf_route_leaking.sh line 310: ip -netns $h2 link add eth0 type veth peer name r1h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link add eth0 type veth peer name r1h2 In vrf_route_leaking.sh line 311: ip -netns $h2 link set r1h2 netns $r1 name eth1 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link set r1h2 netns "$r1" name eth1 up In vrf_route_leaking.sh line 313: ip -netns $h2 link add eth1 type veth peer name r2h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link add eth1 type veth peer name r2h2 In vrf_route_leaking.sh line 314: ip -netns $h2 link set r2h2 netns $r2 name eth1 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link set r2h2 netns "$r2" name eth1 up In vrf_route_leaking.sh line 319: ip -netns $h1 link add br0 type bridge ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link add br0 type bridge In vrf_route_leaking.sh line 320: ip -netns $h1 link set br0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link set br0 up In vrf_route_leaking.sh line 321: ip -netns $h1 addr add dev br0 ${H1_N1_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" addr add dev br0 ${H1_N1_IP}/24 In vrf_route_leaking.sh line 322: ip -netns $h1 -6 addr add dev br0 ${H1_N1_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" -6 addr add dev br0 ${H1_N1_IP6}/64 nodad In vrf_route_leaking.sh line 323: ip -netns $h1 link set eth0 master br0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link set eth0 master br0 up In vrf_route_leaking.sh line 324: ip -netns $h1 link set eth1 master br0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" link set eth1 master br0 up In vrf_route_leaking.sh line 327: ip -netns $h1 route add ${H2_N2} via ${R1_N1_IP} dev br0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" route add ${H2_N2} via ${R1_N1_IP} dev br0 In vrf_route_leaking.sh line 328: ip -netns $h1 -6 route add ${H2_N2_6} via "${R1_N1_IP6}" dev br0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h1" -6 route add ${H2_N2_6} via "${R1_N1_IP6}" dev br0 In vrf_route_leaking.sh line 333: ip -netns $h2 link add br0 type bridge ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link add br0 type bridge In vrf_route_leaking.sh line 334: ip -netns $h2 link set br0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link set br0 up In vrf_route_leaking.sh line 335: ip -netns $h2 addr add dev br0 ${H2_N2_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" addr add dev br0 ${H2_N2_IP}/24 In vrf_route_leaking.sh line 336: ip -netns $h2 -6 addr add dev br0 ${H2_N2_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" -6 addr add dev br0 ${H2_N2_IP6}/64 nodad In vrf_route_leaking.sh line 337: ip -netns $h2 link set eth0 master br0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link set eth0 master br0 up In vrf_route_leaking.sh line 338: ip -netns $h2 link set eth1 master br0 up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" link set eth1 master br0 up In vrf_route_leaking.sh line 341: ip -netns $h2 route add default via ${R2_N2_IP} dev br0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" route add default via ${R2_N2_IP} dev br0 In vrf_route_leaking.sh line 342: ip -netns $h2 -6 route add default via ${R2_N2_IP6} dev br0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$h2" -6 route add default via ${R2_N2_IP6} dev br0 In vrf_route_leaking.sh line 347: setup_vrf $r1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_vrf "$r1" In vrf_route_leaking.sh line 348: create_vrf $r1 blue 1101 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: create_vrf "$r1" blue 1101 In vrf_route_leaking.sh line 349: create_vrf $r1 red 1102 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: create_vrf "$r1" red 1102 In vrf_route_leaking.sh line 350: ip -netns $r1 link set mtu 1400 dev eth1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" link set mtu 1400 dev eth1 In vrf_route_leaking.sh line 351: ip -netns $r1 link set eth0 vrf blue up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" link set eth0 vrf blue up In vrf_route_leaking.sh line 352: ip -netns $r1 link set eth1 vrf red up ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" link set eth1 vrf red up In vrf_route_leaking.sh line 353: ip -netns $r1 addr add dev eth0 ${R1_N1_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" addr add dev eth0 ${R1_N1_IP}/24 In vrf_route_leaking.sh line 354: ip -netns $r1 -6 addr add dev eth0 ${R1_N1_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" -6 addr add dev eth0 ${R1_N1_IP6}/64 nodad In vrf_route_leaking.sh line 355: ip -netns $r1 addr add dev eth1 ${R1_N2_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" addr add dev eth1 ${R1_N2_IP}/24 In vrf_route_leaking.sh line 356: ip -netns $r1 -6 addr add dev eth1 ${R1_N2_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" -6 addr add dev eth1 ${R1_N2_IP6}/64 nodad In vrf_route_leaking.sh line 359: ip -netns $r1 route add vrf blue ${H2_N2} dev red ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" route add vrf blue ${H2_N2} dev red In vrf_route_leaking.sh line 360: ip -netns $r1 -6 route add vrf blue ${H2_N2_6} dev red ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r1" -6 route add vrf blue ${H2_N2_6} dev red In vrf_route_leaking.sh line 367: ip -netns $r2 addr add dev eth0 ${R2_N1_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r2" addr add dev eth0 ${R2_N1_IP}/24 In vrf_route_leaking.sh line 368: ip -netns $r2 -6 addr add dev eth0 ${R2_N1_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r2" -6 addr add dev eth0 ${R2_N1_IP6}/64 nodad In vrf_route_leaking.sh line 369: ip -netns $r2 addr add dev eth1 ${R2_N2_IP}/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r2" addr add dev eth1 ${R2_N2_IP}/24 In vrf_route_leaking.sh line 370: ip -netns $r2 -6 addr add dev eth1 ${R2_N2_IP6}/64 nodad ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "$r2" -6 addr add dev eth1 ${R2_N2_IP6}/64 nodad In vrf_route_leaking.sh line 373: slowwait 5 ip netns exec $h1 "${ping6}" -c1 -w1 ${H2_N2_IP6} >/dev/null 2>&1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: slowwait 5 ip netns exec "$h1" "${ping6}" -c1 -w1 ${H2_N2_IP6} >/dev/null 2>&1 In vrf_route_leaking.sh line 378: ip netns exec $h1 ping -c1 -w1 ${H2_N2_IP} >/dev/null 2>&1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$h1" ping -c1 -w1 ${H2_N2_IP} >/dev/null 2>&1 In vrf_route_leaking.sh line 385: ip netns exec $h1 "${ping6}" -c1 -w1 ${H2_N2_IP6} >/dev/null 2>&1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$h1" "${ping6}" -c1 -w1 ${H2_N2_IP6} >/dev/null 2>&1 In vrf_route_leaking.sh line 410: [ "x$ttype" = "x" ] && ttype="$DEFAULT_TTYPE" ^-------^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose. Did you mean: [ "$ttype" = "" ] && ttype="$DEFAULT_TTYPE" In vrf_route_leaking.sh line 420: run_cmd_grep "${R1_N1_IP}" ip netns exec $h1 traceroute ${H2_N2_IP} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "${R1_N1_IP}" ip netns exec "$h1" traceroute ${H2_N2_IP} In vrf_route_leaking.sh line 433: [ "x$ttype" = "x" ] && ttype="$DEFAULT_TTYPE" ^-------^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose. Did you mean: [ "$ttype" = "" ] && ttype="$DEFAULT_TTYPE" In vrf_route_leaking.sh line 443: run_cmd_grep "${R1_N1_IP6}" ip netns exec $h1 traceroute6 ${H2_N2_IP6} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "${R1_N1_IP6}" ip netns exec "$h1" traceroute6 ${H2_N2_IP6} In vrf_route_leaking.sh line 456: [ "x$ttype" = "x" ] && ttype="$DEFAULT_TTYPE" ^-------^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose. Did you mean: [ "$ttype" = "" ] && ttype="$DEFAULT_TTYPE" In vrf_route_leaking.sh line 464: run_cmd_grep "Time to live exceeded" ip netns exec $h1 ping -t1 -c1 -W2 ${H2_N2_IP} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "Time to live exceeded" ip netns exec "$h1" ping -t1 -c1 -W2 ${H2_N2_IP} In vrf_route_leaking.sh line 477: [ "x$ttype" = "x" ] && ttype="$DEFAULT_TTYPE" ^-------^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose. Did you mean: [ "$ttype" = "" ] && ttype="$DEFAULT_TTYPE" In vrf_route_leaking.sh line 485: run_cmd_grep "Frag needed" ip netns exec $h1 ping -s 1450 -Mdo -c1 -W2 ${H2_N2_IP} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "Frag needed" ip netns exec "$h1" ping -s 1450 -Mdo -c1 -W2 ${H2_N2_IP} In vrf_route_leaking.sh line 498: [ "x$ttype" = "x" ] && ttype="$DEFAULT_TTYPE" ^-------^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose. Did you mean: [ "$ttype" = "" ] && ttype="$DEFAULT_TTYPE" In vrf_route_leaking.sh line 506: run_cmd_grep "Time exceeded: Hop limit" ip netns exec $h1 "${ping6}" -t1 -c1 -W2 ${H2_N2_IP6} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "Time exceeded: Hop limit" ip netns exec "$h1" "${ping6}" -t1 -c1 -W2 ${H2_N2_IP6} In vrf_route_leaking.sh line 519: [ "x$ttype" = "x" ] && ttype="$DEFAULT_TTYPE" ^-------^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose. Did you mean: [ "$ttype" = "" ] && ttype="$DEFAULT_TTYPE" In vrf_route_leaking.sh line 527: run_cmd_grep "Packet too big" ip netns exec $h1 "${ping6}" -s 1450 -Mdo -c1 -W2 ${H2_N2_IP6} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "Packet too big" ip netns exec "$h1" "${ping6}" -s 1450 -Mdo -c1 -W2 ${H2_N2_IP6} In vrf_route_leaking.sh line 544: run_cmd ip netns exec $r1 ip vrf exec blue ping -c1 -w1 ${H2_N2_IP} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$r1" ip vrf exec blue ping -c1 -w1 ${H2_N2_IP} In vrf_route_leaking.sh line 584: run_cmd ip netns exec $r1 ip vrf exec blue ${ping6} -c1 -w1 ${H2_N2_IP6} ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$r1" ip vrf exec blue "${ping6}" -c1 -w1 ${H2_N2_IP6} For more information: https://www.shellcheck.net/wiki/SC2062 -- Quote the grep pattern so the she... https://www.shellcheck.net/wiki/SC2154 -- h1 is referenced but not assigned. https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...