========== checkpatch - FAILED ERROR: code indent should use tabs where possible #56: FILE: drivers/net/dsa/mv88e6xxx/chip.h:183: + * register CONFIG Data2.$ ERROR: code indent should use tabs where possible #57: FILE: drivers/net/dsa/mv88e6xxx/chip.h:184: + * If this is set to 0x0, it will use the default mask of$ ERROR: code indent should use tabs where possible #58: FILE: drivers/net/dsa/mv88e6xxx/chip.h:185: + * MV88E6352_G2_SCRATCH_CONFIG_DATA2_P0_MODE_MASK$ ERROR: code indent should use tabs where possible #59: FILE: drivers/net/dsa/mv88e6xxx/chip.h:186: + */$ ERROR: space prohibited after that open parenthesis '(' #82: FILE: drivers/net/dsa/mv88e6xxx/global2_scratch.c:268: + if( p0_mode_mask == 0x0) { ERROR: space required before the open parenthesis '(' #82: FILE: drivers/net/dsa/mv88e6xxx/global2_scratch.c:268: + if( p0_mode_mask == 0x0) { WARNING: braces {} are not necessary for single statement blocks #82: FILE: drivers/net/dsa/mv88e6xxx/global2_scratch.c:268: + if( p0_mode_mask == 0x0) { + p0_mode_mask = MV88E6352_G2_SCRATCH_CONFIG_DATA2_P0_MODE_MASK; + } total: 6 errors, 1 warnings, 0 checks, 39 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit 47a5f1af71b3 ("net: dsa: mv88e6xxx: fix external smi for mv88e6176") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.