ShellCheck - shell script analysis tool version: 0.10.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.zYvbHbeEGH and /tmp/tmp.19MNd1feMK Tree base: ce815247d821 ("net: remove redundant ASSERT_RTNL() in queue setup functions") Now at: 677b2bbc70a4 ("netdevsim: remove udp_ports_sleep") ====== Checking before the patch ====== Checking tools/testing/selftests/drivers/net/netdevsim/udp_tunnel_nic.sh - 1b4ef4bc240effb6c34becfc377e88d9b95971304a6258dbbb468720bbf6b196 ====== Checking the tree with the patch ====== Checking tools/testing/selftests/drivers/net/netdevsim/udp_tunnel_nic.sh - 1b4ef4bc240effb6c34becfc377e88d9b95971304a6258dbbb468720bbf6b196 In udp_tunnel_nic.sh line 18: echo "ERROR:" $@ ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements. In udp_tunnel_nic.sh line 30: [ -e /sys/class/net/$dev ] && ip link del dev $dev ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ -e /sys/class/net/"$dev" ] && ip link del dev "$dev" In udp_tunnel_nic.sh line 62: ip $ipfl link add $dev type vxlan \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip $ipfl link add "$dev" type vxlan \ In udp_tunnel_nic.sh line 64: dev $lower \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev "$lower" \ In udp_tunnel_nic.sh line 65: dstport $dstport \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dstport "$dstport" \ In udp_tunnel_nic.sh line 66: $flags ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$flags" In udp_tunnel_nic.sh line 68: ip link set dev $dev up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev" up In udp_tunnel_nic.sh line 70: clean_up_devs=("${clean_up_devs[@]}" $dev) ^--^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In udp_tunnel_nic.sh line 88: ip $ipfl link add $dev type geneve \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip $ipfl link add "$dev" type geneve \ In udp_tunnel_nic.sh line 89: remote $remote \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: remote "$remote" \ In udp_tunnel_nic.sh line 90: dstport $dstport \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dstport "$dstport" \ In udp_tunnel_nic.sh line 91: $flags ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$flags" In udp_tunnel_nic.sh line 93: ip link set dev $dev up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev" up In udp_tunnel_nic.sh line 95: clean_up_devs=("${clean_up_devs[@]}" $dev) ^--^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In udp_tunnel_nic.sh line 103: ip link del dev $dev ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link del dev "$dev" In udp_tunnel_nic.sh line 149: read -a have < $path ^--^ SC2162 (info): read without -r will mangle backslashes. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: read -a have < "$path" In udp_tunnel_nic.sh line 157: if [ -n "$HAS_ETHTOOL" -a ${expected[i]} -ne 0 ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ -n "$HAS_ETHTOOL" -a "${expected[i]}" -ne 0 ]; then In udp_tunnel_nic.sh line 158: pp_expected=`pre_ethtool ${expected[i]}` ^--------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pp_expected=$(pre_ethtool "${expected[i]}") In udp_tunnel_nic.sh line 159: ethtool --show-tunnels $NSIM_NETDEV | grep "$pp_expected" >/dev/null ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool --show-tunnels "$NSIM_NETDEV" | grep "$pp_expected" >/dev/null In udp_tunnel_nic.sh line 160: if [ $? -ne 0 -a $last -ne 0 ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ $? -ne 0 -a "$last" -ne 0 ]; then In udp_tunnel_nic.sh line 163: ethtool --show-tunnels $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool --show-tunnels "$NSIM_NETDEV" In udp_tunnel_nic.sh line 169: if [ ${expected[i]} != ${have[i]} ]; then ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${expected[i]}" != "${have[i]}" ]; then In udp_tunnel_nic.sh line 170: if [ $last -ne 0 ]; then ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$last" -ne 0 ]; then In udp_tunnel_nic.sh line 173: echo " expected: `pre ${expected[i]}`" ^------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " expected: $(pre "${expected[i]}")" In udp_tunnel_nic.sh line 174: echo " have: `pre ${have[i]}`" ^--------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " have: $(pre "${have[i]}")" In udp_tunnel_nic.sh line 198: if [ -n "$HAS_ETHTOOL" -a -n "${STATIC_ENTRIES[0]}" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In udp_tunnel_nic.sh line 201: pp_expected=`pre_ethtool ${STATIC_ENTRIES[i]}` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pp_expected=$(pre_ethtool "${STATIC_ENTRIES[i]}") In udp_tunnel_nic.sh line 202: cnt=$(ethtool --show-tunnels $NSIM_NETDEV | grep -c "$pp_expected") ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cnt=$(ethtool --show-tunnels "$NSIM_NETDEV" | grep -c "$pp_expected") In udp_tunnel_nic.sh line 203: if [ $cnt -ne 1 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$cnt" -ne 1 ]; then In udp_tunnel_nic.sh line 206: ethtool --show-tunnels $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool --show-tunnels "$NSIM_NETDEV" In udp_tunnel_nic.sh line 216: read -a have < $path ^--^ SC2162 (info): read without -r will mangle backslashes. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: read -a have < "$path" In udp_tunnel_nic.sh line 218: tree $NSIM_DEV_DFS/ ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tree "$NSIM_DEV_DFS"/ In udp_tunnel_nic.sh line 223: echo " `pre ${have[i]}`" ^--------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " $(pre "${have[i]}")" In udp_tunnel_nic.sh line 241: [ $netdev == $check ] && break ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$netdev" == "$check" ] && break In udp_tunnel_nic.sh line 244: if [ $netdev != $check ]; then ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$netdev" != "$check" ]; then In udp_tunnel_nic.sh line 245: echo $netdev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$netdev" In udp_tunnel_nic.sh line 256: ethtool -h | grep show-tunnels 2>&1 >/dev/null && HAS_ETHTOOL=y ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). In udp_tunnel_nic.sh line 271: NSIM_NETDEV=`get_netdev_name old_netdevs` ^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: NSIM_NETDEV=$(get_netdev_name old_netdevs) In udp_tunnel_nic.sh line 272: ip link set dev $NSIM_NETDEV up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$NSIM_NETDEV" up In udp_tunnel_nic.sh line 280: exp0=( `mke 4789 1` 0 0 0 ) ^----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 4789 1) 0 0 0 ) In udp_tunnel_nic.sh line 281: new_vxlan vxlan0 4789 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan0 4789 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 282: new_vxlan vxlan1 4789 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan1 4789 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 291: exp0=( `mke 4789 1` 0 0 0 ) ^----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 4789 1) 0 0 0 ) In udp_tunnel_nic.sh line 292: new_vxlan vxlanA 4789 $NSIM_NETDEV 6 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlanA 4789 "$NSIM_NETDEV" 6 In udp_tunnel_nic.sh line 298: new_vxlan vxlanB 4789 $NSIM_NETDEV 6 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlanB 4789 "$NSIM_NETDEV" 6 In udp_tunnel_nic.sh line 301: exp0=( `mke 4789 1` `mke 4790 1` 0 0 ) ^----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 4789 1) $(mke 4790 1) 0 0 ) In udp_tunnel_nic.sh line 302: new_vxlan vxlanC 4790 $NSIM_NETDEV 6 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlanC 4790 "$NSIM_NETDEV" 6 In udp_tunnel_nic.sh line 305: exp1=( `mke 6081 2` 0 0 0 ) ^----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 6081 2) 0 0 0 ) In udp_tunnel_nic.sh line 309: ip link set dev $NSIM_NETDEV down ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$NSIM_NETDEV" down In udp_tunnel_nic.sh line 316: ip link set dev $NSIM_NETDEV up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$NSIM_NETDEV" up In udp_tunnel_nic.sh line 317: exp0=( `mke 4789 1` `mke 4790 1` 0 0 ) ^----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 4789 1) $(mke 4790 1) 0 0 ) In udp_tunnel_nic.sh line 318: exp1=( `mke 6081 2` 0 0 0 ) ^----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 6081 2) 0 0 0 ) In udp_tunnel_nic.sh line 353: NSIM_NETDEV=`get_netdev_name old_netdevs` ^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: NSIM_NETDEV=$(get_netdev_name old_netdevs) In udp_tunnel_nic.sh line 356: exp0=( `mke 10000 1` 0 0 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) 0 0 0 ) In udp_tunnel_nic.sh line 357: new_vxlan vxlan0 10000 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan0 10000 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 370: exp0=( `mke 10000 1` 0 0 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) 0 0 0 ) In udp_tunnel_nic.sh line 371: new_vxlan vxlan0 10000 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan0 10000 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 374: exp0=( `mke 10000 1` `mke 10001 1` 0 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) $(mke 10001 1) 0 0 ) In udp_tunnel_nic.sh line 375: new_vxlan vxlan1 10001 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan1 10001 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 378: exp0=( `mke 10000 1` `mke 10001 1` `mke 10002 1` 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) $(mke 10001 1) $(mke 10002 1) 0 ) In udp_tunnel_nic.sh line 379: new_vxlan vxlan2 10002 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan2 10002 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 382: exp0=( `mke 10000 1` `mke 10001 1` `mke 10002 1` `mke 10003 1` ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) $(mke 10001 1) $(mke 10002 1) $(mke 10003 1) ) In udp_tunnel_nic.sh line 383: new_vxlan vxlan3 10003 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan3 10003 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 386: new_vxlan vxlan4 10004 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan4 10004 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 393: exp1=( `mke 20000 2` 0 0 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 20000 2) 0 0 0 ) In udp_tunnel_nic.sh line 397: exp1=( `mke 20000 2` `mke 20001 2` 0 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 20000 2) $(mke 20001 2) 0 0 ) In udp_tunnel_nic.sh line 401: exp1=( `mke 20000 2` `mke 20001 2` `mke 20002 2` 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 20000 2) $(mke 20001 2) $(mke 20002 2) 0 ) In udp_tunnel_nic.sh line 405: exp1=( `mke 20000 2` `mke 20001 2` `mke 20002 2` `mke 20003 2` ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 20000 2) $(mke 20001 2) $(mke 20002 2) $(mke 20003 2) ) In udp_tunnel_nic.sh line 421: NSIM_NETDEV=`get_netdev_name old_netdevs` ^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: NSIM_NETDEV=$(get_netdev_name old_netdevs) In udp_tunnel_nic.sh line 422: ip link set dev $NSIM_NETDEV up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$NSIM_NETDEV" up In udp_tunnel_nic.sh line 428: exp0=( `mke 10000 1` `mke 10004 1` `mke 10002 1` `mke 10003 1` ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) $(mke 10004 1) $(mke 10002 1) $(mke 10003 1) ) In udp_tunnel_nic.sh line 432: exp0=( `mke 10000 1` `mke 10004 1` 0 `mke 10003 1` ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) $(mke 10004 1) 0 $(mke 10003 1) ) In udp_tunnel_nic.sh line 436: exp1=( `mke 20000 2` `mke 20004 2` `mke 20002 2` `mke 20003 2` ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 20000 2) $(mke 20004 2) $(mke 20002 2) $(mke 20003 2) ) In udp_tunnel_nic.sh line 440: exp1=( `mke 20000 2` `mke 20004 2` 0 `mke 20003 2` ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 20000 2) $(mke 20004 2) 0 $(mke 20003 2) ) In udp_tunnel_nic.sh line 444: exp1=( `mke 20000 2` `mke 20004 2` `mke 30001 4` `mke 20003 2` ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 20000 2) $(mke 20004 2) $(mke 30001 4) $(mke 20003 2) ) In udp_tunnel_nic.sh line 445: new_vxlan vxlanG0 30001 $NSIM_NETDEV 4 "gpe external" ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlanG0 30001 "$NSIM_NETDEV" 4 "gpe external" In udp_tunnel_nic.sh line 448: new_vxlan vxlanG1 30002 $NSIM_NETDEV 4 "gpe external" ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlanG1 30002 "$NSIM_NETDEV" 4 "gpe external" In udp_tunnel_nic.sh line 450: new_vxlan vxlanG2 30002 $NSIM_NETDEV 6 "gpe external" ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlanG2 30002 "$NSIM_NETDEV" 6 "gpe external" In udp_tunnel_nic.sh line 452: exp1=( `mke 20000 2` `mke 30002 4` `mke 30001 4` `mke 20003 2` ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 20000 2) $(mke 30002 4) $(mke 30001 4) $(mke 20003 2) ) In udp_tunnel_nic.sh line 478: NSIM_NETDEV=`get_netdev_name old_netdevs` ^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: NSIM_NETDEV=$(get_netdev_name old_netdevs) In udp_tunnel_nic.sh line 479: ip link set dev $NSIM_NETDEV up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$NSIM_NETDEV" up In udp_tunnel_nic.sh line 485: exp0=( `mke 10000 1` `mke 10004 1` `mke 10002 1` `mke 10003 1` ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) $(mke 10004 1) $(mke 10002 1) $(mke 10003 1) ) In udp_tunnel_nic.sh line 489: exp0=( `mke 10000 1` `mke 10004 1` 0 `mke 10003 1` ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) $(mke 10004 1) 0 $(mke 10003 1) ) In udp_tunnel_nic.sh line 493: exp1=( `mke 20000 2` `mke 20004 2` `mke 20002 2` `mke 20003 2` ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 20000 2) $(mke 20004 2) $(mke 20002 2) $(mke 20003 2) ) In udp_tunnel_nic.sh line 497: exp1=( `mke 20000 2` `mke 20004 2` 0 `mke 20003 2` ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 20000 2) $(mke 20004 2) 0 $(mke 20003 2) ) In udp_tunnel_nic.sh line 501: exp1=( `mke 20000 2` `mke 20004 2` `mke 30001 4` `mke 20003 2` ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 20000 2) $(mke 20004 2) $(mke 30001 4) $(mke 20003 2) ) In udp_tunnel_nic.sh line 502: new_vxlan vxlanG0 30001 $NSIM_NETDEV 4 "gpe external" ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlanG0 30001 "$NSIM_NETDEV" 4 "gpe external" In udp_tunnel_nic.sh line 505: new_vxlan vxlanG1 30002 $NSIM_NETDEV 4 "gpe external" ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlanG1 30002 "$NSIM_NETDEV" 4 "gpe external" In udp_tunnel_nic.sh line 507: new_vxlan vxlanG2 30002 $NSIM_NETDEV 6 "gpe external" ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlanG2 30002 "$NSIM_NETDEV" 6 "gpe external" In udp_tunnel_nic.sh line 509: exp1=( `mke 20000 2` `mke 30002 4` `mke 30001 4` `mke 20003 2` ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 20000 2) $(mke 30002 4) $(mke 30001 4) $(mke 20003 2) ) In udp_tunnel_nic.sh line 534: NSIM_NETDEV=`get_netdev_name old_netdevs` ^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: NSIM_NETDEV=$(get_netdev_name old_netdevs) In udp_tunnel_nic.sh line 535: ip link set dev $NSIM_NETDEV up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$NSIM_NETDEV" up In udp_tunnel_nic.sh line 563: NSIM_NETDEV=`get_netdev_name old_netdevs` ^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: NSIM_NETDEV=$(get_netdev_name old_netdevs) In udp_tunnel_nic.sh line 564: ip link set dev $NSIM_NETDEV up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$NSIM_NETDEV" up In udp_tunnel_nic.sh line 567: new_vxlan vxlanA0 10000 $NSIM_NETDEV 6 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlanA0 10000 "$NSIM_NETDEV" 6 In udp_tunnel_nic.sh line 570: new_vxlan vxlanA1 10000 $NSIM_NETDEV 6 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlanA1 10000 "$NSIM_NETDEV" 6 In udp_tunnel_nic.sh line 577: exp0=( `mke 10000 1` 0 0 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) 0 0 0 ) In udp_tunnel_nic.sh line 578: new_vxlan vxlan0 10000 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan0 10000 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 586: exp0=( `mke 10000 1` 0 0 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) 0 0 0 ) In udp_tunnel_nic.sh line 595: exp0=( `mke 10000 1` 0 0 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) 0 0 0 ) In udp_tunnel_nic.sh line 596: new_vxlan vxlan0 10000 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan0 10000 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 623: NSIM_NETDEV=`get_netdev_name old_netdevs` ^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: NSIM_NETDEV=$(get_netdev_name old_netdevs) In udp_tunnel_nic.sh line 624: ip link set dev $NSIM_NETDEV up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$NSIM_NETDEV" up In udp_tunnel_nic.sh line 630: new_vxlan vxlanA0 10000 $NSIM_NETDEV 6 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlanA0 10000 "$NSIM_NETDEV" 6 In udp_tunnel_nic.sh line 633: exp0=( `mke 10000 1` 0 0 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) 0 0 0 ) In udp_tunnel_nic.sh line 634: new_vxlan vxlan0 10000 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan0 10000 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 644: exp1=( `mke 20000 2` 0 0 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 20000 2) 0 0 0 ) In udp_tunnel_nic.sh line 649: exp1=( `mke 20000 2` 0 0 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 20000 2) 0 0 0 ) In udp_tunnel_nic.sh line 653: exp1=( 0 `mke 20001 2` 0 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( 0 $(mke 20001 2) 0 0 ) In udp_tunnel_nic.sh line 678: NSIM_NETDEV=`get_netdev_name old_netdevs` ^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: NSIM_NETDEV=$(get_netdev_name old_netdevs) In udp_tunnel_nic.sh line 679: ip link set dev $NSIM_NETDEV up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$NSIM_NETDEV" up In udp_tunnel_nic.sh line 682: exp0=( `mke 10000 1` 0 0 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) 0 0 0 ) In udp_tunnel_nic.sh line 683: new_vxlan vxlanA0 10000 $NSIM_NETDEV 6 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlanA0 10000 "$NSIM_NETDEV" 6 In udp_tunnel_nic.sh line 686: new_vxlan vxlan0 10000 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan0 10000 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 690: ethtool -K $NSIM_NETDEV rx-udp_tunnel-port-offload off ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool -K "$NSIM_NETDEV" rx-udp_tunnel-port-offload off In udp_tunnel_nic.sh line 694: exp0=( `mke 10000 1` 0 0 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) 0 0 0 ) In udp_tunnel_nic.sh line 695: ethtool -K $NSIM_NETDEV rx-udp_tunnel-port-offload on ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool -K "$NSIM_NETDEV" rx-udp_tunnel-port-offload on In udp_tunnel_nic.sh line 704: ethtool -K $NSIM_NETDEV rx-udp_tunnel-port-offload off ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool -K "$NSIM_NETDEV" rx-udp_tunnel-port-offload off In udp_tunnel_nic.sh line 708: new_vxlan vxlan0 10000 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan0 10000 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 711: exp0=( `mke 10000 1` 0 0 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) 0 0 0 ) In udp_tunnel_nic.sh line 712: ethtool -K $NSIM_NETDEV rx-udp_tunnel-port-offload on ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool -K "$NSIM_NETDEV" rx-udp_tunnel-port-offload on In udp_tunnel_nic.sh line 737: NSIM_NETDEV=`get_netdev_name old_netdevs` ^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: NSIM_NETDEV=$(get_netdev_name old_netdevs) In udp_tunnel_nic.sh line 738: ip link set dev $NSIM_NETDEV up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$NSIM_NETDEV" up In udp_tunnel_nic.sh line 741: exp0=( `mke 10000 1` 0 0 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) 0 0 0 ) In udp_tunnel_nic.sh line 742: new_vxlan vxlanA0 10000 $NSIM_NETDEV 6 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlanA0 10000 "$NSIM_NETDEV" 6 In udp_tunnel_nic.sh line 745: new_vxlan vxlan0 10000 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan0 10000 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 751: ip link set dev $NSIM_NETDEV down ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$NSIM_NETDEV" down In udp_tunnel_nic.sh line 762: ip link set dev $NSIM_NETDEV up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$NSIM_NETDEV" up In udp_tunnel_nic.sh line 763: exp0=( `mke 10000 1` 0 0 0 ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) 0 0 0 ) In udp_tunnel_nic.sh line 796: NSIM_NETDEV=`get_netdev_name old_netdevs` ^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: NSIM_NETDEV=$(get_netdev_name old_netdevs) In udp_tunnel_nic.sh line 799: NSIM_NETDEV2=`get_netdev_name old_netdevs` ^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: NSIM_NETDEV2=$(get_netdev_name old_netdevs) In udp_tunnel_nic.sh line 802: exp0=( `mke 4789 1` 0 0 0 ) ^----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 4789 1) 0 0 0 ) In udp_tunnel_nic.sh line 804: new_vxlan vxlan0 4789 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan0 4789 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 805: new_vxlan vxlan1 4789 $NSIM_NETDEV2 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan1 4789 "$NSIM_NETDEV2" In udp_tunnel_nic.sh line 818: exp0=( `mke 4789 1` `mke 4790 1` 0 0 ) ^----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 4789 1) $(mke 4790 1) 0 0 ) In udp_tunnel_nic.sh line 819: new_vxlan vxlanC 4790 $NSIM_NETDEV 6 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlanC 4790 "$NSIM_NETDEV" 6 In udp_tunnel_nic.sh line 822: exp1=( `mke 6081 2` 0 0 0 ) ^----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 6081 2) 0 0 0 ) In udp_tunnel_nic.sh line 826: ip link set dev $NSIM_NETDEV down ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$NSIM_NETDEV" down In udp_tunnel_nic.sh line 830: ip link set dev $NSIM_NETDEV up ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$NSIM_NETDEV" up In udp_tunnel_nic.sh line 833: for i in `seq 2`; do ^-----^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: for i in $(seq 2); do In udp_tunnel_nic.sh line 835: ethtool -K $NSIM_NETDEV rx-udp_tunnel-port-offload off ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool -K "$NSIM_NETDEV" rx-udp_tunnel-port-offload off In udp_tunnel_nic.sh line 841: ethtool -K $NSIM_NETDEV2 rx-udp_tunnel-port-offload off ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool -K "$NSIM_NETDEV2" rx-udp_tunnel-port-offload off In udp_tunnel_nic.sh line 845: exp0=( `mke 4789 1` `mke 4790 1` 0 0 ) ^----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 4789 1) $(mke 4790 1) 0 0 ) In udp_tunnel_nic.sh line 846: exp1=( `mke 6081 2` 0 0 0 ) ^----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp1=( $(mke 6081 2) 0 0 0 ) In udp_tunnel_nic.sh line 847: ethtool -K $NSIM_NETDEV rx-udp_tunnel-port-offload on ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool -K "$NSIM_NETDEV" rx-udp_tunnel-port-offload on In udp_tunnel_nic.sh line 851: ethtool -K $NSIM_NETDEV2 rx-udp_tunnel-port-offload on ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool -K "$NSIM_NETDEV2" rx-udp_tunnel-port-offload on In udp_tunnel_nic.sh line 867: NSIM_NETDEV=`get_netdev_name old_netdevs` ^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: NSIM_NETDEV=$(get_netdev_name old_netdevs) In udp_tunnel_nic.sh line 871: exp0=( `mke 10000 1` `mke 10004 1` `mke 10002 1` `mke 10003 1` ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) $(mke 10004 1) $(mke 10002 1) $(mke 10003 1) ) In udp_tunnel_nic.sh line 875: exp0=( `mke 10000 1` `mke 10004 1` 0 `mke 10003 1` ) ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^-----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 10000 1) $(mke 10004 1) 0 $(mke 10003 1) ) In udp_tunnel_nic.sh line 899: STATIC_ENTRIES=( `mke 4789 1` ) ^----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: STATIC_ENTRIES=( $(mke 4789 1) ) In udp_tunnel_nic.sh line 902: old_netdevs=$(ls /sys/class/net) ^---------^ SC2034 (warning): old_netdevs appears unused. Verify use (or export if used externally). In udp_tunnel_nic.sh line 904: NSIM_NETDEV=`get_netdev_name old_netdevs` ^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: NSIM_NETDEV=$(get_netdev_name old_netdevs) In udp_tunnel_nic.sh line 912: new_vxlan vxlan0 4789 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan0 4789 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 913: new_vxlan vxlan1 4789 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan1 4789 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 916: exp0=( `mke 4790 1` 0 0 0 ) ^----------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^----------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: exp0=( $(mke 4790 1) 0 0 0 ) In udp_tunnel_nic.sh line 917: new_vxlan vxlan2 4790 $NSIM_NETDEV ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: new_vxlan vxlan2 4790 "$NSIM_NETDEV" In udp_tunnel_nic.sh line 922: exp0=( 0 0 0 0 ) ^--^ SC2034 (warning): exp0 appears unused. Verify use (or export if used externally). In udp_tunnel_nic.sh line 923: exp1=( 0 0 0 0 ) ^--^ SC2034 (warning): exp1 appears unused. Verify use (or export if used externally). For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2034 -- exp0 appears unused. Verify use (... https://www.shellcheck.net/wiki/SC2069 -- To redirect stdout+stderr, 2>&1 m...