ShellCheck - shell script analysis tool version: 0.10.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.kqZdplbMkP and /tmp/tmp.1SHoQCwgXn Tree base: 540f77ab1630 ("sched: Add enqueue/dequeue of dualpi2 qdisc") Now at: e7b10a74076b ("selftests/tc-testing: Add selftests for qdisc DualPI2") ====== Checking before the patch ====== Checking tools/testing/selftests/tc-testing/tdc.sh - 602b16b107427091f2848fe8e3588d6a2c04584decb8ca60ec260ea130880a7f ====== Checking the tree with the patch ====== Checking tools/testing/selftests/tc-testing/tdc.sh - 602b16b107427091f2848fe8e3588d6a2c04584decb8ca60ec260ea130880a7f In tdc.sh line 8: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In tdc.sh line 71: ./tdc.py -J`nproc` ^-----^ SC2046 (warning): Quote this to prevent word splitting. ^-----^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: ./tdc.py -J$(nproc) For more information: https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of le... https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with e.g...