WARNING: Possible repeated word: 'are' #8: an watchdog, its registers are are passed onto the bpf_die. ERROR: trailing whitespace #64: FILE: include/linux/filter.h:703: +^Ispin_lock_irqsave(&prog->term_states->per_cpu_state[cpu_id].lock, $ WARNING: Missing a blank line after declarations #64: FILE: include/linux/filter.h:703: + u32 cpu_id = raw_smp_processor_id(); + spin_lock_irqsave(&prog->term_states->per_cpu_state[cpu_id].lock, CHECK: Alignment should match open parenthesis #65: FILE: include/linux/filter.h:704: + spin_lock_irqsave(&prog->term_states->per_cpu_state[cpu_id].lock, + flags); CHECK: Alignment should match open parenthesis #68: FILE: include/linux/filter.h:707: + spin_unlock_irqrestore(&prog->term_states->per_cpu_state[cpu_id].lock, + flags); WARNING: line length of 115 exceeds 80 columns #76: FILE: include/linux/filter.h:715: + hrtimer_setup(&prog->term_states->hrtimer, bpf_termination_wd_callback, CLOCK_MONOTONIC, HRTIMER_MODE_REL); ERROR: trailing whitespace #84: FILE: include/linux/filter.h:723: +^Ihrtimer_cancel(&prog->term_states->hrtimer); $ ERROR: space required after that ';' (ctx:VxV) #111: FILE: include/linux/filter.h:755: + update_term_per_cpu_flag(prog, 0);} ^ WARNING: line length of 89 exceeds 80 columns #120: FILE: include/linux/filter.h:1159: +int bpf_loop_termination(u32 nr_loops, void *callback_fn, void *callback_ctx, u64 flags); WARNING: line length of 97 exceeds 80 columns #134: FILE: kernel/bpf/core.c:1587: +noinline int bpf_loop_termination(u32 nr_loops, void *callback_fn, void *callback_ctx, u64 flags) CHECK: Lines should not end with a '(' #136: FILE: kernel/bpf/core.c:1589: + asm volatile( WARNING: Use #include instead of #161: FILE: kernel/bpf/syscall.c:42: +#include WARNING: line length of 85 exceeds 80 columns #170: FILE: kernel/bpf/syscall.c:2774: +static bool per_cpu_flag_is_true(struct bpf_term_aux_states *term_states, int cpu_id) ERROR: trailing whitespace #173: FILE: kernel/bpf/syscall.c:2777: +^Ispin_lock_irqsave(&term_states->per_cpu_state[cpu_id].lock, $ WARNING: Missing a blank line after declarations #173: FILE: kernel/bpf/syscall.c:2777: + unsigned long flags; + spin_lock_irqsave(&term_states->per_cpu_state[cpu_id].lock, CHECK: Alignment should match open parenthesis #174: FILE: kernel/bpf/syscall.c:2778: + spin_lock_irqsave(&term_states->per_cpu_state[cpu_id].lock, + flags); CHECK: Alignment should match open parenthesis #177: FILE: kernel/bpf/syscall.c:2781: + spin_unlock_irqrestore(&term_states->per_cpu_state[cpu_id].lock, + flags); CHECK: Alignment should match open parenthesis #181: FILE: kernel/bpf/syscall.c:2785: + spin_unlock_irqrestore(&term_states->per_cpu_state[cpu_id].lock, + flags); ERROR: trailing whitespace #185: FILE: kernel/bpf/syscall.c:2789: +static int is_bpf_address(struct bpf_prog *prog, unsigned long addr) $ CHECK: Blank lines aren't necessary after an open brace '{' #187: FILE: kernel/bpf/syscall.c:2791: +{ + ERROR: code indent should use tabs where possible #188: FILE: kernel/bpf/syscall.c:2792: + unsigned long bpf_func_addr = (unsigned long)prog->bpf_func;$ WARNING: please, no spaces at the start of a line #188: FILE: kernel/bpf/syscall.c:2792: + unsigned long bpf_func_addr = (unsigned long)prog->bpf_func;$ ERROR: code indent should use tabs where possible #189: FILE: kernel/bpf/syscall.c:2793: + if ((addr > bpf_func_addr) &&$ WARNING: Missing a blank line after declarations #189: FILE: kernel/bpf/syscall.c:2793: + unsigned long bpf_func_addr = (unsigned long)prog->bpf_func; + if ((addr > bpf_func_addr) && WARNING: please, no spaces at the start of a line #189: FILE: kernel/bpf/syscall.c:2793: + if ((addr > bpf_func_addr) &&$ CHECK: Unnecessary parentheses around 'addr > bpf_func_addr' #189: FILE: kernel/bpf/syscall.c:2793: + if ((addr > bpf_func_addr) && + (addr < bpf_func_addr + prog->jited_len)){ ERROR: code indent should use tabs where possible #190: FILE: kernel/bpf/syscall.c:2794: + (addr < bpf_func_addr + prog->jited_len)){$ CHECK: Alignment should match open parenthesis #190: FILE: kernel/bpf/syscall.c:2794: + if ((addr > bpf_func_addr) && + (addr < bpf_func_addr + prog->jited_len)){ WARNING: please, no spaces at the start of a line #190: FILE: kernel/bpf/syscall.c:2794: + (addr < bpf_func_addr + prog->jited_len)){$ ERROR: space required before the open brace '{' #190: FILE: kernel/bpf/syscall.c:2794: + (addr < bpf_func_addr + prog->jited_len)){ ERROR: code indent should use tabs where possible #191: FILE: kernel/bpf/syscall.c:2795: + return 1;$ WARNING: please, no spaces at the start of a line #191: FILE: kernel/bpf/syscall.c:2795: + return 1;$ ERROR: code indent should use tabs where possible #192: FILE: kernel/bpf/syscall.c:2796: + }$ WARNING: please, no spaces at the start of a line #192: FILE: kernel/bpf/syscall.c:2796: + }$ ERROR: code indent should use tabs where possible #194: FILE: kernel/bpf/syscall.c:2798: + for (int subprog = 1; subprog < prog->aux->func_cnt; subprog++) {$ WARNING: please, no spaces at the start of a line #194: FILE: kernel/bpf/syscall.c:2798: + for (int subprog = 1; subprog < prog->aux->func_cnt; subprog++) {$ ERROR: code indent should use tabs where possible #195: FILE: kernel/bpf/syscall.c:2799: + struct bpf_prog *bpf_subprog = prog->aux->func[subprog];$ WARNING: please, no spaces at the start of a line #195: FILE: kernel/bpf/syscall.c:2799: + struct bpf_prog *bpf_subprog = prog->aux->func[subprog];$ ERROR: code indent should use tabs where possible #196: FILE: kernel/bpf/syscall.c:2800: + unsigned long bpf_subprog_func_addr =$ WARNING: please, no spaces at the start of a line #196: FILE: kernel/bpf/syscall.c:2800: + unsigned long bpf_subprog_func_addr =$ ERROR: code indent should use tabs where possible #197: FILE: kernel/bpf/syscall.c:2801: + (unsigned long)bpf_subprog->bpf_func;$ WARNING: please, no spaces at the start of a line #197: FILE: kernel/bpf/syscall.c:2801: + (unsigned long)bpf_subprog->bpf_func;$ WARNING: line length of 85 exceeds 80 columns #198: FILE: kernel/bpf/syscall.c:2802: + if ((addr > bpf_subprog_func_addr) && (addr < bpf_subprog_func_addr + ERROR: code indent should use tabs where possible #198: FILE: kernel/bpf/syscall.c:2802: + if ((addr > bpf_subprog_func_addr) && (addr < bpf_subprog_func_addr +$ WARNING: please, no spaces at the start of a line #198: FILE: kernel/bpf/syscall.c:2802: + if ((addr > bpf_subprog_func_addr) && (addr < bpf_subprog_func_addr +$ CHECK: Unnecessary parentheses around 'addr > bpf_subprog_func_addr' #198: FILE: kernel/bpf/syscall.c:2802: + if ((addr > bpf_subprog_func_addr) && (addr < bpf_subprog_func_addr + + bpf_subprog->jited_len)) { WARNING: line length of 82 exceeds 80 columns #199: FILE: kernel/bpf/syscall.c:2803: + bpf_subprog->jited_len)) { ERROR: code indent should use tabs where possible #199: FILE: kernel/bpf/syscall.c:2803: + bpf_subprog->jited_len)) {$ WARNING: please, no spaces at the start of a line #199: FILE: kernel/bpf/syscall.c:2803: + bpf_subprog->jited_len)) {$ ERROR: code indent should use tabs where possible #200: FILE: kernel/bpf/syscall.c:2804: + return 1;$ WARNING: please, no spaces at the start of a line #200: FILE: kernel/bpf/syscall.c:2804: + return 1;$ ERROR: code indent should use tabs where possible #201: FILE: kernel/bpf/syscall.c:2805: + }$ WARNING: please, no spaces at the start of a line #201: FILE: kernel/bpf/syscall.c:2805: + }$ ERROR: code indent should use tabs where possible #202: FILE: kernel/bpf/syscall.c:2806: + }$ WARNING: please, no spaces at the start of a line #202: FILE: kernel/bpf/syscall.c:2806: + }$ ERROR: code indent should use tabs where possible #204: FILE: kernel/bpf/syscall.c:2808: + return 0;$ WARNING: please, no spaces at the start of a line #204: FILE: kernel/bpf/syscall.c:2808: + return 0;$ ERROR: trailing whitespace #207: FILE: kernel/bpf/syscall.c:2811: +/* $ ERROR: trailing whitespace #212: FILE: kernel/bpf/syscall.c:2816: +__always_inline char* find_termination_realloc(struct insn orig_insn, unsigned char *orig_addr, $ WARNING: line length of 96 exceeds 80 columns #212: FILE: kernel/bpf/syscall.c:2816: +__always_inline char* find_termination_realloc(struct insn orig_insn, unsigned char *orig_addr, ERROR: "foo* bar" should be "foo *bar" #212: FILE: kernel/bpf/syscall.c:2816: +__always_inline char* find_termination_realloc(struct insn orig_insn, unsigned char *orig_addr, WARNING: line length of 99 exceeds 80 columns #213: FILE: kernel/bpf/syscall.c:2817: + struct insn patch_insn, unsigned char *patch_addr) { CHECK: Blank lines aren't necessary after an open brace '{' #214: FILE: kernel/bpf/syscall.c:2818: + struct insn patch_insn, unsigned char *patch_addr) { + WARNING: line length of 102 exceeds 80 columns #216: FILE: kernel/bpf/syscall.c:2820: + unsigned long original_call_target = (unsigned long)orig_addr + 5 + orig_insn.immediate.value; WARNING: line length of 101 exceeds 80 columns #218: FILE: kernel/bpf/syscall.c:2822: + unsigned long patch_call_target = (unsigned long)patch_addr + 5 + patch_insn.immediate.value; WARNING: line length of 86 exceeds 80 columns #224: FILE: kernel/bpf/syscall.c:2828: + /* bpf_termination_null_func is the generic stub function unless its either of WARNING: Block comments should align the * on each line #225: FILE: kernel/bpf/syscall.c:2829: + /* bpf_termination_null_func is the generic stub function unless its either of + * the bpf_loop helper or the associated callback ERROR: trailing whitespace #230: FILE: kernel/bpf/syscall.c:2834: +^I$ CHECK: Please don't use multiple blank lines #231: FILE: kernel/bpf/syscall.c:2835: + + WARNING: line length of 93 exceeds 80 columns #232: FILE: kernel/bpf/syscall.c:2836: + unsigned long new_rel = (unsigned long)(new_target - (unsigned long)(orig_addr + 5)); WARNING: Missing a blank line after declarations #235: FILE: kernel/bpf/syscall.c:2839: + char *new_insn = kmalloc(5, GFP_KERNEL); + new_insn[0] = 0xE8; ERROR: code indent should use tabs where possible #241: FILE: kernel/bpf/syscall.c:2845: + ^Ireturn new_insn;$ WARNING: please, no space before tabs #241: FILE: kernel/bpf/syscall.c:2845: + ^Ireturn new_insn;$ WARNING: please, no spaces at the start of a line #241: FILE: kernel/bpf/syscall.c:2845: + ^Ireturn new_insn;$ ERROR: trailing whitespace #244: FILE: kernel/bpf/syscall.c:2848: +/* $ WARNING: line length of 103 exceeds 80 columns #250: FILE: kernel/bpf/syscall.c:2854: +static void __maybe_unused in_place_patch_bpf_prog(struct bpf_prog *prog, struct bpf_prog *patch_prog){ ERROR: open brace '{' following function definitions go on the next line #250: FILE: kernel/bpf/syscall.c:2854: +static void __maybe_unused in_place_patch_bpf_prog(struct bpf_prog *prog, struct bpf_prog *patch_prog){ ERROR: space required before the open brace '{' #250: FILE: kernel/bpf/syscall.c:2854: +static void __maybe_unused in_place_patch_bpf_prog(struct bpf_prog *prog, struct bpf_prog *patch_prog){ CHECK: Blank lines aren't necessary after an open brace '{' #251: FILE: kernel/bpf/syscall.c:2855: +static void __maybe_unused in_place_patch_bpf_prog(struct bpf_prog *prog, struct bpf_prog *patch_prog){ + WARNING: please, no spaces at the start of a line #252: FILE: kernel/bpf/syscall.c:2856: + uint32_t size = 0;$ CHECK: Prefer kernel type 'u32' over 'uint32_t' #252: FILE: kernel/bpf/syscall.c:2856: + uint32_t size = 0; ERROR: trailing whitespace #253: FILE: kernel/bpf/syscall.c:2857: + $ WARNING: please, no spaces at the start of a line #253: FILE: kernel/bpf/syscall.c:2857: + $ WARNING: please, no spaces at the start of a line #254: FILE: kernel/bpf/syscall.c:2858: + while (size < prog->jited_len) {$ WARNING: suspect code indent for conditional statements (7, 15) #254: FILE: kernel/bpf/syscall.c:2858: + while (size < prog->jited_len) { + unsigned char *addr = (unsigned char*)prog->bpf_func; WARNING: Statements should start on a tabstop #255: FILE: kernel/bpf/syscall.c:2859: + unsigned char *addr = (unsigned char*)prog->bpf_func; ERROR: "(foo*)" should be "(foo *)" #255: FILE: kernel/bpf/syscall.c:2859: + unsigned char *addr = (unsigned char*)prog->bpf_func; WARNING: Statements should start on a tabstop #256: FILE: kernel/bpf/syscall.c:2860: + unsigned char *addr_patch = (unsigned char*)patch_prog->bpf_func; ERROR: "(foo*)" should be "(foo *)" #256: FILE: kernel/bpf/syscall.c:2860: + unsigned char *addr_patch = (unsigned char*)patch_prog->bpf_func; WARNING: Statements should start on a tabstop #258: FILE: kernel/bpf/syscall.c:2862: + struct insn insn; WARNING: Statements should start on a tabstop #259: FILE: kernel/bpf/syscall.c:2863: + struct insn insn_patch; ERROR: code indent should use tabs where possible #263: FILE: kernel/bpf/syscall.c:2867: + if (WARN_ON_ONCE(insn_decode_kernel(&insn, addr))) {$ WARNING: please, no spaces at the start of a line #263: FILE: kernel/bpf/syscall.c:2867: + if (WARN_ON_ONCE(insn_decode_kernel(&insn, addr))) {$ WARNING: suspect code indent for conditional statements (15, 24) #263: FILE: kernel/bpf/syscall.c:2867: + if (WARN_ON_ONCE(insn_decode_kernel(&insn, addr))) { + return; WARNING: braces {} are not necessary for single statement blocks #263: FILE: kernel/bpf/syscall.c:2867: + if (WARN_ON_ONCE(insn_decode_kernel(&insn, addr))) { + return; + } ERROR: code indent should use tabs where possible #264: FILE: kernel/bpf/syscall.c:2868: +^I ^I^Ireturn;$ WARNING: please, no space before tabs #264: FILE: kernel/bpf/syscall.c:2868: +^I ^I^Ireturn;$ ERROR: code indent should use tabs where possible #265: FILE: kernel/bpf/syscall.c:2869: + }$ WARNING: please, no spaces at the start of a line #265: FILE: kernel/bpf/syscall.c:2869: + }$ ERROR: code indent should use tabs where possible #267: FILE: kernel/bpf/syscall.c:2871: + /* Check for call instruction */$ ERROR: code indent should use tabs where possible #268: FILE: kernel/bpf/syscall.c:2872: + if (insn.opcode.bytes[0] != CALL_INSN_OPCODE) {$ WARNING: please, no spaces at the start of a line #268: FILE: kernel/bpf/syscall.c:2872: + if (insn.opcode.bytes[0] != CALL_INSN_OPCODE) {$ WARNING: suspect code indent for conditional statements (15, 23) #268: FILE: kernel/bpf/syscall.c:2872: + if (insn.opcode.bytes[0] != CALL_INSN_OPCODE) { + goto next_insn; WARNING: braces {} are not necessary for single statement blocks #268: FILE: kernel/bpf/syscall.c:2872: + if (insn.opcode.bytes[0] != CALL_INSN_OPCODE) { + goto next_insn; + } ERROR: trailing whitespace #269: FILE: kernel/bpf/syscall.c:2873: + goto next_insn; $ ERROR: code indent should use tabs where possible #269: FILE: kernel/bpf/syscall.c:2873: + goto next_insn; $ WARNING: please, no spaces at the start of a line #269: FILE: kernel/bpf/syscall.c:2873: + goto next_insn; $ ERROR: code indent should use tabs where possible #270: FILE: kernel/bpf/syscall.c:2874: + }$ WARNING: please, no spaces at the start of a line #270: FILE: kernel/bpf/syscall.c:2874: + }$ ERROR: trailing whitespace #271: FILE: kernel/bpf/syscall.c:2875: + $ WARNING: please, no spaces at the start of a line #271: FILE: kernel/bpf/syscall.c:2875: + $ ERROR: code indent should use tabs where possible #274: FILE: kernel/bpf/syscall.c:2878: + if (WARN_ON_ONCE(insn_decode_kernel(&insn_patch, addr_patch))) {$ WARNING: please, no spaces at the start of a line #274: FILE: kernel/bpf/syscall.c:2878: + if (WARN_ON_ONCE(insn_decode_kernel(&insn_patch, addr_patch))) {$ WARNING: suspect code indent for conditional statements (15, 24) #274: FILE: kernel/bpf/syscall.c:2878: + if (WARN_ON_ONCE(insn_decode_kernel(&insn_patch, addr_patch))) { + return ; WARNING: braces {} are not necessary for single statement blocks #274: FILE: kernel/bpf/syscall.c:2878: + if (WARN_ON_ONCE(insn_decode_kernel(&insn_patch, addr_patch))) { + return ; + } ERROR: code indent should use tabs where possible #275: FILE: kernel/bpf/syscall.c:2879: +^I ^I^Ireturn ;$ WARNING: please, no space before tabs #275: FILE: kernel/bpf/syscall.c:2879: +^I ^I^Ireturn ;$ WARNING: space prohibited before semicolon #275: FILE: kernel/bpf/syscall.c:2879: + return ; ERROR: code indent should use tabs where possible #276: FILE: kernel/bpf/syscall.c:2880: + }$ WARNING: please, no spaces at the start of a line #276: FILE: kernel/bpf/syscall.c:2880: + }$ WARNING: Statements should start on a tabstop #279: FILE: kernel/bpf/syscall.c:2883: + char *buf; WARNING: line length of 98 exceeds 80 columns #280: FILE: kernel/bpf/syscall.c:2884: + if ((buf = find_termination_realloc(insn, addr, insn_patch, addr_patch)) != NULL) { WARNING: Statements should start on a tabstop #280: FILE: kernel/bpf/syscall.c:2884: + if ((buf = find_termination_realloc(insn, addr, insn_patch, addr_patch)) != NULL) { WARNING: Missing a blank line after declarations #280: FILE: kernel/bpf/syscall.c:2884: + char *buf; + if ((buf = find_termination_realloc(insn, addr, insn_patch, addr_patch)) != NULL) { WARNING: suspect code indent for conditional statements (15, 23) #280: FILE: kernel/bpf/syscall.c:2884: + if ((buf = find_termination_realloc(insn, addr, insn_patch, addr_patch)) != NULL) { + smp_text_poke_batch_add(addr, buf, insn.length, NULL); ERROR: do not use assignment in if condition #280: FILE: kernel/bpf/syscall.c:2884: + if ((buf = find_termination_realloc(insn, addr, insn_patch, addr_patch)) != NULL) { WARNING: Statements should start on a tabstop #283: FILE: kernel/bpf/syscall.c:2887: + } ERROR: trailing whitespace #284: FILE: kernel/bpf/syscall.c:2888: + $ ERROR: code indent should use tabs where possible #284: FILE: kernel/bpf/syscall.c:2888: + $ WARNING: please, no spaces at the start of a line #284: FILE: kernel/bpf/syscall.c:2888: + $ WARNING: labels should not be indented #285: FILE: kernel/bpf/syscall.c:2889: + next_insn: ERROR: code indent should use tabs where possible #286: FILE: kernel/bpf/syscall.c:2890: + size += insn.length;$ WARNING: please, no spaces at the start of a line #286: FILE: kernel/bpf/syscall.c:2890: + size += insn.length;$ ERROR: trailing whitespace #287: FILE: kernel/bpf/syscall.c:2891: + } $ WARNING: please, no spaces at the start of a line #287: FILE: kernel/bpf/syscall.c:2891: + } $ CHECK: Please don't use multiple blank lines #290: FILE: kernel/bpf/syscall.c:2894: + + WARNING: line length of 82 exceeds 80 columns #302: FILE: kernel/bpf/syscall.c:2906: + unsigned long jmp_offset = prog->jited_len - (4 /*First endbr is 4 bytes*/ ERROR: trailing whitespace #303: FILE: kernel/bpf/syscall.c:2907: +^I^I^I^I^I^I+ 5 /*5 bytes of noop*/ $ WARNING: line length of 85 exceeds 80 columns #304: FILE: kernel/bpf/syscall.c:2908: + + 5 /*5 bytes of jmp return_thunk*/); WARNING: Missing a blank line after declarations #306: FILE: kernel/bpf/syscall.c:2910: + char new_insn[5]; + new_insn[0] = 0xE9; ERROR: spaces required around that '=' (ctx:VxV) #315: FILE: kernel/bpf/syscall.c:2919: + for(int i=0; iaux->func_cnt; i++){ ^ ERROR: spaces required around that '<' (ctx:VxV) #315: FILE: kernel/bpf/syscall.c:2919: + for(int i=0; iaux->func_cnt; i++){ ^ ERROR: space required before the open brace '{' #315: FILE: kernel/bpf/syscall.c:2919: + for(int i=0; iaux->func_cnt; i++){ ERROR: space required before the open parenthesis '(' #315: FILE: kernel/bpf/syscall.c:2919: + for(int i=0; iaux->func_cnt; i++){ WARNING: braces {} are not necessary for single statement blocks #315: FILE: kernel/bpf/syscall.c:2919: + for(int i=0; iaux->func_cnt; i++){ + in_place_patch_bpf_prog(prog->aux->func[i], patch_prog->aux->func[i]); + } WARNING: line length of 94 exceeds 80 columns #316: FILE: kernel/bpf/syscall.c:2920: + in_place_patch_bpf_prog(prog->aux->func[i], patch_prog->aux->func[i]); CHECK: Please don't use multiple blank lines #324: FILE: kernel/bpf/syscall.c:2928: + + WARNING: Missing a blank line after declarations #330: FILE: kernel/bpf/syscall.c:2934: + char str[KSYM_SYMBOL_LEN]; + bpf_loop_addr = (unsigned long)bpf_loop_proto.func; WARNING: Missing a blank line after declarations #337: FILE: kernel/bpf/syscall.c:2941: + unsigned long stack_addr = regs->sp; + while (addr) { WARNING: else is not generally useful after a break or return #340: FILE: kernel/bpf/syscall.c:2944: + break; + } else { WARNING: line length of 88 exceeds 80 columns #341: FILE: kernel/bpf/syscall.c:2945: + const char *name = kallsyms_lookup(addr, NULL, NULL, NULL, str); WARNING: Missing a blank line after declarations #342: FILE: kernel/bpf/syscall.c:2946: + const char *name = kallsyms_lookup(addr, NULL, NULL, NULL, str); + if (name) { WARNING: line length of 87 exceeds 80 columns #343: FILE: kernel/bpf/syscall.c:2947: + unsigned long lookup_addr = kallsyms_lookup_name(name); WARNING: line length of 82 exceeds 80 columns #344: FILE: kernel/bpf/syscall.c:2948: + if (lookup_addr && lookup_addr == bpf_loop_addr) { WARNING: Missing a blank line after declarations #344: FILE: kernel/bpf/syscall.c:2948: + unsigned long lookup_addr = kallsyms_lookup_name(name); + if (lookup_addr && lookup_addr == bpf_loop_addr) { WARNING: line length of 86 exceeds 80 columns #345: FILE: kernel/bpf/syscall.c:2949: + while (*(unsigned long *)stack_addr != addr) { WARNING: braces {} are not necessary for single statement blocks #345: FILE: kernel/bpf/syscall.c:2949: + while (*(unsigned long *)stack_addr != addr) { + stack_addr += 1; + } WARNING: line length of 90 exceeds 80 columns #348: FILE: kernel/bpf/syscall.c:2952: + *(unsigned long *)stack_addr = bpf_loop_term_addr; WARNING: void function return statements are not generally useful #358: FILE: kernel/bpf/syscall.c:2962: + return; +} CHECK: Blank lines aren't necessary after an open brace '{' #362: FILE: kernel/bpf/syscall.c:2966: +{ + WARNING: line length of 104 exceeds 80 columns #363: FILE: kernel/bpf/syscall.c:2967: + struct bpf_term_aux_states *term_states = container_of(hr, struct bpf_term_aux_states, hrtimer); WARNING: Missing a blank line after declarations #365: FILE: kernel/bpf/syscall.c:2969: + struct bpf_prog *prog = term_states->prog; + bpf_die(prog); CHECK: Blank lines aren't necessary before a close brace '}' #368: FILE: kernel/bpf/syscall.c:2972: + +} total: 54 errors, 91 warnings, 18 checks, 341 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit ece4f97500e3 ("bpf: Runtime part of fast-path termination approach") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.