WARNING: line length of 101 exceeds 80 columns #109: FILE: kernel/bpf/syscall.c:2991: + prog->term_states->patch_prog = bpf_prog_select_runtime(prog->term_states->patch_prog, &err); WARNING: line length of 97 exceeds 80 columns #151: FILE: kernel/bpf/verifier.c:21689: + struct bpf_insn *insn_buf, int insn_idx, int *cnt, int *kfunc_btf_id) WARNING: Missing a blank line after declarations #188: FILE: kernel/bpf/verifier.c:21853: + int *call_idx; + env->bpf_term_patch_call_sites.call_idx = NULL; WARNING: line length of 100 exceeds 80 columns #202: FILE: kernel/bpf/verifier.c:22194: + ret = fixup_kfunc_call(env, insn, insn_buf, i + delta, &cnt, &kfunc_btf_id); WARNING: Missing a blank line after declarations #202: FILE: kernel/bpf/verifier.c:22194: + int kfunc_btf_id = 0; + ret = fixup_kfunc_call(env, insn, insn_buf, i + delta, &cnt, &kfunc_btf_id); WARNING: line length of 96 exceeds 80 columns #295: FILE: kernel/bpf/verifier.c:24455: + patch_prog->aux->func_cnt = prog->aux->func_cnt; /* will be populated by jit_subprogs */ WARNING: line length of 106 exceeds 80 columns #296: FILE: kernel/bpf/verifier.c:24456: + patch_prog->aux->real_func_cnt = prog->aux->real_func_cnt; /* will be populated by jit_subprogs */ WARNING: line length of 96 exceeds 80 columns #297: FILE: kernel/bpf/verifier.c:24457: + patch_prog->aux->func_idx = prog->aux->func_idx; /* will be populated by jit_subprogs */ WARNING: line length of 88 exceeds 80 columns #299: FILE: kernel/bpf/verifier.c:24459: + patch_prog->aux->attach_st_ops_member_off = prog->aux->attach_st_ops_member_off; WARNING: line length of 82 exceeds 80 columns #308: FILE: kernel/bpf/verifier.c:24468: + patch_prog->aux->func_proto_unreliable = prog->aux->func_proto_unreliable; WARNING: line length of 82 exceeds 80 columns #318: FILE: kernel/bpf/verifier.c:24478: + patch_prog->aux->prog_array_member_cnt = prog->aux->prog_array_member_cnt; ERROR: trailing whitespace #321: FILE: kernel/bpf/verifier.c:24481: +^Ipatch_prog->aux->linfo = prog->aux->linfo; $ ERROR: trailing whitespace #327: FILE: kernel/bpf/verifier.c:24487: +^Ipatch_prog->aux->poke_tab = kmalloc_array(patch_prog->aux->size_poke_tab, $ WARNING: line length of 82 exceeds 80 columns #327: FILE: kernel/bpf/verifier.c:24487: + patch_prog->aux->poke_tab = kmalloc_array(patch_prog->aux->size_poke_tab, WARNING: line length of 92 exceeds 80 columns #328: FILE: kernel/bpf/verifier.c:24488: + sizeof(struct bpf_jit_poke_descriptor), GFP_KERNEL); CHECK: Alignment should match open parenthesis #328: FILE: kernel/bpf/verifier.c:24488: + patch_prog->aux->poke_tab = kmalloc_array(patch_prog->aux->size_poke_tab, + sizeof(struct bpf_jit_poke_descriptor), GFP_KERNEL); ERROR: trailing whitespace #334: FILE: kernel/bpf/verifier.c:24494: +^I$ ERROR: trailing whitespace #336: FILE: kernel/bpf/verifier.c:24496: +^I^Imemcpy(&patch_prog->aux->poke_tab[i], &prog->aux->poke_tab[i], $ CHECK: Alignment should match open parenthesis #337: FILE: kernel/bpf/verifier.c:24497: + memcpy(&patch_prog->aux->poke_tab[i], &prog->aux->poke_tab[i], + sizeof(struct bpf_jit_poke_descriptor)); WARNING: Missing a blank line after declarations #343: FILE: kernel/bpf/verifier.c:24503: + char *patch_prefix = "patch_"; + prog_name_len = strlen(prog->aux->name); WARNING: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #344: FILE: kernel/bpf/verifier.c:24504: + strncpy(patch_prog->aux->name, patch_prefix, strlen(patch_prefix)); WARNING: braces {} are not necessary for single statement blocks #346: FILE: kernel/bpf/verifier.c:24506: + if (prog_name_len + strlen(patch_prefix) + 1 > BPF_OBJ_NAME_LEN) { + prog_name_len = BPF_OBJ_NAME_LEN - strlen(patch_prefix) - 1; + } ERROR: trailing whitespace #350: FILE: kernel/bpf/verifier.c:24510: +^I$ ERROR: trailing whitespace #364: FILE: kernel/bpf/verifier.c:24524: +^I$ ERROR: trailing whitespace #366: FILE: kernel/bpf/verifier.c:24526: +^I^Ipatch_prog->insnsi[call_idx[i]].imm = $ WARNING: line length of 82 exceeds 80 columns #373: FILE: kernel/bpf/verifier.c:24533: + for (i = 0, insn = patch_prog->insnsi; i < patch_prog->len; i++, insn++) { WARNING: line length of 89 exceeds 80 columns #382: FILE: kernel/bpf/verifier.c:24542: + patch_prog->insnsi[i].imm = BPF_CALL_IMM(bpf_loop_term_callback); ERROR: trailing whitespace #390: FILE: kernel/bpf/verifier.c:24550: +^I^I$ CHECK: Blank lines aren't necessary before a close brace '}' #391: FILE: kernel/bpf/verifier.c:24551: + + } CHECK: Please don't use multiple blank lines #396: FILE: kernel/bpf/verifier.c:24556: + + CHECK: Please don't use multiple blank lines #413: FILE: kernel/bpf/verifier.c:24573: + + ERROR: trailing whitespace #416: FILE: kernel/bpf/verifier.c:24576: +^I$ CHECK: Blank lines aren't necessary after an open brace '{' #416: FILE: kernel/bpf/verifier.c:24576: +{ + ERROR: trailing whitespace #421: FILE: kernel/bpf/verifier.c:24581: +^Iif (!patch_env) $ WARNING: line length of 81 exceeds 80 columns #432: FILE: kernel/bpf/verifier.c:24592: + patch_env->prog->aux->verifier_zext = bpf_jit_needs_zext() ? !err CHECK: Blank lines aren't necessary before a close brace '}' #443: FILE: kernel/bpf/verifier.c:24603: + +} total: 10 errors, 19 warnings, 7 checks, 415 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit 0b48fa2ae821 ("bpf: Generating a stubbed version of BPF program for termination") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.