========== checkpatch - FAILED CHECK: spinlock_t definition without comment #45: FILE: include/linux/bpf.h:1545: + spinlock_t lock; WARNING: line length of 85 exceeds 80 columns #71: FILE: include/linux/bpf.h:1693: + struct bpf_term_aux_states *term_states; /* Program termination aux fields */ WARNING: line length of 99 exceeds 80 columns #99: FILE: kernel/bpf/core.c:121: + term_states = kzalloc(sizeof(*term_states), bpf_memcg_flags(GFP_KERNEL | gfp_extra_flags)); ERROR: trailing whitespace #103: FILE: kernel/bpf/core.c:125: +^Iterm_states->per_cpu_state = kzalloc(sizeof(struct cpu_aux) * NR_CPUS, $ WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc #103: FILE: kernel/bpf/core.c:125: + term_states->per_cpu_state = kzalloc(sizeof(struct cpu_aux) * NR_CPUS, WARNING: line length of 95 exceeds 80 columns #104: FILE: kernel/bpf/core.c:126: + bpf_memcg_flags(GFP_KERNEL | gfp_extra_flags)); CHECK: Alignment should match open parenthesis #104: FILE: kernel/bpf/core.c:126: + term_states->per_cpu_state = kzalloc(sizeof(struct cpu_aux) * NR_CPUS, + bpf_memcg_flags(GFP_KERNEL | gfp_extra_flags)); ERROR: trailing whitespace #107: FILE: kernel/bpf/core.c:129: +^I$ WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc #108: FILE: kernel/bpf/core.c:130: + for (int i = 0; i < NR_CPUS; i++) { CHECK: Please don't use multiple blank lines #113: FILE: kernel/bpf/core.c:135: + + total: 2 errors, 5 warnings, 3 checks, 126 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit cd6663777166 ("bpf: Introduce new structs and struct fields") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.