WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #56: new file mode 100644 WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines #76: FILE: drivers/net/ethernet/spacemit/Kconfig:16: +config SPACEMIT_K1_EMAC + tristate "SpacemiT K1 Ethernet MAC driver" + depends on ARCH_SPACEMIT || COMPILE_TEST + depends on MFD_SYSCON + depends on OF + default m if ARCH_SPACEMIT + select PHYLIB + help + This driver supports the Ethernet MAC in the SpacemiT K1 SoC. + + To compile this driver as a module, choose M here: the module + will be called k1_emac. + WARNING: line length of 83 exceeds 80 columns #181: FILE: drivers/net/ethernet/spacemit/k1_emac.c:74: +#define EMAC_REG_SPACE_SIZE ((EMAC_DMA_REG_CNT + EMAC_MAC_REG_CNT) * 4) WARNING: line length of 86 exceeds 80 columns #276: FILE: drivers/net/ethernet/spacemit/k1_emac.c:169: + /* Must be held when reading statistics counters because of indirect access */ WARNING: line length of 84 exceeds 80 columns #290: FILE: drivers/net/ethernet/spacemit/k1_emac.c:183: +#define EMAC_ETHTOOL_STAT(x) { #x, offsetof(struct emac_hw_stats, x) / sizeof(u32) } WARNING: line length of 81 exceeds 80 columns #383: FILE: drivers/net/ethernet/spacemit/k1_emac.c:276: + MREGBIT_RESET_RX_STAT_COUNTERS | MREGBIT_RESET_TX_STAT_COUNTERS); WARNING: line length of 81 exceeds 80 columns #412: FILE: drivers/net/ethernet/spacemit/k1_emac.c:305: + emac_wr(priv, MAC_TRANSMIT_PACKET_START_THRESHOLD, DEFAULT_TX_THRESHOLD); WARNING: line length of 81 exceeds 80 columns #887: FILE: drivers/net/ethernet/spacemit/k1_emac.c:780: + dma_free_coherent(dev, tr->total_size, tr->desc_addr, tr->desc_dma_addr); WARNING: line length of 81 exceeds 80 columns #901: FILE: drivers/net/ethernet/spacemit/k1_emac.c:794: + dma_free_coherent(dev, rr->total_size, rr->desc_addr, rr->desc_dma_addr); WARNING: line length of 88 exceeds 80 columns #1220: FILE: drivers/net/ethernet/spacemit/k1_emac.c:1113: + tx_desc_addr = &((struct emac_desc *)tx_ring->desc_addr)[first]; WARNING: line length of 92 exceeds 80 columns #1229: FILE: drivers/net/ethernet/spacemit/k1_emac.c:1122: + tx_desc_addr = &((struct emac_desc *)tx_ring->desc_addr)[i]; WARNING: line length of 86 exceeds 80 columns #1264: FILE: drivers/net/ethernet/spacemit/k1_emac.c:1157: + if (emac_tx_coal_should_interrupt(priv, frag_num + 1)) WARNING: line length of 91 exceeds 80 columns #1265: FILE: drivers/net/ethernet/spacemit/k1_emac.c:1158: + tx_desc.desc1 |= TX_DESC_1_INTERRUPT_ON_COMPLETION; WARNING: line length of 87 exceeds 80 columns #1270: FILE: drivers/net/ethernet/spacemit/k1_emac.c:1163: + WRITE_ONCE(tx_desc_addr->desc0, tx_desc.desc0 | TX_DESC_0_OWN); WARNING: line length of 87 exceeds 80 columns #1529: FILE: drivers/net/ethernet/spacemit/k1_emac.c:1422: + struct emac_priv *priv = container_of(work, struct emac_priv, tx_timeout_task); WARNING: line length of 85 exceeds 80 columns #1664: FILE: drivers/net/ethernet/spacemit/k1_emac.c:1557: + mask |= EMAC_RX_DLINE_EN | EMAC_RX_DLINE_STEP_MASK | EMAC_RX_DLINE_CODE_MASK; WARNING: line length of 85 exceeds 80 columns #1665: FILE: drivers/net/ethernet/spacemit/k1_emac.c:1558: + mask |= EMAC_TX_DLINE_EN | EMAC_TX_DLINE_STEP_MASK | EMAC_TX_DLINE_CODE_MASK; WARNING: line length of 94 exceeds 80 columns #1674: FILE: drivers/net/ethernet/spacemit/k1_emac.c:1567: + val |= (priv->rx_delay << EMAC_RX_DLINE_CODE_SHIFT) & EMAC_RX_DLINE_CODE_MASK; WARNING: line length of 94 exceeds 80 columns #1678: FILE: drivers/net/ethernet/spacemit/k1_emac.c:1571: + val |= (priv->tx_delay << EMAC_TX_DLINE_CODE_SHIFT) & EMAC_TX_DLINE_CODE_MASK; WARNING: line length of 85 exceeds 80 columns #1947: FILE: drivers/net/ethernet/spacemit/k1_emac.c:1840: +#define EMAC_MAX_DELAY_UNIT (EMAC_TX_DLINE_CODE_MASK >> EMAC_TX_DLINE_CODE_SHIFT) WARNING: line length of 85 exceeds 80 columns #1961: FILE: drivers/net/ethernet/spacemit/k1_emac.c:1854: + return dev_err_probe(dev, PTR_ERR(priv->iobase), "ioremap failed\n"); WARNING: line length of 88 exceeds 80 columns #1963: FILE: drivers/net/ethernet/spacemit/k1_emac.c:1856: + priv->regmap_apmu = syscon_regmap_lookup_by_phandle_args(np, "spacemit,apmu", 1, WARNING: line length of 92 exceeds 80 columns #1964: FILE: drivers/net/ethernet/spacemit/k1_emac.c:1857: + &priv->regmap_apmu_offset); WARNING: line length of 82 exceeds 80 columns #1977: FILE: drivers/net/ethernet/spacemit/k1_emac.c:1870: + return dev_err_probe(dev, ret, "Can't get MAC address\n"); WARNING: line length of 87 exceeds 80 columns #2064: FILE: drivers/net/ethernet/spacemit/k1_emac.c:1957: + reset = devm_reset_control_get_optional_exclusive_deasserted(&pdev->dev, NULL); WARNING: line length of 82 exceeds 80 columns #2066: FILE: drivers/net/ethernet/spacemit/k1_emac.c:1959: + ret = dev_err_probe(dev, PTR_ERR(reset), "Failed to get reset\n"); total: 0 errors, 26 warnings, 0 checks, 2524 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 4fa49a4a685d ("net: spacemit: Add K1 Ethernet MAC") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 26 warnings, 0 checks, 2524 lines checked