ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.f09F81LDuc and /tmp/tmp.j9XZIU2KRf
Tree base:
cf0943bcb44a ("selftests: net: lib: Add ip_link_has_flag()")
Now at:
aeec97ba55fe ("selftests: forwarding: adf_mcd_start(): Allow configuring custom interfaces")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/forwarding/lib.sh - e1a847ed4d4592e29820ec7d4d0de16c1b815b225d7508d588b8b4f99ffa9610


In lib.sh line 97:
		basename `realpath $driver_path`
                         ^---------------------^ SC2046 (warning): Quote this to prevent word splitting.
                         ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
                                   ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		basename $(realpath "$driver_path")


In lib.sh line 103:
	local ifnames=`ip -j link show | jq -r ".[].ifname"`
              ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                      ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean: 
	local ifnames=$(ip -j link show | jq -r ".[].ifname")


In lib.sh line 108:
		local driver_name=`driver_name_get $ifname`
                      ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                  ^-----------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
                                                   ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		local driver_name=$(driver_name_get "$ifname")


In lib.sh line 109:
		if [[ ! -z $driver_name && $driver_name == $NETIF_FIND_DRIVER ]]; then
                      ^-- SC2236 (style): Use -n instead of ! -z.
                                                           ^----------------^ SC2053 (warning): Quote the right-hand side of == in [[ ]] to prevent glob matching.


In lib.sh line 128:
	source "$net_forwarding_dir/forwarding.config"
               ^-- SC1091 (info): Not following: ./forwarding.config: openBinaryFile: does not exist (No such file or directory)


In lib.sh line 139:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 150:
	tc filter add dev $dev ingress protocol mpls_uc pref 1 handle 1 \
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter add dev "$dev" ingress protocol mpls_uc pref 1 handle 1 \


In lib.sh line 152:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 156:
	tc filter del dev $dev ingress protocol mpls_uc pref 1 handle 1 \
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter del dev "$dev" ingress protocol mpls_uc pref 1 handle 1 \


In lib.sh line 166:
	tc filter add dev $dev ingress protocol mpls_uc pref 1 handle 1 \
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter add dev "$dev" ingress protocol mpls_uc pref 1 handle 1 \


In lib.sh line 170:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 175:
	tc -j filter show dev $dev ingress protocol mpls_uc | jq . &> /dev/null
                              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc -j filter show dev "$dev" ingress protocol mpls_uc | jq . &> /dev/null


In lib.sh line 177:
	tc filter del dev $dev ingress protocol mpls_uc pref 1 handle 1 \
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter del dev "$dev" ingress protocol mpls_uc pref 1 handle 1 \


In lib.sh line 189:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 198:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 207:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 216:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 225:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 234:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 243:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 254:
	[ 0 -ne $(ethtool --json -S $dev --all-groups --src pmac 2>/dev/null \
                ^-- SC2046 (warning): Quote this to prevent word splitting.
                                    ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	[ 0 -ne $(ethtool --json -S "$dev" --all-groups --src pmac 2>/dev/null \


In lib.sh line 283:
	local driver_name=`driver_name_get $dev`
              ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                          ^--------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
                                           ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local driver_name=$(driver_name_get "$dev")


In lib.sh line 285:
	if [[ $driver_name != $expected ]]; then
                              ^-------^ SC2053 (warning): Quote the right-hand side of != in [[ ]] to prevent glob matching.


In lib.sh line 298:
	local version="$(msend -v)"
              ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 302:
	major=$(echo $version | cut -d. -f1)
                     ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	major=$(echo "$version" | cut -d. -f1)


In lib.sh line 304:
	if [ $major -lt 3 ]; then
             ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	if [ "$major" -lt 3 ]; then


In lib.sh line 314:
	require_command $MZ
                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	require_command "$MZ"


In lib.sh line 317:
	require_command $TEAMD
                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	require_command "$TEAMD"


In lib.sh line 350:
	echo "SKIP: Importer requires $NUM_NETIFS NETIFS, but only ${#NETIFS[@]} are defined (${NETIFS[@]})"
                                                                                              ^----------^ SC2145 (error): Argument mixes string and array. Use * or separate argument.


In lib.sh line 368:
		if [ -z ${NETIFS[p$i]} ]; then
                        ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		if [ -z "${NETIFS[p$i]}" ]; then


In lib.sh line 373:
		ip link show dev ${NETIFS[p$i]} &> /dev/null
                                 ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip link show dev "${NETIFS[p$i]}" &> /dev/null


In lib.sh line 374:
		if [[ $? -ne 0 ]]; then
                      ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 375:
			ip link add ${NETIFS[p$i]} type veth \
                                    ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			ip link add "${NETIFS[p$i]}" type veth \


In lib.sh line 376:
				peer name ${NETIFS[p$j]}
                                          ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
				peer name "${NETIFS[p$j]}"


In lib.sh line 377:
			if [[ $? -ne 0 ]]; then
                              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 391:
	*) echo "Can not create interfaces of type \'$NETIF_TYPE\'"
                ^-- SC2028 (info): echo may not expand escape sequences. Use printf.


In lib.sh line 407:
		MAC_ADDR_ORIG["$dev"]=$(ip -j link show dev $dev | jq -e '.[].address')
                                                            ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		MAC_ADDR_ORIG["$dev"]=$(ip -j link show dev "$dev" | jq -e '.[].address')


In lib.sh line 410:
		ip link set dev $dev address $new_addr
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip link set dev "$dev" address "$new_addr"


In lib.sh line 420:
		ip link set dev $dev address ${MAC_ADDR_ORIG["$dev"]}
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip link set dev "$dev" address "${MAC_ADDR_ORIG["$dev"]}"


In lib.sh line 433:
	ip link show dev ${NETIFS[p$i]} &> /dev/null
                         ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link show dev "${NETIFS[p$i]}" &> /dev/null


In lib.sh line 434:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 446:
	[[ $? != 0 ]]
           ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 454:
	for cur in ${arr[@]}; do
                   ^-------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements.


In lib.sh line 460:
	echo $max
             ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	echo "$max"


In lib.sh line 476:
	$@ | grep $addr | grep $flag "$word"
        ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.
                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$@ | grep "$addr" | grep "$flag" "$word"


In lib.sh line 499:
	setup_wait_dev_with_timeout "$dev" $INTERFACE_TIMEOUT $wait_time
                                           ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	setup_wait_dev_with_timeout "$dev" "$INTERFACE_TIMEOUT" "$wait_time"


In lib.sh line 501:
	if (($?)); then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 515:
	for ((i = 1; i <= $max_iterations; ++i)); do
                          ^-------------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In lib.sh line 516:
		ip link show dev $dev up \
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip link show dev "$dev" up \


In lib.sh line 518:
		if [[ $? -ne 0 ]]; then
                      ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 521:
			sleep $wait_time
                              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			sleep "$wait_time"


In lib.sh line 535:
		setup_wait_dev ${NETIFS[p$i]} 0
                               ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		setup_wait_dev "${NETIFS[p$i]}" 0


In lib.sh line 539:
	sleep $WAIT_TIME
              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	sleep "$WAIT_TIME"


In lib.sh line 547:
        slowwait $timeout ip link show dev $dev &> /dev/null
                 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                           ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        slowwait "$timeout" ip link show dev "$dev" &> /dev/null


In lib.sh line 548:
        if (( $? )); then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 551:
                exit $EXIT_STATUS
                     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
                exit "$EXIT_STATUS"


In lib.sh line 569:
	output=$(echo $output | jq -r $jq_opts "$jq_exp")
                      ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	output=$(echo "$output" | jq -r "$jq_opts" "$jq_exp")


In lib.sh line 574:
	echo $output
             ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	echo "$output"


In lib.sh line 576:
	[ ! -z "$output" ]
          ^-- SC2236 (style): Use -n instead of ! -z.


In lib.sh line 583:
		read
                ^--^ SC2162 (info): read without -r will mangle backslashes.


In lib.sh line 623:
	return ${__TB_IDS[$vrf_name]}
               ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	return "${__TB_IDS[$vrf_name]}"


In lib.sh line 631:
	__vrf_td_id_assign $vrf_name
                           ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__vrf_td_id_assign "$vrf_name"


In lib.sh line 634:
	ip link add dev $vrf_name type vrf table $tb_id
                        ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link add dev "$vrf_name" type vrf table $tb_id


In lib.sh line 644:
	__vrf_td_id_lookup $vrf_name
                           ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__vrf_td_id_lookup "$vrf_name"


In lib.sh line 649:
	ip link del dev $vrf_name
                        ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link del dev "$vrf_name"


In lib.sh line 663:
		ip address $add_del $addrstr dev $if_name
                           ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip address "$add_del" "$addrstr" dev "$if_name"


In lib.sh line 673:
	ip link set dev $if_name master $vrf_name
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$if_name" master "$vrf_name"


In lib.sh line 674:
	ip link set dev $if_name up
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$if_name" up


In lib.sh line 676:
	__addr_add_del $if_name add "${addrs[@]}"
                       ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__addr_add_del "$if_name" add "${addrs[@]}"


In lib.sh line 684:
	__addr_add_del $if_name del "${addrs[@]}"
                       ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__addr_add_del "$if_name" del "${addrs[@]}"


In lib.sh line 686:
	ip link set dev $if_name down
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$if_name" down


In lib.sh line 687:
	ip link set dev $if_name nomaster
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$if_name" nomaster


In lib.sh line 700:
	vrf_create $vrf_name
                   ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	vrf_create "$vrf_name"


In lib.sh line 701:
	ip link set dev $vrf_name up
                        ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$vrf_name" up


In lib.sh line 702:
	__simple_if_init $if_name $vrf_name "${array[@]}"
                         ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__simple_if_init "$if_name" "$vrf_name" "${array[@]}"


In lib.sh line 715:
	__simple_if_fini $if_name "${array[@]}"
                         ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__simple_if_fini "$if_name" "${array[@]}"


In lib.sh line 716:
	vrf_destroy $vrf_name
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	vrf_destroy "$vrf_name"


In lib.sh line 726:
	ip link add name $name type $type \
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link add name "$name" type "$type" \


In lib.sh line 727:
	   local $local remote $remote "$@"
                 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	   local "$local" remote "$remote" "$@"


In lib.sh line 728:
	ip link set dev $name up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$name" up


In lib.sh line 735:
	ip link del dev $name
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link del dev "$name"


In lib.sh line 746:
	ip link add name $name link $if_name type vlan id $vid
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link add name "$name" link "$if_name" type vlan id "$vid"


In lib.sh line 748:
		ip link set dev $name master $vrf
                                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip link set dev "$name" master "$vrf"


In lib.sh line 750:
	ip link set dev $name up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$name" up


In lib.sh line 751:
	__addr_add_del $name add "${ips[@]}"
                       ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__addr_add_del "$name" add "${ips[@]}"


In lib.sh line 760:
	ip link del dev $name
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link del dev "$name"


In lib.sh line 768:
	require_command $TEAMD
                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	require_command "$TEAMD"


In lib.sh line 769:
	$TEAMD -t $if_name -d -c '{"runner": {"name": "'$mode'"}}'
                  ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$TEAMD -t "$if_name" -d -c '{"runner": {"name": "'"$mode"'"}}'


In lib.sh line 771:
		ip link set dev $slave down
                                ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip link set dev "$slave" down


In lib.sh line 772:
		ip link set dev $slave master $if_name
                                ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                              ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip link set dev "$slave" master "$if_name"


In lib.sh line 773:
		ip link set dev $slave up
                                ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip link set dev "$slave" up


In lib.sh line 775:
	ip link set dev $if_name up
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$if_name" up


In lib.sh line 782:
	$TEAMD -t $if_name -k
                  ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$TEAMD -t "$if_name" -k


In lib.sh line 789:
	ip -j link show dev $if_name | jq -r '.[]["master"]'
                            ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -j link show dev "$if_name" | jq -r '.[]["master"]'


In lib.sh line 798:
	ip -j -s link show dev $if_name \
                               ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -j -s link show dev "$if_name" \


In lib.sh line 799:
		| jq '.[]["stats64"]["'$dir'"]["'$stat'"]'
                                       ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		| jq '.[]["stats64"]["'"$dir"'"]["'"$stat"'"]'


In lib.sh line 804:
	link_stats_get $1 tx packets
                       ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	link_stats_get "$1" tx packets


In lib.sh line 809:
	link_stats_get $1 rx errors
                       ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	link_stats_get "$1" rx errors


In lib.sh line 817:
	ethtool -S $dev | grep "^ *$stat:" | head -n 1 | cut -d: -f2
                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ethtool -S "$dev" | grep "^ *$stat:" | head -n 1 | cut -d: -f2


In lib.sh line 827:
	ethtool --json -S $dev --groups $grp -- --src $src | \
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ethtool --json -S "$dev" --groups "$grp" -- --src "$src" | \


In lib.sh line 828:
		jq '.[]."'"$grp"'"."'$name'"'
                                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		jq '.[]."'"$grp"'"."'"$name"'"'


In lib.sh line 856:
	cat /proc/net/dev_snmp6/$dev | grep "^$stat" | cut -f2
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	cat /proc/net/dev_snmp6/"$dev" | grep "^$stat" | cut -f2


In lib.sh line 866:
	ip -j stats show dev $if_name group offload subgroup $suite |
                             ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                             ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -j stats show dev "$if_name" group offload subgroup "$suite" |


In lib.sh line 876:
	ip -j -s -s nexthop show id $group_id |
                                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -j -s -s nexthop show id "$group_id" |


In lib.sh line 967:
	ip -j addr show dev $if_name | \
                            ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -j addr show dev "$if_name" | \


In lib.sh line 978:
	ageing_time=$(ip -j -d link show dev $bridge \
                                             ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ageing_time=$(ip -j -d link show dev "$bridge" \


In lib.sh line 988:
	SYSCTL_ORIG[$key]=$(sysctl -n $key)
                                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	SYSCTL_ORIG[$key]=$(sysctl -n "$key")


In lib.sh line 997:
	sysctl -qw $key="$value"
                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	sysctl -qw "$key"="$value"


In lib.sh line 1004:
	sysctl -qw $key="${SYSCTL_ORIG[$key]}"
                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	sysctl -qw "$key"="${SYSCTL_ORIG[$key]}"


In lib.sh line 1025:
	MTU_ORIG["$dev"]=$(ip -j link show dev $dev | jq -e '.[].mtu')
                                               ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	MTU_ORIG["$dev"]=$(ip -j link show dev "$dev" | jq -e '.[].mtu')


In lib.sh line 1026:
	ip link set dev $dev mtu $mtu
                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$dev" mtu "$mtu"


In lib.sh line 1033:
	ip link set dev $dev mtu ${MTU_ORIG["$dev"]}
                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$dev" mtu "${MTU_ORIG["$dev"]}"


In lib.sh line 1041:
		ethtool -k ${NETIFS[p$i]} \
                           ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ethtool -k "${NETIFS[p$i]}" \


In lib.sh line 1043:
		if [[ $? -ne 0 ]]; then
                      ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 1061:
	tc filter add dev $dev $direction pref 1 \
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter add dev "$dev" "$direction" pref 1 \


In lib.sh line 1063:
	    || tc filter add dev $dev $direction pref 1 \
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	    || tc filter add dev "$dev" "$direction" pref 1 \


In lib.sh line 1072:
	tc filter del dev $dev $direction pref 1 flower
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter del dev "$dev" "$direction" pref 1 flower


In lib.sh line 1083:
	tc filter $add_del dev "$tundev" ingress \
                  ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter "$add_del" dev "$tundev" ingress \


In lib.sh line 1084:
	   proto ip$vsuf pref $pref \
                   ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	   proto ip"$vsuf" pref "$pref" \


In lib.sh line 1085:
	   flower ip_proto icmp$vsuf $filter \
                               ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	   flower ip_proto icmp"$vsuf" "$filter" \


In lib.sh line 1128:
	tc filter $add_del dev "$dev" ingress \
                  ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter "$add_del" dev "$dev" ingress \


In lib.sh line 1129:
	   proto 802.1q pref $pref \
                             ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	   proto 802.1q pref "$pref" \


In lib.sh line 1130:
	   flower $filter \
                  ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	   flower "$filter" \


In lib.sh line 1159:
		__icmp_capture_add_del $add_del $((dscp + 100)) "" $dev \
                                       ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		__icmp_capture_add_del "$add_del" $((dscp + 100)) "" "$dev" \


In lib.sh line 1169:
	__dscp_capture_add_del add $dev $base
                                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__dscp_capture_add_del add "$dev" "$base"


In lib.sh line 1177:
	__dscp_capture_add_del del $dev $base
                                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__dscp_capture_add_del del "$dev" "$base"


In lib.sh line 1187:
		local t=$(tc_rule_stats_get $dev $((dscp + 100)))
                      ^-- SC2155 (warning): Declare and assign separately to avoid masking return values.
                                            ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		local t=$(tc_rule_stats_get "$dev" $((dscp + 100)))


In lib.sh line 1196:
	tc qdisc add dev $dev clsact
                         ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc qdisc add dev "$dev" clsact


In lib.sh line 1197:
	tc filter add dev $dev ingress \
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter add dev "$dev" ingress \


In lib.sh line 1243:
	diff=$(echo $weights_ratio - $packets_ratio | bc -l)
                    ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	diff=$(echo "$weights_ratio" - "$packets_ratio" | bc -l)


In lib.sh line 1256:
	ip netns exec $name bash <<-EOF
                      ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip netns exec "$name" bash <<-EOF


In lib.sh line 1273:
	vrf_name=$(master_name_get $if_name)
                                   ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	vrf_name=$(master_name_get "$if_name")


In lib.sh line 1274:
	ip vrf exec $vrf_name \
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip vrf exec "$vrf_name" \


In lib.sh line 1275:
		$PING $args $dip -c $PING_COUNT -i 0.1 \
                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                      ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                            ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		"$PING" "$args" "$dip" -c "$PING_COUNT" -i 0.1 \


In lib.sh line 1276:
		-w $PING_TIMEOUT &> /dev/null
                   ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		-w "$PING_TIMEOUT" &> /dev/null


In lib.sh line 1283:
	ping_do $1 $2
                ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
                   ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ping_do "$1" "$2"


In lib.sh line 1292:
	ping_do $1 $2
                ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
                   ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ping_do "$1" "$2"


In lib.sh line 1304:
	vrf_name=$(master_name_get $if_name)
                                   ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	vrf_name=$(master_name_get "$if_name")


In lib.sh line 1305:
	ip vrf exec $vrf_name \
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip vrf exec "$vrf_name" \


In lib.sh line 1306:
		$PING6 $args $dip -c $PING_COUNT -i 0.1 \
                ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                       ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                             ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		"$PING6" "$args" "$dip" -c "$PING_COUNT" -i 0.1 \


In lib.sh line 1307:
		-w $PING_TIMEOUT &> /dev/null
                   ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		-w "$PING_TIMEOUT" &> /dev/null


In lib.sh line 1314:
	ping6_do $1 $2
                 ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
                    ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ping6_do "$1" "$2"


In lib.sh line 1323:
	ping6_do $1 $2
                 ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
                    ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ping6_do "$1" "$2"


In lib.sh line 1339:
	bridge -j fdb show br $bridge brport $br_port1 \
                              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge -j fdb show br "$bridge" brport "$br_port1" \


In lib.sh line 1346:
	bridge link set dev $br_port1 flood off
                            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$br_port1" flood off


In lib.sh line 1348:
	ip link set $host1_if promisc on
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set "$host1_if" promisc on


In lib.sh line 1349:
	tc qdisc add dev $host1_if ingress
                         ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc qdisc add dev "$host1_if" ingress


In lib.sh line 1350:
	tc filter add dev $host1_if ingress protocol ip pref 1 handle 101 \
                          ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter add dev "$host1_if" ingress protocol ip pref 1 handle 101 \


In lib.sh line 1353:
	$MZ $host2_if -c 1 -p 64 -b $mac -t ip -q
            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$MZ "$host2_if" -c 1 -p 64 -b $mac -t ip -q


In lib.sh line 1356:
	tc -j -s filter show dev $host1_if ingress \
                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc -j -s filter show dev "$host1_if" ingress \


In lib.sh line 1361:
	$MZ $host1_if -c 1 -p 64 -a $mac -t ip -q
            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$MZ "$host1_if" -c 1 -p 64 -a $mac -t ip -q


In lib.sh line 1364:
	bridge -j fdb show br $bridge brport $br_port1 \
                              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge -j fdb show br "$bridge" brport "$br_port1" \


In lib.sh line 1368:
	$MZ $host2_if -c 1 -p 64 -b $mac -t ip -q
            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$MZ "$host2_if" -c 1 -p 64 -b $mac -t ip -q


In lib.sh line 1371:
	tc -j -s filter show dev $host1_if ingress \
                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc -j -s filter show dev "$host1_if" ingress \


In lib.sh line 1378:
	ageing_time=$(bridge_ageing_time_get $bridge)
                                             ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ageing_time=$(bridge_ageing_time_get "$bridge")


In lib.sh line 1381:
	bridge -j fdb show br $bridge brport $br_port1 \
                              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge -j fdb show br "$bridge" brport "$br_port1" \


In lib.sh line 1385:
	bridge link set dev $br_port1 learning off
                            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$br_port1" learning off


In lib.sh line 1387:
	$MZ $host1_if -c 1 -p 64 -a $mac -t ip -q
            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$MZ "$host1_if" -c 1 -p 64 -a $mac -t ip -q


In lib.sh line 1390:
	bridge -j fdb show br $bridge brport $br_port1 \
                              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge -j fdb show br "$bridge" brport "$br_port1" \


In lib.sh line 1394:
	bridge link set dev $br_port1 learning on
                            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$br_port1" learning on


In lib.sh line 1396:
	tc filter del dev $host1_if ingress protocol ip pref 1 handle 101 flower
                          ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter del dev "$host1_if" ingress protocol ip pref 1 handle 101 flower


In lib.sh line 1397:
	tc qdisc del dev $host1_if ingress
                         ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc qdisc del dev "$host1_if" ingress


In lib.sh line 1398:
	ip link set $host1_if promisc off
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set "$host1_if" promisc off


In lib.sh line 1400:
	bridge link set dev $br_port1 flood on
                            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$br_port1" flood on


In lib.sh line 1416:
	ip link set $host2_if promisc on
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set "$host2_if" promisc on


In lib.sh line 1417:
	tc qdisc add dev $host2_if ingress
                         ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc qdisc add dev "$host2_if" ingress


In lib.sh line 1418:
	tc filter add dev $host2_if ingress protocol ip pref 1 handle 101 \
                          ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter add dev "$host2_if" ingress protocol ip pref 1 handle 101 \


In lib.sh line 1419:
		flower dst_mac $mac action drop
                               ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		flower dst_mac "$mac" action drop


In lib.sh line 1421:
	$MZ $host1_if -c 1 -p 64 -b $mac -B $ip -t ip -q
            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$MZ "$host1_if" -c 1 -p 64 -b "$mac" -B "$ip" -t ip -q


In lib.sh line 1424:
	tc -j -s filter show dev $host2_if ingress \
                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc -j -s filter show dev "$host2_if" ingress \


In lib.sh line 1432:
	tc filter del dev $host2_if ingress protocol ip pref 1 handle 101 flower
                          ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter del dev "$host2_if" ingress protocol ip pref 1 handle 101 flower


In lib.sh line 1433:
	tc qdisc del dev $host2_if ingress
                         ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc qdisc del dev "$host2_if" ingress


In lib.sh line 1434:
	ip link set $host2_if promisc off
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set "$host2_if" promisc off


In lib.sh line 1449:
	bridge link set dev $br_port flood off
                            ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$br_port" flood off


In lib.sh line 1451:
	flood_test_do false $mac $ip $host1_if $host2_if
                                     ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                               ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	flood_test_do false $mac $ip "$host1_if" "$host2_if"


In lib.sh line 1454:
	bridge link set dev $br_port flood on
                            ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$br_port" flood on


In lib.sh line 1456:
	flood_test_do true $mac $ip $host1_if $host2_if
                                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                              ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	flood_test_do true $mac $ip "$host1_if" "$host2_if"


In lib.sh line 1472:
	bridge link set dev $br_port mcast_flood off
                            ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$br_port" mcast_flood off


In lib.sh line 1474:
	flood_test_do false $mac $ip $host1_if $host2_if
                                     ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                               ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	flood_test_do false $mac $ip "$host1_if" "$host2_if"


In lib.sh line 1477:
	bridge link set dev $br_port mcast_flood on
                            ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$br_port" mcast_flood on


In lib.sh line 1479:
	flood_test_do true $mac $ip $host1_if $host2_if
                                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                              ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	flood_test_do true $mac $ip "$host1_if" "$host2_if"


In lib.sh line 1492:
	flood_unicast_test $br_port $host1_if $host2_if
                           ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                              ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	flood_unicast_test "$br_port" "$host1_if" "$host2_if"


In lib.sh line 1493:
	flood_multicast_test $br_port $host1_if $host2_if
                             ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	flood_multicast_test "$br_port" "$host1_if" "$host2_if"


In lib.sh line 1506:
	$MZ $h_in -p $pktsize -A $sip -B $dip -c 0 \
            ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                     ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$MZ "$h_in" -p "$pktsize" -A "$sip" -B "$dip" -c 0 \


In lib.sh line 1507:
		-a own -b $dmac -t "$proto" -q "${mz_args[@]}" &
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		-a own -b "$dmac" -t "$proto" -q "${mz_args[@]}" &


In lib.sh line 1520:
	__start_traffic $pktsize udp "$h_in" "$sip" "$dip" "$dmac" \
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__start_traffic "$pktsize" udp "$h_in" "$sip" "$dip" "$dmac" \


In lib.sh line 1533:
	__start_traffic $pktsize tcp "$h_in" "$sip" "$dip" "$dmac" \
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__start_traffic "$pktsize" tcp "$h_in" "$sip" "$dip" "$dmac" \


In lib.sh line 1580:
	if [ -z $ns ]; then
                ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	if [ -z "$ns" ]; then


In lib.sh line 1586:
	if [ -z $SUDO_USER ] ; then
                ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	if [ -z "$SUDO_USER" ] ; then


In lib.sh line 1592:
	$ns_cmd tcpdump $TCPDUMP_EXTRA_FLAGS -e -n -Q in -i $if_name \
                        ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                            ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$ns_cmd tcpdump "$TCPDUMP_EXTRA_FLAGS" -e -n -Q in -i "$if_name" \


In lib.sh line 1593:
		-s 65535 -B 32768 $capuser -w ${capfile[$if_name]} \
                                  ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                              ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		-s 65535 -B 32768 "$capuser" -w "${capfile[$if_name]}" \


In lib.sh line 1613:
	rm ${capfile[$if_name]} ${capout[$if_name]}
           ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	rm "${capfile[$if_name]}" "${capout[$if_name]}"


In lib.sh line 1620:
	tcpdump -e -n -r ${capfile[$if_name]} 2>&1
                         ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tcpdump -e -n -r "${capfile[$if_name]}" 2>&1


In lib.sh line 1643:
	tc qdisc add dev $host2_if ingress
                         ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc qdisc add dev "$host2_if" ingress


In lib.sh line 1644:
	tc filter add dev $host2_if ingress protocol $tc_proto pref 1 handle 101 \
                          ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter add dev "$host2_if" ingress protocol $tc_proto pref 1 handle 101 \


In lib.sh line 1645:
		flower ip_proto udp dst_mac $mac action drop
                                            ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		flower ip_proto udp dst_mac "$mac" action drop


In lib.sh line 1647:
	$MZ $host1_if $mz_v6arg -c 1 -p 64 -b $mac -A $src_ip -B $ip -t udp "dp=4096,sp=2048" -q
            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                      ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$MZ "$host1_if" $mz_v6arg -c 1 -p 64 -b "$mac" -A "$src_ip" -B "$ip" -t udp "dp=4096,sp=2048" -q


In lib.sh line 1650:
	tc -j -s filter show dev $host2_if ingress \
                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc -j -s filter show dev "$host2_if" ingress \


In lib.sh line 1653:
	if [[ $? -eq 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.


In lib.sh line 1657:
	tc filter del dev $host2_if ingress protocol $tc_proto pref 1 handle 101 flower
                          ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter del dev "$host2_if" ingress protocol $tc_proto pref 1 handle 101 flower


In lib.sh line 1658:
	tc qdisc del dev $host2_if ingress
                         ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc qdisc del dev "$host2_if" ingress


In lib.sh line 1693:
		mcast_packet_test $TEST_GROUP_MAC $src $TEST_GROUP $h2 $h1
                                  ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                       ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                   ^-^ SC2154 (warning): h2 is referenced but not assigned.
                                                                   ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                       ^-^ SC2154 (warning): h1 is referenced but not assigned.
                                                                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		mcast_packet_test "$TEST_GROUP_MAC" "$src" "$TEST_GROUP" "$h2" "$h1"


In lib.sh line 1695:
		if [ $should_fwd -eq 1 ]; then
                     ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		if [ "$should_fwd" -eq 1 ]; then


In lib.sh line 1709:
	if [ $is_blocked -eq 1 ]; then
             ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	if [ "$is_blocked" -eq 1 ]; then


In lib.sh line 1734:
	local vrf_name=$(master_name_get $if_name)
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                         ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local vrf_name=$(master_name_get "$if_name")


In lib.sh line 1739:
	ip vrf exec $vrf_name \
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip vrf exec "$vrf_name" \


In lib.sh line 1740:
		mreceive -g $group -I $if_name > /dev/null 2>&1 &
                            ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		mreceive -g "$group" -I "$if_name" > /dev/null 2>&1 &


In lib.sh line 1755:
	local vrf_name=$(master_name_get $if_name)
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                         ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local vrf_name=$(master_name_get "$if_name")


In lib.sh line 1757:
	ip vrf exec $vrf_name \
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip vrf exec "$vrf_name" \


In lib.sh line 1758:
		msend -g $groups -I $if_name -c 1 > /dev/null 2>&1
                         ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		msend -g "$groups" -I "$if_name" -c 1 > /dev/null 2>&1


In lib.sh line 1799:
	tmpfile=`mktemp /var/run/nexthoptestXXX`
                ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean: 
	tmpfile=$(mktemp /var/run/nexthoptestXXX)


In lib.sh line 1800:
	mpid=`($ip monitor $mtype > $tmpfile & echo $!) 2>/dev/null`
             ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
                           ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	mpid=$(($ip monitor "$mtype" > "$tmpfile" & echo $!) 2>/dev/null)


In lib.sh line 1813:
	kill $mpid
             ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	kill "$mpid"


In lib.sh line 1814:
	local lines=`grep '^\w' $tmpfile | wc -l`
              ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                    ^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
                     ^-----------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.
                                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local lines=$(grep '^\w' "$tmpfile" | wc -l)


In lib.sh line 1815:
	test $lines -eq $el
             ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	test "$lines" -eq "$el"


In lib.sh line 1817:
	rm -rf $tmpfile
               ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	rm -rf "$tmpfile"


In lib.sh line 1831:
	local ipmout=$(start_ip_monitor stats "$ip")
              ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 1832:
	$ip stats set dev $dev ${type}_stats on
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$ip stats set dev "$dev" "${type}"_stats on


In lib.sh line 1833:
	stop_ip_monitor $ipmout 1 "${type}_stats enablement"
                        ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	stop_ip_monitor "$ipmout" 1 "${type}_stats enablement"


In lib.sh line 1836:
	local ipmout=$(start_ip_monitor stats "$ip")
              ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 1838:
	stop_ip_monitor $ipmout 1 "${type}_stats installation"
                        ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	stop_ip_monitor "$ipmout" 1 "${type}_stats installation"


In lib.sh line 1841:
	local ipmout=$(start_ip_monitor stats "$ip")
              ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 1843:
	stop_ip_monitor $ipmout 1 "${type}_stats deinstallation"
                        ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	stop_ip_monitor "$ipmout" 1 "${type}_stats deinstallation"


In lib.sh line 1846:
	local ipmout=$(start_ip_monitor stats "$ip")
              ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 1847:
	$ip stats set dev $dev ${type}_stats off
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$ip stats set dev "$dev" "${type}"_stats off


In lib.sh line 1848:
	stop_ip_monitor $ipmout 1 "${type}_stats disablement"
                        ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	stop_ip_monitor "$ipmout" 1 "${type}_stats disablement"


In lib.sh line 1857:
	printf '%02x:' ${IP//./ } |
                       ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	printf '%02x:' "${IP//./ }" |


In lib.sh line 1876:
	echo $allcol_ip | tr : '\n' |
             ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	echo "$allcol_ip" | tr : '\n' |


In lib.sh line 1894:
	printf "%04x" $u16 | sed 's/^/000/;s/^.*\(..\)\(..\)$/\1:\2/'
                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	printf "%04x" "$u16" | sed 's/^/000/;s/^.*\(..\)\(..\)$/\1:\2/'


In lib.sh line 1933:
	local ckbytes=$(u16_to_bytes $checksum)
              ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                     ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local ckbytes=$(u16_to_bytes "$checksum")


In lib.sh line 1935:
	echo "$payload" | sed "s/CHECKSUM/$ckbytes/g"
        ^-- SC2001 (style): See if you can use ${variable//search/replace} instead.


In lib.sh line 1952:
	local nsources=$(u16_to_bytes ${#sources[@]})
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 1956:
		)"22:"$(			: Type - Membership Report
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1957:
		)"00:"$(			: Reserved
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1958:
		)"CHECKSUM:"$(			: Checksum
                            ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1959:
		)"00:00:"$(			: Reserved
                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1960:
		)"00:01:"$(			: Number of Group Records
                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1961:
		)"01:"$(			: Record Type - IS_IN
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1962:
		)"00:"$(			: Aux Data Len
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1963:
		)"${nsources}:"$(		: Number of Sources
                               ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1964:
		)"$(ipv4_to_bytes $GRP):"$(	: Multicast Address
                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.

Did you mean: 
		)"$(ipv4_to_bytes "$GRP"):"$(	: Multicast Address


In lib.sh line 1966:
			ipv4_to_bytes $src
                                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			ipv4_to_bytes "$src"


In lib.sh line 1970:
	local checksum=$(payload_template_calc_checksum "$igmpv3")
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 1972:
	payload_template_expand_checksum "$igmpv3" $checksum
                                                   ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	payload_template_expand_checksum "$igmpv3" "$checksum"


In lib.sh line 1979:
	local payload=$(:
              ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 1980:
		)"17:"$(			: Type - Leave Group
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1981:
		)"00:"$(			: Max Resp Time - not meaningful
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1982:
		)"CHECKSUM:"$(			: Checksum
                            ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1983:
		)"$(ipv4_to_bytes $GRP)"$(	: Group Address
                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		)"$(ipv4_to_bytes "$GRP")"$(	: Group Address


In lib.sh line 1985:
	local checksum=$(payload_template_calc_checksum "$payload")
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 1987:
	payload_template_expand_checksum "$payload" $checksum
                                                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	payload_template_expand_checksum "$payload" "$checksum"


In lib.sh line 1998:
	local nsources=$(u16_to_bytes ${#sources[@]})
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 2001:
		)"3a:"$(			: Next Header - ICMPv6
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2002:
		)"00:"$(			: Hdr Ext Len
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2007:
		)"8f:"$(			: Type - MLDv2 Report
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2008:
		)"00:"$(			: Code
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2009:
		)"CHECKSUM:"$(			: Checksum
                            ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2010:
		)"00:00:"$(			: Reserved
                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2011:
		)"00:01:"$(			: Number of Group Records
                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2012:
		)"01:"$(			: Record Type - IS_IN
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2013:
		)"00:"$(			: Aux Data Len
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2014:
		)"${nsources}:"$(		: Number of Sources
                               ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2015:
		)"$(ipv6_to_bytes $GRP):"$(	: Multicast address
                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.

Did you mean: 
		)"$(ipv6_to_bytes "$GRP"):"$(	: Multicast address


In lib.sh line 2017:
			ipv6_to_bytes $src
                                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			ipv6_to_bytes "$src"


In lib.sh line 2022:
	local len=$(u16_to_bytes $(payload_template_nbytes $icmpv6))
              ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                 ^-- SC2046 (warning): Quote this to prevent word splitting.
                                                           ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local len=$(u16_to_bytes $(payload_template_nbytes "$icmpv6"))


In lib.sh line 2023:
	local sudohdr=$(:
              ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 2024:
		)"$(ipv6_to_bytes $SIP):"$(	: SIP
                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.

Did you mean: 
		)"$(ipv6_to_bytes "$SIP"):"$(	: SIP


In lib.sh line 2025:
		)"$(ipv6_to_bytes $GRP):"$(	: DIP is multicast address
                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.

Did you mean: 
		)"$(ipv6_to_bytes "$GRP"):"$(	: DIP is multicast address


In lib.sh line 2026:
	        )"${len}:"$(			: Upper-layer length
                          ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2029:
	local checksum=$(payload_template_calc_checksum ${sudohdr}${icmpv6})
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                                        ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                  ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local checksum=$(payload_template_calc_checksum "${sudohdr}""${icmpv6}")


In lib.sh line 2031:
	payload_template_expand_checksum "$hbh$icmpv6" $checksum
                                                       ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	payload_template_expand_checksum "$hbh$icmpv6" "$checksum"


In lib.sh line 2043:
		)"3a:"$(			: Next Header - ICMPv6
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2044:
		)"00:"$(			: Hdr Ext Len
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2049:
		)"84:"$(			: Type - MLDv1 Done
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2050:
		)"00:"$(			: Code
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2051:
		)"CHECKSUM:"$(			: Checksum
                            ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2052:
		)"00:00:"$(			: Max Resp Delay - not meaningful
                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2053:
		)"00:00:"$(			: Reserved
                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2054:
		)"$(ipv6_to_bytes $GRP):"$(	: Multicast address
                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		)"$(ipv6_to_bytes "$GRP"):"$(	: Multicast address


In lib.sh line 2057:
	local len=$(u16_to_bytes $(payload_template_nbytes $icmpv6))
              ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                 ^-- SC2046 (warning): Quote this to prevent word splitting.
                                                           ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local len=$(u16_to_bytes $(payload_template_nbytes "$icmpv6"))


In lib.sh line 2058:
	local sudohdr=$(:
              ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 2059:
		)"$(ipv6_to_bytes $SIP):"$(	: SIP
                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.

Did you mean: 
		)"$(ipv6_to_bytes "$SIP"):"$(	: SIP


In lib.sh line 2060:
		)"$(ipv6_to_bytes $GRP):"$(	: DIP is multicast address
                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.

Did you mean: 
		)"$(ipv6_to_bytes "$GRP"):"$(	: DIP is multicast address


In lib.sh line 2061:
	        )"${len}:"$(			: Upper-layer length
                          ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2064:
	local checksum=$(payload_template_calc_checksum ${sudohdr}${icmpv6})
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                                        ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                  ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local checksum=$(payload_template_calc_checksum "${sudohdr}""${icmpv6}")


In lib.sh line 2066:
	payload_template_expand_checksum "$hbh$icmpv6" $checksum
                                                       ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	payload_template_expand_checksum "$hbh$icmpv6" "$checksum"


In lib.sh line 2095:
			log_test_skip $src:$caller
                                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                           ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			log_test_skip "$src":"$caller"


In lib.sh line 2096:
			exit $EXIT_STATUS
                             ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			exit "$EXIT_STATUS"


In lib.sh line 2113:
	local mac_addr=$(mac_get $dev)
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local mac_addr=$(mac_get "$dev")


In lib.sh line 2114:
	local tmp=$(ether_addr_to_u64 $mac_addr)
              ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                      ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local tmp=$(ether_addr_to_u64 "$mac_addr")


In lib.sh line 2117:
	ip link set $dev up
                    ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set "$dev" up


In lib.sh line 2118:
	ip link add link $dev name macvlan-tmp type macvlan mode private
                         ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link add link "$dev" name macvlan-tmp type macvlan mode private


In lib.sh line 2119:
	ip link set macvlan-tmp address $(u64_to_ether_addr $((tmp + 1)))
                                        ^-- SC2046 (warning): Quote this to prevent word splitting.


In lib.sh line 2122:
	promisc=$(ip -j -d link show dev $dev | jq -r '.[].promiscuity')
                                         ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	promisc=$(ip -j -d link show dev "$dev" | jq -r '.[].promiscuity')

For more information:
  https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ...
  https://www.shellcheck.net/wiki/SC2145 -- Argument mixes string and array. ...
  https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/forwarding/lib.sh - e1a847ed4d4592e29820ec7d4d0de16c1b815b225d7508d588b8b4f99ffa9610


In lib.sh line 97:
		basename `realpath $driver_path`
                         ^---------------------^ SC2046 (warning): Quote this to prevent word splitting.
                         ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
                                   ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		basename $(realpath "$driver_path")


In lib.sh line 103:
	local ifnames=`ip -j link show | jq -r ".[].ifname"`
              ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                      ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean: 
	local ifnames=$(ip -j link show | jq -r ".[].ifname")


In lib.sh line 108:
		local driver_name=`driver_name_get $ifname`
                      ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                  ^-----------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
                                                   ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		local driver_name=$(driver_name_get "$ifname")


In lib.sh line 109:
		if [[ ! -z $driver_name && $driver_name == $NETIF_FIND_DRIVER ]]; then
                      ^-- SC2236 (style): Use -n instead of ! -z.
                                                           ^----------------^ SC2053 (warning): Quote the right-hand side of == in [[ ]] to prevent glob matching.


In lib.sh line 128:
	source "$net_forwarding_dir/forwarding.config"
               ^-- SC1091 (info): Not following: ./forwarding.config: openBinaryFile: does not exist (No such file or directory)


In lib.sh line 139:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 150:
	tc filter add dev $dev ingress protocol mpls_uc pref 1 handle 1 \
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter add dev "$dev" ingress protocol mpls_uc pref 1 handle 1 \


In lib.sh line 152:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 156:
	tc filter del dev $dev ingress protocol mpls_uc pref 1 handle 1 \
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter del dev "$dev" ingress protocol mpls_uc pref 1 handle 1 \


In lib.sh line 166:
	tc filter add dev $dev ingress protocol mpls_uc pref 1 handle 1 \
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter add dev "$dev" ingress protocol mpls_uc pref 1 handle 1 \


In lib.sh line 170:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 175:
	tc -j filter show dev $dev ingress protocol mpls_uc | jq . &> /dev/null
                              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc -j filter show dev "$dev" ingress protocol mpls_uc | jq . &> /dev/null


In lib.sh line 177:
	tc filter del dev $dev ingress protocol mpls_uc pref 1 handle 1 \
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter del dev "$dev" ingress protocol mpls_uc pref 1 handle 1 \


In lib.sh line 189:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 198:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 207:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 216:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 225:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 234:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 243:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 254:
	[ 0 -ne $(ethtool --json -S $dev --all-groups --src pmac 2>/dev/null \
                ^-- SC2046 (warning): Quote this to prevent word splitting.
                                    ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	[ 0 -ne $(ethtool --json -S "$dev" --all-groups --src pmac 2>/dev/null \


In lib.sh line 283:
	local driver_name=`driver_name_get $dev`
              ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                          ^--------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
                                           ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local driver_name=$(driver_name_get "$dev")


In lib.sh line 285:
	if [[ $driver_name != $expected ]]; then
                              ^-------^ SC2053 (warning): Quote the right-hand side of != in [[ ]] to prevent glob matching.


In lib.sh line 298:
	local version="$(msend -v)"
              ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 302:
	major=$(echo $version | cut -d. -f1)
                     ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	major=$(echo "$version" | cut -d. -f1)


In lib.sh line 304:
	if [ $major -lt 3 ]; then
             ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	if [ "$major" -lt 3 ]; then


In lib.sh line 314:
	require_command $MZ
                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	require_command "$MZ"


In lib.sh line 317:
	require_command $TEAMD
                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	require_command "$TEAMD"


In lib.sh line 350:
	echo "SKIP: Importer requires $NUM_NETIFS NETIFS, but only ${#NETIFS[@]} are defined (${NETIFS[@]})"
                                                                                              ^----------^ SC2145 (error): Argument mixes string and array. Use * or separate argument.


In lib.sh line 368:
		if [ -z ${NETIFS[p$i]} ]; then
                        ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		if [ -z "${NETIFS[p$i]}" ]; then


In lib.sh line 373:
		ip link show dev ${NETIFS[p$i]} &> /dev/null
                                 ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip link show dev "${NETIFS[p$i]}" &> /dev/null


In lib.sh line 374:
		if [[ $? -ne 0 ]]; then
                      ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 375:
			ip link add ${NETIFS[p$i]} type veth \
                                    ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			ip link add "${NETIFS[p$i]}" type veth \


In lib.sh line 376:
				peer name ${NETIFS[p$j]}
                                          ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
				peer name "${NETIFS[p$j]}"


In lib.sh line 377:
			if [[ $? -ne 0 ]]; then
                              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 391:
	*) echo "Can not create interfaces of type \'$NETIF_TYPE\'"
                ^-- SC2028 (info): echo may not expand escape sequences. Use printf.


In lib.sh line 407:
		MAC_ADDR_ORIG["$dev"]=$(ip -j link show dev $dev | jq -e '.[].address')
                                                            ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		MAC_ADDR_ORIG["$dev"]=$(ip -j link show dev "$dev" | jq -e '.[].address')


In lib.sh line 410:
		ip link set dev $dev address $new_addr
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip link set dev "$dev" address "$new_addr"


In lib.sh line 420:
		ip link set dev $dev address ${MAC_ADDR_ORIG["$dev"]}
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip link set dev "$dev" address "${MAC_ADDR_ORIG["$dev"]}"


In lib.sh line 433:
	ip link show dev ${NETIFS[p$i]} &> /dev/null
                         ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link show dev "${NETIFS[p$i]}" &> /dev/null


In lib.sh line 434:
	if [[ $? -ne 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 446:
	[[ $? != 0 ]]
           ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 454:
	for cur in ${arr[@]}; do
                   ^-------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements.


In lib.sh line 460:
	echo $max
             ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	echo "$max"


In lib.sh line 476:
	$@ | grep $addr | grep $flag "$word"
        ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.
                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$@ | grep "$addr" | grep "$flag" "$word"


In lib.sh line 499:
	setup_wait_dev_with_timeout "$dev" $INTERFACE_TIMEOUT $wait_time
                                           ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	setup_wait_dev_with_timeout "$dev" "$INTERFACE_TIMEOUT" "$wait_time"


In lib.sh line 501:
	if (($?)); then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 515:
	for ((i = 1; i <= $max_iterations; ++i)); do
                          ^-------------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.


In lib.sh line 516:
		ip link show dev $dev up \
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip link show dev "$dev" up \


In lib.sh line 518:
		if [[ $? -ne 0 ]]; then
                      ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 521:
			sleep $wait_time
                              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			sleep "$wait_time"


In lib.sh line 535:
		setup_wait_dev ${NETIFS[p$i]} 0
                               ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		setup_wait_dev "${NETIFS[p$i]}" 0


In lib.sh line 539:
	sleep $WAIT_TIME
              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	sleep "$WAIT_TIME"


In lib.sh line 547:
        slowwait $timeout ip link show dev $dev &> /dev/null
                 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                           ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        slowwait "$timeout" ip link show dev "$dev" &> /dev/null


In lib.sh line 548:
        if (( $? )); then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 551:
                exit $EXIT_STATUS
                     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
                exit "$EXIT_STATUS"


In lib.sh line 569:
	output=$(echo $output | jq -r $jq_opts "$jq_exp")
                      ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	output=$(echo "$output" | jq -r "$jq_opts" "$jq_exp")


In lib.sh line 574:
	echo $output
             ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	echo "$output"


In lib.sh line 576:
	[ ! -z "$output" ]
          ^-- SC2236 (style): Use -n instead of ! -z.


In lib.sh line 583:
		read
                ^--^ SC2162 (info): read without -r will mangle backslashes.


In lib.sh line 623:
	return ${__TB_IDS[$vrf_name]}
               ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	return "${__TB_IDS[$vrf_name]}"


In lib.sh line 631:
	__vrf_td_id_assign $vrf_name
                           ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__vrf_td_id_assign "$vrf_name"


In lib.sh line 634:
	ip link add dev $vrf_name type vrf table $tb_id
                        ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link add dev "$vrf_name" type vrf table $tb_id


In lib.sh line 644:
	__vrf_td_id_lookup $vrf_name
                           ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__vrf_td_id_lookup "$vrf_name"


In lib.sh line 649:
	ip link del dev $vrf_name
                        ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link del dev "$vrf_name"


In lib.sh line 663:
		ip address $add_del $addrstr dev $if_name
                           ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip address "$add_del" "$addrstr" dev "$if_name"


In lib.sh line 673:
	ip link set dev $if_name master $vrf_name
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$if_name" master "$vrf_name"


In lib.sh line 674:
	ip link set dev $if_name up
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$if_name" up


In lib.sh line 676:
	__addr_add_del $if_name add "${addrs[@]}"
                       ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__addr_add_del "$if_name" add "${addrs[@]}"


In lib.sh line 684:
	__addr_add_del $if_name del "${addrs[@]}"
                       ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__addr_add_del "$if_name" del "${addrs[@]}"


In lib.sh line 686:
	ip link set dev $if_name down
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$if_name" down


In lib.sh line 687:
	ip link set dev $if_name nomaster
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$if_name" nomaster


In lib.sh line 700:
	vrf_create $vrf_name
                   ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	vrf_create "$vrf_name"


In lib.sh line 701:
	ip link set dev $vrf_name up
                        ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$vrf_name" up


In lib.sh line 702:
	__simple_if_init $if_name $vrf_name "${array[@]}"
                         ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__simple_if_init "$if_name" "$vrf_name" "${array[@]}"


In lib.sh line 715:
	__simple_if_fini $if_name "${array[@]}"
                         ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__simple_if_fini "$if_name" "${array[@]}"


In lib.sh line 716:
	vrf_destroy $vrf_name
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	vrf_destroy "$vrf_name"


In lib.sh line 726:
	ip link add name $name type $type \
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link add name "$name" type "$type" \


In lib.sh line 727:
	   local $local remote $remote "$@"
                 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	   local "$local" remote "$remote" "$@"


In lib.sh line 728:
	ip link set dev $name up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$name" up


In lib.sh line 735:
	ip link del dev $name
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link del dev "$name"


In lib.sh line 746:
	ip link add name $name link $if_name type vlan id $vid
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link add name "$name" link "$if_name" type vlan id "$vid"


In lib.sh line 748:
		ip link set dev $name master $vrf
                                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip link set dev "$name" master "$vrf"


In lib.sh line 750:
	ip link set dev $name up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$name" up


In lib.sh line 751:
	__addr_add_del $name add "${ips[@]}"
                       ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__addr_add_del "$name" add "${ips[@]}"


In lib.sh line 760:
	ip link del dev $name
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link del dev "$name"


In lib.sh line 768:
	require_command $TEAMD
                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	require_command "$TEAMD"


In lib.sh line 769:
	$TEAMD -t $if_name -d -c '{"runner": {"name": "'$mode'"}}'
                  ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$TEAMD -t "$if_name" -d -c '{"runner": {"name": "'"$mode"'"}}'


In lib.sh line 771:
		ip link set dev $slave down
                                ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip link set dev "$slave" down


In lib.sh line 772:
		ip link set dev $slave master $if_name
                                ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                              ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip link set dev "$slave" master "$if_name"


In lib.sh line 773:
		ip link set dev $slave up
                                ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ip link set dev "$slave" up


In lib.sh line 775:
	ip link set dev $if_name up
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$if_name" up


In lib.sh line 782:
	$TEAMD -t $if_name -k
                  ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$TEAMD -t "$if_name" -k


In lib.sh line 789:
	ip -j link show dev $if_name | jq -r '.[]["master"]'
                            ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -j link show dev "$if_name" | jq -r '.[]["master"]'


In lib.sh line 798:
	ip -j -s link show dev $if_name \
                               ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -j -s link show dev "$if_name" \


In lib.sh line 799:
		| jq '.[]["stats64"]["'$dir'"]["'$stat'"]'
                                       ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		| jq '.[]["stats64"]["'"$dir"'"]["'"$stat"'"]'


In lib.sh line 804:
	link_stats_get $1 tx packets
                       ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	link_stats_get "$1" tx packets


In lib.sh line 809:
	link_stats_get $1 rx errors
                       ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	link_stats_get "$1" rx errors


In lib.sh line 817:
	ethtool -S $dev | grep "^ *$stat:" | head -n 1 | cut -d: -f2
                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ethtool -S "$dev" | grep "^ *$stat:" | head -n 1 | cut -d: -f2


In lib.sh line 827:
	ethtool --json -S $dev --groups $grp -- --src $src | \
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ethtool --json -S "$dev" --groups "$grp" -- --src "$src" | \


In lib.sh line 828:
		jq '.[]."'"$grp"'"."'$name'"'
                                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		jq '.[]."'"$grp"'"."'"$name"'"'


In lib.sh line 856:
	cat /proc/net/dev_snmp6/$dev | grep "^$stat" | cut -f2
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	cat /proc/net/dev_snmp6/"$dev" | grep "^$stat" | cut -f2


In lib.sh line 866:
	ip -j stats show dev $if_name group offload subgroup $suite |
                             ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                             ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -j stats show dev "$if_name" group offload subgroup "$suite" |


In lib.sh line 876:
	ip -j -s -s nexthop show id $group_id |
                                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -j -s -s nexthop show id "$group_id" |


In lib.sh line 967:
	ip -j addr show dev $if_name | \
                            ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip -j addr show dev "$if_name" | \


In lib.sh line 978:
	ageing_time=$(ip -j -d link show dev $bridge \
                                             ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ageing_time=$(ip -j -d link show dev "$bridge" \


In lib.sh line 988:
	SYSCTL_ORIG[$key]=$(sysctl -n $key)
                                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	SYSCTL_ORIG[$key]=$(sysctl -n "$key")


In lib.sh line 997:
	sysctl -qw $key="$value"
                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	sysctl -qw "$key"="$value"


In lib.sh line 1004:
	sysctl -qw $key="${SYSCTL_ORIG[$key]}"
                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	sysctl -qw "$key"="${SYSCTL_ORIG[$key]}"


In lib.sh line 1025:
	MTU_ORIG["$dev"]=$(ip -j link show dev $dev | jq -e '.[].mtu')
                                               ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	MTU_ORIG["$dev"]=$(ip -j link show dev "$dev" | jq -e '.[].mtu')


In lib.sh line 1026:
	ip link set dev $dev mtu $mtu
                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$dev" mtu "$mtu"


In lib.sh line 1033:
	ip link set dev $dev mtu ${MTU_ORIG["$dev"]}
                        ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set dev "$dev" mtu "${MTU_ORIG["$dev"]}"


In lib.sh line 1041:
		ethtool -k ${NETIFS[p$i]} \
                           ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		ethtool -k "${NETIFS[p$i]}" \


In lib.sh line 1043:
		if [[ $? -ne 0 ]]; then
                      ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In lib.sh line 1061:
	tc filter add dev $dev $direction pref 1 \
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter add dev "$dev" "$direction" pref 1 \


In lib.sh line 1063:
	    || tc filter add dev $dev $direction pref 1 \
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	    || tc filter add dev "$dev" "$direction" pref 1 \


In lib.sh line 1072:
	tc filter del dev $dev $direction pref 1 flower
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter del dev "$dev" "$direction" pref 1 flower


In lib.sh line 1083:
	tc filter $add_del dev "$tundev" ingress \
                  ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter "$add_del" dev "$tundev" ingress \


In lib.sh line 1084:
	   proto ip$vsuf pref $pref \
                   ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	   proto ip"$vsuf" pref "$pref" \


In lib.sh line 1085:
	   flower ip_proto icmp$vsuf $filter \
                               ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	   flower ip_proto icmp"$vsuf" "$filter" \


In lib.sh line 1128:
	tc filter $add_del dev "$dev" ingress \
                  ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter "$add_del" dev "$dev" ingress \


In lib.sh line 1129:
	   proto 802.1q pref $pref \
                             ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	   proto 802.1q pref "$pref" \


In lib.sh line 1130:
	   flower $filter \
                  ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	   flower "$filter" \


In lib.sh line 1159:
		__icmp_capture_add_del $add_del $((dscp + 100)) "" $dev \
                                       ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		__icmp_capture_add_del "$add_del" $((dscp + 100)) "" "$dev" \


In lib.sh line 1169:
	__dscp_capture_add_del add $dev $base
                                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__dscp_capture_add_del add "$dev" "$base"


In lib.sh line 1177:
	__dscp_capture_add_del del $dev $base
                                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__dscp_capture_add_del del "$dev" "$base"


In lib.sh line 1187:
		local t=$(tc_rule_stats_get $dev $((dscp + 100)))
                      ^-- SC2155 (warning): Declare and assign separately to avoid masking return values.
                                            ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		local t=$(tc_rule_stats_get "$dev" $((dscp + 100)))


In lib.sh line 1196:
	tc qdisc add dev $dev clsact
                         ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc qdisc add dev "$dev" clsact


In lib.sh line 1197:
	tc filter add dev $dev ingress \
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter add dev "$dev" ingress \


In lib.sh line 1243:
	diff=$(echo $weights_ratio - $packets_ratio | bc -l)
                    ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	diff=$(echo "$weights_ratio" - "$packets_ratio" | bc -l)


In lib.sh line 1256:
	ip netns exec $name bash <<-EOF
                      ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip netns exec "$name" bash <<-EOF


In lib.sh line 1273:
	vrf_name=$(master_name_get $if_name)
                                   ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	vrf_name=$(master_name_get "$if_name")


In lib.sh line 1274:
	ip vrf exec $vrf_name \
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip vrf exec "$vrf_name" \


In lib.sh line 1275:
		$PING $args $dip -c $PING_COUNT -i 0.1 \
                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                      ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                            ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		"$PING" "$args" "$dip" -c "$PING_COUNT" -i 0.1 \


In lib.sh line 1276:
		-w $PING_TIMEOUT &> /dev/null
                   ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		-w "$PING_TIMEOUT" &> /dev/null


In lib.sh line 1283:
	ping_do $1 $2
                ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
                   ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ping_do "$1" "$2"


In lib.sh line 1292:
	ping_do $1 $2
                ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
                   ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ping_do "$1" "$2"


In lib.sh line 1304:
	vrf_name=$(master_name_get $if_name)
                                   ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	vrf_name=$(master_name_get "$if_name")


In lib.sh line 1305:
	ip vrf exec $vrf_name \
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip vrf exec "$vrf_name" \


In lib.sh line 1306:
		$PING6 $args $dip -c $PING_COUNT -i 0.1 \
                ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                       ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                             ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		"$PING6" "$args" "$dip" -c "$PING_COUNT" -i 0.1 \


In lib.sh line 1307:
		-w $PING_TIMEOUT &> /dev/null
                   ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		-w "$PING_TIMEOUT" &> /dev/null


In lib.sh line 1314:
	ping6_do $1 $2
                 ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
                    ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ping6_do "$1" "$2"


In lib.sh line 1323:
	ping6_do $1 $2
                 ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
                    ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ping6_do "$1" "$2"


In lib.sh line 1339:
	bridge -j fdb show br $bridge brport $br_port1 \
                              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge -j fdb show br "$bridge" brport "$br_port1" \


In lib.sh line 1346:
	bridge link set dev $br_port1 flood off
                            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$br_port1" flood off


In lib.sh line 1348:
	ip link set $host1_if promisc on
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set "$host1_if" promisc on


In lib.sh line 1349:
	tc qdisc add dev $host1_if ingress
                         ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc qdisc add dev "$host1_if" ingress


In lib.sh line 1350:
	tc filter add dev $host1_if ingress protocol ip pref 1 handle 101 \
                          ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter add dev "$host1_if" ingress protocol ip pref 1 handle 101 \


In lib.sh line 1353:
	$MZ $host2_if -c 1 -p 64 -b $mac -t ip -q
            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$MZ "$host2_if" -c 1 -p 64 -b $mac -t ip -q


In lib.sh line 1356:
	tc -j -s filter show dev $host1_if ingress \
                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc -j -s filter show dev "$host1_if" ingress \


In lib.sh line 1361:
	$MZ $host1_if -c 1 -p 64 -a $mac -t ip -q
            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$MZ "$host1_if" -c 1 -p 64 -a $mac -t ip -q


In lib.sh line 1364:
	bridge -j fdb show br $bridge brport $br_port1 \
                              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge -j fdb show br "$bridge" brport "$br_port1" \


In lib.sh line 1368:
	$MZ $host2_if -c 1 -p 64 -b $mac -t ip -q
            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$MZ "$host2_if" -c 1 -p 64 -b $mac -t ip -q


In lib.sh line 1371:
	tc -j -s filter show dev $host1_if ingress \
                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc -j -s filter show dev "$host1_if" ingress \


In lib.sh line 1378:
	ageing_time=$(bridge_ageing_time_get $bridge)
                                             ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ageing_time=$(bridge_ageing_time_get "$bridge")


In lib.sh line 1381:
	bridge -j fdb show br $bridge brport $br_port1 \
                              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge -j fdb show br "$bridge" brport "$br_port1" \


In lib.sh line 1385:
	bridge link set dev $br_port1 learning off
                            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$br_port1" learning off


In lib.sh line 1387:
	$MZ $host1_if -c 1 -p 64 -a $mac -t ip -q
            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$MZ "$host1_if" -c 1 -p 64 -a $mac -t ip -q


In lib.sh line 1390:
	bridge -j fdb show br $bridge brport $br_port1 \
                              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge -j fdb show br "$bridge" brport "$br_port1" \


In lib.sh line 1394:
	bridge link set dev $br_port1 learning on
                            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$br_port1" learning on


In lib.sh line 1396:
	tc filter del dev $host1_if ingress protocol ip pref 1 handle 101 flower
                          ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter del dev "$host1_if" ingress protocol ip pref 1 handle 101 flower


In lib.sh line 1397:
	tc qdisc del dev $host1_if ingress
                         ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc qdisc del dev "$host1_if" ingress


In lib.sh line 1398:
	ip link set $host1_if promisc off
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set "$host1_if" promisc off


In lib.sh line 1400:
	bridge link set dev $br_port1 flood on
                            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$br_port1" flood on


In lib.sh line 1416:
	ip link set $host2_if promisc on
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set "$host2_if" promisc on


In lib.sh line 1417:
	tc qdisc add dev $host2_if ingress
                         ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc qdisc add dev "$host2_if" ingress


In lib.sh line 1418:
	tc filter add dev $host2_if ingress protocol ip pref 1 handle 101 \
                          ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter add dev "$host2_if" ingress protocol ip pref 1 handle 101 \


In lib.sh line 1419:
		flower dst_mac $mac action drop
                               ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		flower dst_mac "$mac" action drop


In lib.sh line 1421:
	$MZ $host1_if -c 1 -p 64 -b $mac -B $ip -t ip -q
            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$MZ "$host1_if" -c 1 -p 64 -b "$mac" -B "$ip" -t ip -q


In lib.sh line 1424:
	tc -j -s filter show dev $host2_if ingress \
                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc -j -s filter show dev "$host2_if" ingress \


In lib.sh line 1432:
	tc filter del dev $host2_if ingress protocol ip pref 1 handle 101 flower
                          ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter del dev "$host2_if" ingress protocol ip pref 1 handle 101 flower


In lib.sh line 1433:
	tc qdisc del dev $host2_if ingress
                         ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc qdisc del dev "$host2_if" ingress


In lib.sh line 1434:
	ip link set $host2_if promisc off
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set "$host2_if" promisc off


In lib.sh line 1449:
	bridge link set dev $br_port flood off
                            ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$br_port" flood off


In lib.sh line 1451:
	flood_test_do false $mac $ip $host1_if $host2_if
                                     ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                               ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	flood_test_do false $mac $ip "$host1_if" "$host2_if"


In lib.sh line 1454:
	bridge link set dev $br_port flood on
                            ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$br_port" flood on


In lib.sh line 1456:
	flood_test_do true $mac $ip $host1_if $host2_if
                                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                              ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	flood_test_do true $mac $ip "$host1_if" "$host2_if"


In lib.sh line 1472:
	bridge link set dev $br_port mcast_flood off
                            ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$br_port" mcast_flood off


In lib.sh line 1474:
	flood_test_do false $mac $ip $host1_if $host2_if
                                     ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                               ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	flood_test_do false $mac $ip "$host1_if" "$host2_if"


In lib.sh line 1477:
	bridge link set dev $br_port mcast_flood on
                            ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	bridge link set dev "$br_port" mcast_flood on


In lib.sh line 1479:
	flood_test_do true $mac $ip $host1_if $host2_if
                                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                              ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	flood_test_do true $mac $ip "$host1_if" "$host2_if"


In lib.sh line 1492:
	flood_unicast_test $br_port $host1_if $host2_if
                           ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                              ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	flood_unicast_test "$br_port" "$host1_if" "$host2_if"


In lib.sh line 1493:
	flood_multicast_test $br_port $host1_if $host2_if
                             ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	flood_multicast_test "$br_port" "$host1_if" "$host2_if"


In lib.sh line 1506:
	$MZ $h_in -p $pktsize -A $sip -B $dip -c 0 \
            ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                     ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$MZ "$h_in" -p "$pktsize" -A "$sip" -B "$dip" -c 0 \


In lib.sh line 1507:
		-a own -b $dmac -t "$proto" -q "${mz_args[@]}" &
                          ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		-a own -b "$dmac" -t "$proto" -q "${mz_args[@]}" &


In lib.sh line 1520:
	__start_traffic $pktsize udp "$h_in" "$sip" "$dip" "$dmac" \
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__start_traffic "$pktsize" udp "$h_in" "$sip" "$dip" "$dmac" \


In lib.sh line 1533:
	__start_traffic $pktsize tcp "$h_in" "$sip" "$dip" "$dmac" \
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	__start_traffic "$pktsize" tcp "$h_in" "$sip" "$dip" "$dmac" \


In lib.sh line 1580:
	if [ -z $ns ]; then
                ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	if [ -z "$ns" ]; then


In lib.sh line 1586:
	if [ -z $SUDO_USER ] ; then
                ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	if [ -z "$SUDO_USER" ] ; then


In lib.sh line 1592:
	$ns_cmd tcpdump $TCPDUMP_EXTRA_FLAGS -e -n -Q in -i $if_name \
                        ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                            ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$ns_cmd tcpdump "$TCPDUMP_EXTRA_FLAGS" -e -n -Q in -i "$if_name" \


In lib.sh line 1593:
		-s 65535 -B 32768 $capuser -w ${capfile[$if_name]} \
                                  ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                              ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		-s 65535 -B 32768 "$capuser" -w "${capfile[$if_name]}" \


In lib.sh line 1613:
	rm ${capfile[$if_name]} ${capout[$if_name]}
           ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	rm "${capfile[$if_name]}" "${capout[$if_name]}"


In lib.sh line 1620:
	tcpdump -e -n -r ${capfile[$if_name]} 2>&1
                         ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tcpdump -e -n -r "${capfile[$if_name]}" 2>&1


In lib.sh line 1643:
	tc qdisc add dev $host2_if ingress
                         ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc qdisc add dev "$host2_if" ingress


In lib.sh line 1644:
	tc filter add dev $host2_if ingress protocol $tc_proto pref 1 handle 101 \
                          ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter add dev "$host2_if" ingress protocol $tc_proto pref 1 handle 101 \


In lib.sh line 1645:
		flower ip_proto udp dst_mac $mac action drop
                                            ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		flower ip_proto udp dst_mac "$mac" action drop


In lib.sh line 1647:
	$MZ $host1_if $mz_v6arg -c 1 -p 64 -b $mac -A $src_ip -B $ip -t udp "dp=4096,sp=2048" -q
            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                      ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$MZ "$host1_if" $mz_v6arg -c 1 -p 64 -b "$mac" -A "$src_ip" -B "$ip" -t udp "dp=4096,sp=2048" -q


In lib.sh line 1650:
	tc -j -s filter show dev $host2_if ingress \
                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc -j -s filter show dev "$host2_if" ingress \


In lib.sh line 1653:
	if [[ $? -eq 0 ]]; then
              ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.


In lib.sh line 1657:
	tc filter del dev $host2_if ingress protocol $tc_proto pref 1 handle 101 flower
                          ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc filter del dev "$host2_if" ingress protocol $tc_proto pref 1 handle 101 flower


In lib.sh line 1658:
	tc qdisc del dev $host2_if ingress
                         ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	tc qdisc del dev "$host2_if" ingress


In lib.sh line 1693:
		mcast_packet_test $TEST_GROUP_MAC $src $TEST_GROUP $h2 $h1
                                  ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                       ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                   ^-^ SC2154 (warning): h2 is referenced but not assigned.
                                                                   ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                       ^-^ SC2154 (warning): h1 is referenced but not assigned.
                                                                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		mcast_packet_test "$TEST_GROUP_MAC" "$src" "$TEST_GROUP" "$h2" "$h1"


In lib.sh line 1695:
		if [ $should_fwd -eq 1 ]; then
                     ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		if [ "$should_fwd" -eq 1 ]; then


In lib.sh line 1709:
	if [ $is_blocked -eq 1 ]; then
             ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	if [ "$is_blocked" -eq 1 ]; then


In lib.sh line 1734:
	local vrf_name=$(master_name_get $if_name)
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                         ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local vrf_name=$(master_name_get "$if_name")


In lib.sh line 1739:
	ip vrf exec $vrf_name \
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip vrf exec "$vrf_name" \


In lib.sh line 1740:
		mreceive -g $group -I $if_name > /dev/null 2>&1 &
                            ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		mreceive -g "$group" -I "$if_name" > /dev/null 2>&1 &


In lib.sh line 1755:
	local vrf_name=$(master_name_get $if_name)
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                         ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local vrf_name=$(master_name_get "$if_name")


In lib.sh line 1757:
	ip vrf exec $vrf_name \
                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip vrf exec "$vrf_name" \


In lib.sh line 1758:
		msend -g $groups -I $if_name -c 1 > /dev/null 2>&1
                         ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		msend -g "$groups" -I "$if_name" -c 1 > /dev/null 2>&1


In lib.sh line 1812:
	tmpfile=`mktemp /var/run/nexthoptestXXX`
                ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean: 
	tmpfile=$(mktemp /var/run/nexthoptestXXX)


In lib.sh line 1813:
	mpid=`($ip monitor $mtype > $tmpfile & echo $!) 2>/dev/null`
             ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
                           ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	mpid=$(($ip monitor "$mtype" > "$tmpfile" & echo $!) 2>/dev/null)


In lib.sh line 1826:
	kill $mpid
             ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	kill "$mpid"


In lib.sh line 1827:
	local lines=`grep '^\w' $tmpfile | wc -l`
              ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                    ^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
                     ^-----------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.
                                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local lines=$(grep '^\w' "$tmpfile" | wc -l)


In lib.sh line 1828:
	test $lines -eq $el
             ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	test "$lines" -eq "$el"


In lib.sh line 1830:
	rm -rf $tmpfile
               ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	rm -rf "$tmpfile"


In lib.sh line 1844:
	local ipmout=$(start_ip_monitor stats "$ip")
              ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 1845:
	$ip stats set dev $dev ${type}_stats on
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$ip stats set dev "$dev" "${type}"_stats on


In lib.sh line 1846:
	stop_ip_monitor $ipmout 1 "${type}_stats enablement"
                        ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	stop_ip_monitor "$ipmout" 1 "${type}_stats enablement"


In lib.sh line 1849:
	local ipmout=$(start_ip_monitor stats "$ip")
              ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 1851:
	stop_ip_monitor $ipmout 1 "${type}_stats installation"
                        ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	stop_ip_monitor "$ipmout" 1 "${type}_stats installation"


In lib.sh line 1854:
	local ipmout=$(start_ip_monitor stats "$ip")
              ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 1856:
	stop_ip_monitor $ipmout 1 "${type}_stats deinstallation"
                        ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	stop_ip_monitor "$ipmout" 1 "${type}_stats deinstallation"


In lib.sh line 1859:
	local ipmout=$(start_ip_monitor stats "$ip")
              ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 1860:
	$ip stats set dev $dev ${type}_stats off
                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	$ip stats set dev "$dev" "${type}"_stats off


In lib.sh line 1861:
	stop_ip_monitor $ipmout 1 "${type}_stats disablement"
                        ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	stop_ip_monitor "$ipmout" 1 "${type}_stats disablement"


In lib.sh line 1870:
	printf '%02x:' ${IP//./ } |
                       ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	printf '%02x:' "${IP//./ }" |


In lib.sh line 1889:
	echo $allcol_ip | tr : '\n' |
             ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	echo "$allcol_ip" | tr : '\n' |


In lib.sh line 1907:
	printf "%04x" $u16 | sed 's/^/000/;s/^.*\(..\)\(..\)$/\1:\2/'
                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	printf "%04x" "$u16" | sed 's/^/000/;s/^.*\(..\)\(..\)$/\1:\2/'


In lib.sh line 1946:
	local ckbytes=$(u16_to_bytes $checksum)
              ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                     ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local ckbytes=$(u16_to_bytes "$checksum")


In lib.sh line 1948:
	echo "$payload" | sed "s/CHECKSUM/$ckbytes/g"
        ^-- SC2001 (style): See if you can use ${variable//search/replace} instead.


In lib.sh line 1965:
	local nsources=$(u16_to_bytes ${#sources[@]})
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 1969:
		)"22:"$(			: Type - Membership Report
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1970:
		)"00:"$(			: Reserved
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1971:
		)"CHECKSUM:"$(			: Checksum
                            ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1972:
		)"00:00:"$(			: Reserved
                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1973:
		)"00:01:"$(			: Number of Group Records
                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1974:
		)"01:"$(			: Record Type - IS_IN
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1975:
		)"00:"$(			: Aux Data Len
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1976:
		)"${nsources}:"$(		: Number of Sources
                               ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1977:
		)"$(ipv4_to_bytes $GRP):"$(	: Multicast Address
                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.

Did you mean: 
		)"$(ipv4_to_bytes "$GRP"):"$(	: Multicast Address


In lib.sh line 1979:
			ipv4_to_bytes $src
                                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			ipv4_to_bytes "$src"


In lib.sh line 1983:
	local checksum=$(payload_template_calc_checksum "$igmpv3")
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 1985:
	payload_template_expand_checksum "$igmpv3" $checksum
                                                   ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	payload_template_expand_checksum "$igmpv3" "$checksum"


In lib.sh line 1992:
	local payload=$(:
              ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 1993:
		)"17:"$(			: Type - Leave Group
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1994:
		)"00:"$(			: Max Resp Time - not meaningful
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1995:
		)"CHECKSUM:"$(			: Checksum
                            ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 1996:
		)"$(ipv4_to_bytes $GRP)"$(	: Group Address
                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		)"$(ipv4_to_bytes "$GRP")"$(	: Group Address


In lib.sh line 1998:
	local checksum=$(payload_template_calc_checksum "$payload")
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 2000:
	payload_template_expand_checksum "$payload" $checksum
                                                    ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	payload_template_expand_checksum "$payload" "$checksum"


In lib.sh line 2011:
	local nsources=$(u16_to_bytes ${#sources[@]})
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 2014:
		)"3a:"$(			: Next Header - ICMPv6
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2015:
		)"00:"$(			: Hdr Ext Len
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2020:
		)"8f:"$(			: Type - MLDv2 Report
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2021:
		)"00:"$(			: Code
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2022:
		)"CHECKSUM:"$(			: Checksum
                            ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2023:
		)"00:00:"$(			: Reserved
                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2024:
		)"00:01:"$(			: Number of Group Records
                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2025:
		)"01:"$(			: Record Type - IS_IN
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2026:
		)"00:"$(			: Aux Data Len
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2027:
		)"${nsources}:"$(		: Number of Sources
                               ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2028:
		)"$(ipv6_to_bytes $GRP):"$(	: Multicast address
                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.

Did you mean: 
		)"$(ipv6_to_bytes "$GRP"):"$(	: Multicast address


In lib.sh line 2030:
			ipv6_to_bytes $src
                                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			ipv6_to_bytes "$src"


In lib.sh line 2035:
	local len=$(u16_to_bytes $(payload_template_nbytes $icmpv6))
              ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                 ^-- SC2046 (warning): Quote this to prevent word splitting.
                                                           ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local len=$(u16_to_bytes $(payload_template_nbytes "$icmpv6"))


In lib.sh line 2036:
	local sudohdr=$(:
              ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 2037:
		)"$(ipv6_to_bytes $SIP):"$(	: SIP
                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.

Did you mean: 
		)"$(ipv6_to_bytes "$SIP"):"$(	: SIP


In lib.sh line 2038:
		)"$(ipv6_to_bytes $GRP):"$(	: DIP is multicast address
                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.

Did you mean: 
		)"$(ipv6_to_bytes "$GRP"):"$(	: DIP is multicast address


In lib.sh line 2039:
	        )"${len}:"$(			: Upper-layer length
                          ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2042:
	local checksum=$(payload_template_calc_checksum ${sudohdr}${icmpv6})
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                                        ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                  ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local checksum=$(payload_template_calc_checksum "${sudohdr}""${icmpv6}")


In lib.sh line 2044:
	payload_template_expand_checksum "$hbh$icmpv6" $checksum
                                                       ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	payload_template_expand_checksum "$hbh$icmpv6" "$checksum"


In lib.sh line 2056:
		)"3a:"$(			: Next Header - ICMPv6
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2057:
		)"00:"$(			: Hdr Ext Len
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2062:
		)"84:"$(			: Type - MLDv1 Done
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2063:
		)"00:"$(			: Code
                      ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2064:
		)"CHECKSUM:"$(			: Checksum
                            ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2065:
		)"00:00:"$(			: Max Resp Delay - not meaningful
                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2066:
		)"00:00:"$(			: Reserved
                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2067:
		)"$(ipv6_to_bytes $GRP):"$(	: Multicast address
                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		)"$(ipv6_to_bytes "$GRP"):"$(	: Multicast address


In lib.sh line 2070:
	local len=$(u16_to_bytes $(payload_template_nbytes $icmpv6))
              ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                 ^-- SC2046 (warning): Quote this to prevent word splitting.
                                                           ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local len=$(u16_to_bytes $(payload_template_nbytes "$icmpv6"))


In lib.sh line 2071:
	local sudohdr=$(:
              ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib.sh line 2072:
		)"$(ipv6_to_bytes $SIP):"$(	: SIP
                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.

Did you mean: 
		)"$(ipv6_to_bytes "$SIP"):"$(	: SIP


In lib.sh line 2073:
		)"$(ipv6_to_bytes $GRP):"$(	: DIP is multicast address
                                  ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.

Did you mean: 
		)"$(ipv6_to_bytes "$GRP"):"$(	: DIP is multicast address


In lib.sh line 2074:
	        )"${len}:"$(			: Upper-layer length
                          ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.


In lib.sh line 2077:
	local checksum=$(payload_template_calc_checksum ${sudohdr}${icmpv6})
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                                        ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                  ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local checksum=$(payload_template_calc_checksum "${sudohdr}""${icmpv6}")


In lib.sh line 2079:
	payload_template_expand_checksum "$hbh$icmpv6" $checksum
                                                       ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	payload_template_expand_checksum "$hbh$icmpv6" "$checksum"


In lib.sh line 2108:
			log_test_skip $src:$caller
                                      ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                           ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			log_test_skip "$src":"$caller"


In lib.sh line 2109:
			exit $EXIT_STATUS
                             ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
			exit "$EXIT_STATUS"


In lib.sh line 2126:
	local mac_addr=$(mac_get $dev)
              ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local mac_addr=$(mac_get "$dev")


In lib.sh line 2127:
	local tmp=$(ether_addr_to_u64 $mac_addr)
              ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                      ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local tmp=$(ether_addr_to_u64 "$mac_addr")


In lib.sh line 2130:
	ip link set $dev up
                    ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link set "$dev" up


In lib.sh line 2131:
	ip link add link $dev name macvlan-tmp type macvlan mode private
                         ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	ip link add link "$dev" name macvlan-tmp type macvlan mode private


In lib.sh line 2132:
	ip link set macvlan-tmp address $(u64_to_ether_addr $((tmp + 1)))
                                        ^-- SC2046 (warning): Quote this to prevent word splitting.


In lib.sh line 2135:
	promisc=$(ip -j -d link show dev $dev | jq -r '.[].promiscuity')
                                         ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	promisc=$(ip -j -d link show dev "$dev" | jq -r '.[].promiscuity')

For more information:
  https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ...
  https://www.shellcheck.net/wiki/SC2145 -- Argument mixes string and array. ...
  https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u...