ShellCheck - shell script analysis tool version: 0.10.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.7LoGhMHQku and /tmp/tmp.wyTWaBhX5a Tree base: 57f06d5378d1 ("netconsole: append msgid to sysdata") Now at: ddba5c222f24 ("selftests: netconsole: Add tests for 'msgid' feature in sysdata") ====== Checking before the patch ====== Checking tools/testing/selftests/drivers/net/netcons_sysdata.sh - d86364c1ac02befc4dcf453836e68c47679a38f9242d59dd65563a4e150d4a64 In netcons_sysdata.sh line 194: create_dynamic_target ^-------------------^ SC2119 (info): Use create_dynamic_target "$@" if function's $1 should mean script's $1. In netcons_sysdata.sh line 242: exit "${ksft_pass}" ^----------^ SC2154 (warning): ksft_pass is referenced but not assigned. For more information: https://www.shellcheck.net/wiki/SC2154 -- ksft_pass is referenced but not a... https://www.shellcheck.net/wiki/SC2119 -- Use create_dynamic_target "$@" if... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/drivers/net/netcons_sysdata.sh - d86364c1ac02befc4dcf453836e68c47679a38f9242d59dd65563a4e150d4a64 In netcons_sysdata.sh line 222: create_dynamic_target ^-------------------^ SC2119 (info): Use create_dynamic_target "$@" if function's $1 should mean script's $1. In netcons_sysdata.sh line 272: exit "${ksft_pass}" ^----------^ SC2154 (warning): ksft_pass is referenced but not assigned. For more information: https://www.shellcheck.net/wiki/SC2154 -- ksft_pass is referenced but not a... https://www.shellcheck.net/wiki/SC2119 -- Use create_dynamic_target "$@" if...