ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.12qtupoakA and /tmp/tmp.fTS9v8PNWo
Tree base:
07bd44a2b753 ("seg6: Allow End.X behavior to accept an oif")
Now at:
04e257a96423 ("selftests: seg6: Add test cases for End.X with link-local nexthop")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/srv6_end_x_next_csid_l3vpn_test.sh - 21b8652cd0a18be17cc3cabab36507a7fb38dd6981fc559d176a1ec430d13733


In srv6_end_x_next_csid_l3vpn_test.sh line 382:
			read a
                        ^--^ SC2162 (info): read without -r will mangle backslashes.


In srv6_end_x_next_csid_l3vpn_test.sh line 441:
	eval nsname=\${$(get_rtname "${rtid}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^---------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                              ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 479:
	eval nsname=\${$(get_rtname "${rt}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^-------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                            ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 482:
		eval neigh_nsname=\${$(get_rtname "${neigh}")}
                                    ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                                     ^----------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                             ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 514:
	eval nsname=\${$(get_rtname "${rt}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^-------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                            ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 568:
	printf "${out}"
               ^------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".


In srv6_end_x_next_csid_l3vpn_test.sh line 575:
	printf "${LCNODEFUNC_FMT}" "${nodeid}"
               ^-----------------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".


In srv6_end_x_next_csid_l3vpn_test.sh line 598:
	eval nsname=\${$(get_rtname "${rt}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^-------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                            ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 617:
	eval nsname=\${$(get_rtname "${rt}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^-------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                            ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 652:
	eval nsname=\${$(get_rtname "${rt}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^-------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                            ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 695:
	eval rtsrc_nsname=\${$(get_rtname "${src}")}
                            ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                             ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                   ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 696:
	eval rtdst_nsname=\${$(get_rtname "${dst}")}
                            ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                             ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                   ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 771:
	eval hsname=\${$(get_hsname "${hs}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^-------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                            ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 772:
	eval rtname=\${$(get_rtname "${rt}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^-------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                            ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 909:
	eval rtsrc_nsname=\${$(get_rtname "${rtsrc}")}
                            ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                             ^----------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                     ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 932:
	eval hssrc_nsname=\${$(get_hsname "${hssrc}")}
                            ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                             ^----------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                     ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 944:
	eval hssrc_nsname=\${$(get_hsname "${hssrc}")}
                            ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                             ^----------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                     ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 1041:
		flavors next-csid ${layout} \
                                  ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		flavors next-csid "${layout}" \


In srv6_end_x_next_csid_l3vpn_test.sh line 1055:
	eval nsname=\${$(get_rtname "${rt}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^-------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                            ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.

For more information:
  https://www.shellcheck.net/wiki/SC1083 -- This { is literal. Check expressi...
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2059 -- Don't use variables in the printf...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/srv6_end_x_next_csid_l3vpn_test.sh - 21b8652cd0a18be17cc3cabab36507a7fb38dd6981fc559d176a1ec430d13733


In srv6_end_x_next_csid_l3vpn_test.sh line 385:
			read a
                        ^--^ SC2162 (info): read without -r will mangle backslashes.


In srv6_end_x_next_csid_l3vpn_test.sh line 444:
	eval nsname=\${$(get_rtname "${rtid}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^---------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                              ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 482:
	eval nsname=\${$(get_rtname "${rt}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^-------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                            ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 485:
		eval neigh_nsname=\${$(get_rtname "${neigh}")}
                                    ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                                     ^----------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                             ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 517:
	eval nsname=\${$(get_rtname "${rt}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^-------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                            ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 574:
	printf "${out}"
               ^------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".


In srv6_end_x_next_csid_l3vpn_test.sh line 581:
	printf "${LCNODEFUNC_FMT}" "${nodeid}"
               ^-----------------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".


In srv6_end_x_next_csid_l3vpn_test.sh line 604:
	eval nsname=\${$(get_rtname "${rt}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^-------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                            ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 623:
	eval nsname=\${$(get_rtname "${rt}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^-------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                            ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 644:
	eval nsname=\${$(get_rtname "${rt}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^-------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                            ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 679:
	eval nsname=\${$(get_rtname "${rt}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^-------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                            ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 722:
	eval rtsrc_nsname=\${$(get_rtname "${src}")}
                            ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                             ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                   ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 723:
	eval rtdst_nsname=\${$(get_rtname "${dst}")}
                            ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                             ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                   ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 798:
	eval hsname=\${$(get_hsname "${hs}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^-------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                            ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 799:
	eval rtname=\${$(get_rtname "${rt}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^-------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                            ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 936:
	eval rtsrc_nsname=\${$(get_rtname "${rtsrc}")}
                            ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                             ^----------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                     ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 959:
	eval hssrc_nsname=\${$(get_hsname "${hssrc}")}
                            ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                             ^----------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                     ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 971:
	eval hssrc_nsname=\${$(get_hsname "${hssrc}")}
                            ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                             ^----------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                     ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In srv6_end_x_next_csid_l3vpn_test.sh line 1089:
		flavors next-csid ${layout} \
                                  ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		flavors next-csid "${layout}" \


In srv6_end_x_next_csid_l3vpn_test.sh line 1103:
	eval nsname=\${$(get_rtname "${rt}")}
                      ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                       ^-------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                            ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.

For more information:
  https://www.shellcheck.net/wiki/SC1083 -- This { is literal. Check expressi...
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2059 -- Don't use variables in the printf...