WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #46: new file mode 100644 WARNING: Missing a blank line after declarations #120: FILE: tools/testing/selftests/bpf/progs/security_bpf_map.c:42: + __u32 *status_ptr = bpf_map_lookup_elem(&prot_status_map, &key); + if (!status_ptr || !*status_ptr) { WARNING: braces {} are not necessary for single statement blocks #120: FILE: tools/testing/selftests/bpf/progs/security_bpf_map.c:42: + if (!status_ptr || !*status_ptr) { + return 0; + } WARNING: line length of 82 exceeds 80 columns #182: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:29: + # If BPF_DIR is a mount point this will not remove the mount point itself. WARNING: line length of 84 exceeds 80 columns #188: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:35: + # create multiple mounts. For example, a bind mount of the directory WARNING: line length of 82 exceeds 80 columns #189: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:36: + # to itself. The bind mount is created to change mount propagation WARNING: line length of 84 exceeds 80 columns #193: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:40: + while mountpoint -q "$BPF_DIR" && [ $attempt -lt $max_attempts ]; do WARNING: line length of 91 exceeds 80 columns #248: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:95: + "$bpftool_path" map update name "$map_name" key $key 0 0 0 value 0 0 0 $key WARNING: line length of 90 exceeds 80 columns #265: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:112: + if ! "$bpftool_path" map lookup "$name_cmd" "$map_name" key $key 1>/dev/null; then WARNING: line length of 101 exceeds 80 columns #286: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:133: + if "$bpftool_path" map update "$name_cmd" "$map_name" key $key value $value 2>/dev/null; then WARNING: line length of 99 exceeds 80 columns #288: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:135: + echo " Write access to $key in $map_name succeeded but should have failed" WARNING: line length of 99 exceeds 80 columns #293: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:140: + echo " Write access to $key in $map_name failed but should have succeeded" WARNING: line length of 90 exceeds 80 columns #316: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:163: + if ! "$bpftool_path" map lookup "$name_cmd" "$map_name" key $key 1>/dev/null; then WARNING: line length of 88 exceeds 80 columns #322: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:169: + if "$bpftool_path" map delete "$name_cmd" "$map_name" key $key 2>/dev/null; then WARNING: line length of 96 exceeds 80 columns #324: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:171: + echo " Deletion for $key in $map_name succeeded but should have failed" WARNING: line length of 96 exceeds 80 columns #329: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:176: + echo " Deletion for $key in $map_name failed but should have succeeded" WARNING: line length of 85 exceeds 80 columns #334: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:181: + # After deleting, check the entry existence according to the expected status. WARNING: line length of 88 exceeds 80 columns #335: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:182: + if "$bpftool_path" map lookup "$name_cmd" "$map_name" key $key 1>/dev/null; then WARNING: line length of 100 exceeds 80 columns #337: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:184: + echo " Key $key for $map_name was not deleted but should have been deleted" WARNING: line length of 100 exceeds 80 columns #342: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:189: + echo " Key $key for $map_name was deleted but should have not been deleted" WARNING: 'successfull' may be misspelled - perhaps 'successful'? #347: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:194: + # Test creation of map's deleted entry, if deletion was successfull. ^^^^^^^^^^^ WARNING: line length of 101 exceeds 80 columns #349: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:196: + if "$bpftool_path" map update "$name_cmd" "$map_name" key $key value $value 2>/dev/null; then WARNING: line length of 122 exceeds 80 columns #351: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:198: + echo " Write access to $key in $map_name succeeded after deletion attempt but should have failed" WARNING: line length of 122 exceeds 80 columns #356: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:203: + echo " Write access to $key in $map_name failed after deletion attempt but should have succeeded" WARNING: line length of 84 exceeds 80 columns #377: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:224: + "$bpftool_path" iter pin "$bpf_file" "$pin_path" map "$name_cmd" "$map_name" WARNING: line length of 83 exceeds 80 columns #410: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:257: + access_for_deletion "$name_cmd" "$map_name" "$bpftool_path" "$key_to_del" \ WARNING: line length of 83 exceeds 80 columns #460: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:307: + echo " Failed to create inner map file at $bpf_dir/$outer_map_name" WARNING: line length of 81 exceeds 80 columns #464: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:311: + "$bpftool_path" map create "$bpf_dir/$outer_map_name" type hash_of_maps \ WARNING: line length of 95 exceeds 80 columns #465: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:312: + key 4 value 4 entries 2 name "$outer_map_name" inner_map name "$inner_map_name" WARNING: line length of 83 exceeds 80 columns #467: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:314: + echo " Failed to create outer map file at $bpf_dir/$outer_map_name" WARNING: line length of 82 exceeds 80 columns #472: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:319: + "$bpftool_path" map update pinned "$bpf_dir/$outer_map_name" key 0 0 0 0 \ WARNING: line length of 85 exceeds 80 columns #479: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:326: + if "$bpftool_path" map update name "$outer_map_name" key 2 0 0 0 value name \ WARNING: line length of 84 exceeds 80 columns #481: FILE: tools/testing/selftests/bpf/test_bpftool_map.sh:328: + echo " Update for $outer_map_name succeeded but should have failed" total: 0 errors, 33 warnings, 0 checks, 461 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit a6cf500a7c08 ("selftests/bpf: Add test for bpftool access to read-only protected maps") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 33 warnings, 0 checks, 461 lines checked