========== checkpatch - FAILED ERROR: spaces required around that '=' (ctx:VxV) #67: FILE: drivers/net/netconsole.c:1685: + char *cur=opt, *delim; ^ ERROR: do not use assignment in if condition #72: FILE: drivers/net/netconsole.c:1690: + if ((delim = strchr(cur, '@')) == NULL) ERROR: do not use assignment in if condition #83: FILE: drivers/net/netconsole.c:1701: + if ((delim = strchr(cur, '/')) == NULL) ERROR: do not use assignment in if condition #97: FILE: drivers/net/netconsole.c:1715: + if ((delim = strchr(cur, ',')) == NULL) ERROR: do not use assignment in if condition #114: FILE: drivers/net/netconsole.c:1732: + if ((delim = strchr(cur, '@')) == NULL) ERROR: do not use assignment in if condition #126: FILE: drivers/net/netconsole.c:1744: + if ((delim = strchr(cur, '/')) == NULL) total: 6 errors, 0 warnings, 0 checks, 242 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 516087ac38bb ("netpoll: relocate netconsole-specific functions to netconsole module") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.