WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100755

WARNING: line length of 92 exceeds 80 columns
#139: FILE: tools/testing/selftests/net/test_neigh.sh:79:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 81 exceeds 80 columns
#140: FILE: tools/testing/selftests/net/test_neigh.sh:80:
+	run_cmd "ip -n $ns1 neigh get $ip_addr dev veth0 | grep \"extern_valid\""

WARNING: line length of 95 exceeds 80 columns
#151: FILE: tools/testing/selftests/net/test_neigh.sh:91:
+	check_fail $? "Managed to add an entry with \"extern_valid\" flag and an invalid state"

WARNING: line length of 96 exceeds 80 columns
#160: FILE: tools/testing/selftests/net/test_neigh.sh:100:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid use"

WARNING: line length of 91 exceeds 80 columns
#161: FILE: tools/testing/selftests/net/test_neigh.sh:101:
+	check_fail $? "Managed to add an entry with \"extern_valid\" flag and \"use\" flag"

WARNING: line length of 96 exceeds 80 columns
#170: FILE: tools/testing/selftests/net/test_neigh.sh:110:
+	run_cmd "ip -n $ns1 neigh replace $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 81 exceeds 80 columns
#171: FILE: tools/testing/selftests/net/test_neigh.sh:111:
+	run_cmd "ip -n $ns1 neigh get $ip_addr dev veth0 | grep \"extern_valid\""

WARNING: line length of 83 exceeds 80 columns
#173: FILE: tools/testing/selftests/net/test_neigh.sh:113:
+	run_cmd "ip -n $ns1 neigh replace $ip_addr lladdr $mac nud stale dev veth0"

WARNING: line length of 81 exceeds 80 columns
#174: FILE: tools/testing/selftests/net/test_neigh.sh:114:
+	run_cmd "ip -n $ns1 neigh get $ip_addr dev veth0 | grep \"extern_valid\""

WARNING: line length of 82 exceeds 80 columns
#175: FILE: tools/testing/selftests/net/test_neigh.sh:115:
+	check_fail $? "Did not manage to clear \"extern_valid\" flag with replace"

WARNING: line length of 92 exceeds 80 columns
#184: FILE: tools/testing/selftests/net/test_neigh.sh:124:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 104 exceeds 80 columns
#185: FILE: tools/testing/selftests/net/test_neigh.sh:125:
+	run_cmd "ip -n $ns1 neigh replace $ip_addr lladdr $mac nud stale dev veth0 extern_valid managed"

WARNING: line length of 99 exceeds 80 columns
#186: FILE: tools/testing/selftests/net/test_neigh.sh:126:
+	check_err $? "Did not manage to add \"managed\" flag to an existing \"extern_valid\" entry"

WARNING: line length of 85 exceeds 80 columns
#188: FILE: tools/testing/selftests/net/test_neigh.sh:128:
+	log_test "$af_str \"extern_valid\" flag: Replace entry with \"managed\" flag"

WARNING: line length of 92 exceeds 80 columns
#195: FILE: tools/testing/selftests/net/test_neigh.sh:135:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 83 exceeds 80 columns
#196: FILE: tools/testing/selftests/net/test_neigh.sh:136:
+	run_cmd "ip -n $ns1 neigh replace $ip_addr nud none dev veth0 extern_valid"

WARNING: line length of 99 exceeds 80 columns
#197: FILE: tools/testing/selftests/net/test_neigh.sh:137:
+	check_fail $? "Managed to replace an entry with \"extern_valid\" flag and an invalid state"

WARNING: line length of 99 exceeds 80 columns
#208: FILE: tools/testing/selftests/net/test_neigh.sh:148:
+	delay_probe=$(ip -n $ns1 -j ntable show dev veth0 name $tbl_name | jq '.[]["delay_probe"]')

WARNING: line length of 92 exceeds 80 columns
#210: FILE: tools/testing/selftests/net/test_neigh.sh:150:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 100 exceeds 80 columns
#211: FILE: tools/testing/selftests/net/test_neigh.sh:151:
+	run_cmd "ip -n $ns1 neigh replace $ip_addr lladdr $mac nud stale dev veth0 extern_valid use"

WARNING: line length of 81 exceeds 80 columns
#215: FILE: tools/testing/selftests/net/test_neigh.sh:155:
+	run_cmd "ip -n $ns1 neigh get $ip_addr dev veth0 | grep \"extern_valid\""

WARNING: line length of 107 exceeds 80 columns
#216: FILE: tools/testing/selftests/net/test_neigh.sh:156:
+	check_err $? "Entry did not maintain \"extern_valid\" flag after transition to \"reachable\" state"

WARNING: line length of 83 exceeds 80 columns
#218: FILE: tools/testing/selftests/net/test_neigh.sh:158:
+	log_test "$af_str \"extern_valid\" flag: Transition to \"reachable\" state"

WARNING: line length of 88 exceeds 80 columns
#233: FILE: tools/testing/selftests/net/test_neigh.sh:173:
+	run_cmd "tc -n $ns2 filter add dev veth1 ingress proto all matchall action drop"

WARNING: line length of 92 exceeds 80 columns
#234: FILE: tools/testing/selftests/net/test_neigh.sh:174:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 100 exceeds 80 columns
#235: FILE: tools/testing/selftests/net/test_neigh.sh:175:
+	run_cmd "ip -n $ns1 neigh replace $ip_addr lladdr $mac nud stale dev veth0 extern_valid use"

WARNING: line length of 96 exceeds 80 columns
#236: FILE: tools/testing/selftests/net/test_neigh.sh:176:
+	retrans_time=$(ip -n $ns1 -j ntable show dev veth0 name $tbl_name | jq '.[]["retrans"]')

WARNING: line length of 101 exceeds 80 columns
#237: FILE: tools/testing/selftests/net/test_neigh.sh:177:
+	ucast_probes=$(ip -n $ns1 -j ntable show dev veth0 name $tbl_name | jq '.[]["ucast_probes"]')

WARNING: line length of 97 exceeds 80 columns
#238: FILE: tools/testing/selftests/net/test_neigh.sh:178:
+	app_probes=$(ip -n $ns1 -j ntable show dev veth0 name $tbl_name | jq '.[]["app_probes"]')

WARNING: line length of 105 exceeds 80 columns
#239: FILE: tools/testing/selftests/net/test_neigh.sh:179:
+	mcast_reprobes=$(ip -n $ns1 -j ntable show dev veth0 name $tbl_name | jq '.[]["mcast_reprobes"]')

WARNING: line length of 92 exceeds 80 columns
#240: FILE: tools/testing/selftests/net/test_neigh.sh:180:
+	delay=$((delay_probe + (ucast_probes + app_probes + mcast_reprobes) * retrans_time))

WARNING: line length of 81 exceeds 80 columns
#244: FILE: tools/testing/selftests/net/test_neigh.sh:184:
+	run_cmd "ip -n $ns1 neigh get $ip_addr dev veth0 | grep \"extern_valid\""

WARNING: line length of 102 exceeds 80 columns
#245: FILE: tools/testing/selftests/net/test_neigh.sh:185:
+	check_err $? "Entry did not maintain \"extern_valid\" flag after returning to \"stale\" state"

WARNING: line length of 84 exceeds 80 columns
#246: FILE: tools/testing/selftests/net/test_neigh.sh:186:
+	probes=$(ip -n $ns1 -j -s neigh get $ip_addr dev veth0 | jq '.[]["probes"]')

WARNING: line length of 84 exceeds 80 columns
#251: FILE: tools/testing/selftests/net/test_neigh.sh:191:
+	log_test "$af_str \"extern_valid\" flag: Transition back to \"stale\" state"

WARNING: line length of 107 exceeds 80 columns
#274: FILE: tools/testing/selftests/net/test_neigh.sh:214:
+	orig_thresh1=$(ip -j ntable show name $tbl_name | jq '.[] | select(has("thresh1")) | .["thresh1"]')

WARNING: line length of 107 exceeds 80 columns
#275: FILE: tools/testing/selftests/net/test_neigh.sh:215:
+	orig_thresh2=$(ip -j ntable show name $tbl_name | jq '.[] | select(has("thresh2")) | .["thresh2"]')

WARNING: line length of 107 exceeds 80 columns
#276: FILE: tools/testing/selftests/net/test_neigh.sh:216:
+	orig_thresh3=$(ip -j ntable show name $tbl_name | jq '.[] | select(has("thresh3")) | .["thresh3"]')

WARNING: line length of 92 exceeds 80 columns
#278: FILE: tools/testing/selftests/net/test_neigh.sh:218:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 81 exceeds 80 columns
#279: FILE: tools/testing/selftests/net/test_neigh.sh:219:
+	run_cmd "ip -n $ns1 neigh add ${subnet}3 lladdr $mac nud stale dev veth0"

WARNING: line length of 129 exceeds 80 columns
#281: FILE: tools/testing/selftests/net/test_neigh.sh:221:
+	forced_gc_runs_t0=$(ip -j -s ntable show name $tbl_name | jq '.[] | select(has("forced_gc_runs")) | .["forced_gc_runs"]')

WARNING: line length of 85 exceeds 80 columns
#283: FILE: tools/testing/selftests/net/test_neigh.sh:223:
+		run_cmd "ip -n $ns1 neigh add ${subnet}$((i + 4)) nud none dev veth0"

WARNING: line length of 129 exceeds 80 columns
#285: FILE: tools/testing/selftests/net/test_neigh.sh:225:
+	forced_gc_runs_t1=$(ip -j -s ntable show name $tbl_name | jq '.[] | select(has("forced_gc_runs")) | .["forced_gc_runs"]')

WARNING: line length of 81 exceeds 80 columns
#289: FILE: tools/testing/selftests/net/test_neigh.sh:229:
+	run_cmd "ip -n $ns1 neigh get $ip_addr dev veth0 | grep \"extern_valid\""

WARNING: line length of 97 exceeds 80 columns
#290: FILE: tools/testing/selftests/net/test_neigh.sh:230:
+	check_err $? "Entry with \"extern_valid\" flag did not survive forced garbage collection"

WARNING: line length of 94 exceeds 80 columns
#292: FILE: tools/testing/selftests/net/test_neigh.sh:232:
+	check_fail $? "Entry without \"extern_valid\" flag survived forced garbage collection"

WARNING: line length of 115 exceeds 80 columns
#296: FILE: tools/testing/selftests/net/test_neigh.sh:236:
+	run_cmd "ip ntable change name $tbl_name thresh3 $orig_thresh3 thresh2 $orig_thresh2 thresh1 $orig_thresh1"

WARNING: line length of 107 exceeds 80 columns
#318: FILE: tools/testing/selftests/net/test_neigh.sh:258:
+	orig_thresh1=$(ip -j ntable show name $tbl_name | jq '.[] | select(has("thresh1")) | .["thresh1"]')

WARNING: line length of 121 exceeds 80 columns
#319: FILE: tools/testing/selftests/net/test_neigh.sh:259:
+	orig_base_reachable=$(ip -j ntable show name $tbl_name | jq '.[] | select(has("thresh1")) | .["base_reachable"]')

WARNING: line length of 81 exceeds 80 columns
#320: FILE: tools/testing/selftests/net/test_neigh.sh:260:
+	run_cmd "ip ntable change name $tbl_name thresh1 10 base_reachable 10000"

WARNING: line length of 98 exceeds 80 columns
#321: FILE: tools/testing/selftests/net/test_neigh.sh:261:
+	orig_gc_stale=$(ip -n $ns1 -j ntable show name $tbl_name dev veth0 | jq '.[]["gc_stale"]')

WARNING: line length of 81 exceeds 80 columns
#322: FILE: tools/testing/selftests/net/test_neigh.sh:262:
+	run_cmd "ip -n $ns1 ntable change name $tbl_name dev veth0 gc_stale 5000"

WARNING: line length of 92 exceeds 80 columns
#325: FILE: tools/testing/selftests/net/test_neigh.sh:265:
+	run_cmd "ip -n $ns1 neigh add $ip_addr lladdr $mac nud stale dev veth0 extern_valid"

WARNING: line length of 81 exceeds 80 columns
#326: FILE: tools/testing/selftests/net/test_neigh.sh:266:
+	run_cmd "ip -n $ns1 neigh add ${subnet}3 lladdr $mac nud stale dev veth0"

WARNING: line length of 85 exceeds 80 columns
#328: FILE: tools/testing/selftests/net/test_neigh.sh:268:
+		run_cmd "ip -n $ns1 neigh add ${subnet}$((i + 4)) nud none dev veth0"

WARNING: line length of 135 exceeds 80 columns
#330: FILE: tools/testing/selftests/net/test_neigh.sh:270:
+	periodic_gc_runs_t0=$(ip -j -s ntable show name $tbl_name | jq '.[] | select(has("periodic_gc_runs")) | .["periodic_gc_runs"]')

WARNING: line length of 135 exceeds 80 columns
#332: FILE: tools/testing/selftests/net/test_neigh.sh:272:
+	periodic_gc_runs_t1=$(ip -j -s ntable show name $tbl_name | jq '.[] | select(has("periodic_gc_runs")) | .["periodic_gc_runs"]')

WARNING: line length of 81 exceeds 80 columns
#335: FILE: tools/testing/selftests/net/test_neigh.sh:275:
+	run_cmd "ip -n $ns1 neigh get $ip_addr dev veth0 | grep \"extern_valid\""

WARNING: line length of 99 exceeds 80 columns
#336: FILE: tools/testing/selftests/net/test_neigh.sh:276:
+	check_err $? "Entry with \"extern_valid\" flag did not survive periodic garbage collection"

WARNING: line length of 96 exceeds 80 columns
#338: FILE: tools/testing/selftests/net/test_neigh.sh:278:
+	check_fail $? "Entry without \"extern_valid\" flag survived periodic garbage collection"

WARNING: line length of 91 exceeds 80 columns
#342: FILE: tools/testing/selftests/net/test_neigh.sh:282:
+	run_cmd "ip -n $ns1 ntable change name $tbl_name dev veth0 gc_stale $orig_gc_stale"

WARNING: line length of 107 exceeds 80 columns
#343: FILE: tools/testing/selftests/net/test_neigh.sh:283:
+	run_cmd "ip ntable change name $tbl_name thresh1 $orig_thresh1 base_reachable $orig_base_reachable"

total: 0 errors, 63 warnings, 0 checks, 344 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit c4e200bfa4b4 ("selftests: net: Add a selftest for externally validated neighbor entries") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 63 warnings, 0 checks, 344 lines checked