Redirect to /tmp/tmp.GNADj3X3Ix and /tmp/tmp.0pukVWHfRe Tree base: 1f5486c09225 ("net: ethtool: Don't check if RSS context exists in case of context 0") Now at: 0b6ca3d50b1d ("selftests: drv-net: rss_ctx: Add test for ntuple rules targeting default RSS context") ====== Checking before the patch ====== ************* Module rss_ctx tools/testing/selftests/drivers/net/hw/rss_ctx.py:59:0: C0301: Line too long (104/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:67:0: C0301: Line too long (110/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:256:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:260:0: C0301: Line too long (107/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:268:0: C0301: Line too long (110/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:289:0: C0301: Line too long (106/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:480:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:481:0: C0301: Line too long (106/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:484:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:572:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:624:0: C0301: Line too long (101/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:738:0: C0301: Line too long (103/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:7:0: E0611: No name 'ksft_run' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:7:0: E0611: No name 'ksft_pr' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:7:0: E0611: No name 'ksft_exit' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:8:0: E0611: No name 'ksft_eq' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:8:0: E0611: No name 'ksft_ne' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:8:0: E0611: No name 'ksft_ge' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:8:0: E0611: No name 'ksft_in' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:8:0: E0611: No name 'ksft_lt' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:8:0: E0611: No name 'ksft_true' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:8:0: E0611: No name 'ksft_raises' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:9:0: E0611: No name 'NetDrvEpEnv' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:10:0: E0611: No name 'EthtoolFamily' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:10:0: E0611: No name 'NetdevFamily' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:11:0: E0611: No name 'KsftSkipEx' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:11:0: E0611: No name 'KsftFailEx' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:12:0: E0611: No name 'rand_port' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:13:0: E0611: No name 'ethtool' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:13:0: E0611: No name 'ip' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:13:0: E0611: No name 'defer' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:13:0: E0611: No name 'GenerateTraffic' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:13:0: E0611: No name 'CmdExitFailure' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:17:21: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/hw/rss_ctx.py:33:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:37:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:47:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:54:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:62:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:76:12: R1728: Consider using a generator instead 'max(x['queue-id'] for x in data)' (consider-using-generator) tools/testing/selftests/drivers/net/hw/rss_ctx.py:203:8: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test or qstat not supported') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:256:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/hw/rss_ctx.py:268:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/hw/rss_ctx.py:289:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/hw/rss_ctx.py:185:0: R0912: Too many branches (15/12) (too-many-branches) tools/testing/selftests/drivers/net/hw/rss_ctx.py:185:0: R0915: Too many statements (70/50) (too-many-statements) tools/testing/selftests/drivers/net/hw/rss_ctx.py:342:8: W0612: Unused variable 'errors0' (unused-variable) tools/testing/selftests/drivers/net/hw/rss_ctx.py:371:45: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) tools/testing/selftests/drivers/net/hw/rss_ctx.py:374:45: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) tools/testing/selftests/drivers/net/hw/rss_ctx.py:381:12: W0707: Consider explicitly re-raising using 'except CmdExitFailure as exc' and 'raise KsftSkipEx('Unable to add any contexts') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:390:17: R1718: Consider using a set comprehension (consider-using-set-comprehension) tools/testing/selftests/drivers/net/hw/rss_ctx.py:418:17: R1718: Consider using a set comprehension (consider-using-set-comprehension) tools/testing/selftests/drivers/net/hw/rss_ctx.py:423:17: R1718: Consider using a set comprehension (consider-using-set-comprehension) tools/testing/selftests/drivers/net/hw/rss_ctx.py:447:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:500:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:504:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:508:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:512:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:535:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:608:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:657:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:726:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:742:8: W0707: Consider explicitly re-raising using 'except CmdExitFailure as exc' and 'raise KsftSkipEx('Ntuple filter with RSS and nonzero action not supported') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:750:0: C0116: Missing function or method docstring (missing-function-docstring) ----------------------------------- Your code has been rated at 6.70/10 ====== Checking the tree with the patch ====== ************* Module rss_ctx tools/testing/selftests/drivers/net/hw/rss_ctx.py:59:0: C0301: Line too long (104/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:67:0: C0301: Line too long (110/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:256:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:260:0: C0301: Line too long (107/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:268:0: C0301: Line too long (110/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:289:0: C0301: Line too long (106/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:480:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:481:0: C0301: Line too long (106/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:484:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:572:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:624:0: C0301: Line too long (101/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:738:0: C0301: Line too long (103/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:788:0: C0301: Line too long (103/100) (line-too-long) tools/testing/selftests/drivers/net/hw/rss_ctx.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:7:0: E0611: No name 'ksft_run' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:7:0: E0611: No name 'ksft_pr' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:7:0: E0611: No name 'ksft_exit' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:8:0: E0611: No name 'ksft_eq' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:8:0: E0611: No name 'ksft_ne' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:8:0: E0611: No name 'ksft_ge' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:8:0: E0611: No name 'ksft_in' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:8:0: E0611: No name 'ksft_lt' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:8:0: E0611: No name 'ksft_true' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:8:0: E0611: No name 'ksft_raises' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:9:0: E0611: No name 'NetDrvEpEnv' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:10:0: E0611: No name 'EthtoolFamily' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:10:0: E0611: No name 'NetdevFamily' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:11:0: E0611: No name 'KsftSkipEx' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:11:0: E0611: No name 'KsftFailEx' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:12:0: E0611: No name 'rand_port' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:13:0: E0611: No name 'ethtool' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:13:0: E0611: No name 'ip' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:13:0: E0611: No name 'defer' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:13:0: E0611: No name 'GenerateTraffic' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:13:0: E0611: No name 'CmdExitFailure' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hw/rss_ctx.py:17:21: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/hw/rss_ctx.py:33:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:37:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:47:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:54:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:62:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:76:12: R1728: Consider using a generator instead 'max(x['queue-id'] for x in data)' (consider-using-generator) tools/testing/selftests/drivers/net/hw/rss_ctx.py:203:8: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test or qstat not supported') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:256:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/hw/rss_ctx.py:268:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/hw/rss_ctx.py:289:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/hw/rss_ctx.py:185:0: R0912: Too many branches (15/12) (too-many-branches) tools/testing/selftests/drivers/net/hw/rss_ctx.py:185:0: R0915: Too many statements (70/50) (too-many-statements) tools/testing/selftests/drivers/net/hw/rss_ctx.py:342:8: W0612: Unused variable 'errors0' (unused-variable) tools/testing/selftests/drivers/net/hw/rss_ctx.py:371:45: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) tools/testing/selftests/drivers/net/hw/rss_ctx.py:374:45: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) tools/testing/selftests/drivers/net/hw/rss_ctx.py:381:12: W0707: Consider explicitly re-raising using 'except CmdExitFailure as exc' and 'raise KsftSkipEx('Unable to add any contexts') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:390:17: R1718: Consider using a set comprehension (consider-using-set-comprehension) tools/testing/selftests/drivers/net/hw/rss_ctx.py:418:17: R1718: Consider using a set comprehension (consider-using-set-comprehension) tools/testing/selftests/drivers/net/hw/rss_ctx.py:423:17: R1718: Consider using a set comprehension (consider-using-set-comprehension) tools/testing/selftests/drivers/net/hw/rss_ctx.py:447:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:500:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:504:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:508:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:512:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:535:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:608:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:657:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hw/rss_ctx.py:726:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:742:8: W0707: Consider explicitly re-raising using 'except CmdExitFailure as exc' and 'raise KsftSkipEx('Ntuple filter with RSS and nonzero action not supported') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:769:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise KsftSkipEx('Not enough queues for the test') from exc' (raise-missing-from) tools/testing/selftests/drivers/net/hw/rss_ctx.py:806:0: C0116: Missing function or method docstring (missing-function-docstring) ------------------------------------------------------------------ Your code has been rated at 6.83/10 (previous run: 6.70/10, +0.13)