WARNING: line length of 81 exceeds 80 columns #90: FILE: tools/testing/selftests/bpf/veristat.c:227: +#define log_errno(fmt, ...) log_errno_aux(__FILE__, __LINE__, fmt, ##__VA_ARGS__) WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #165: FILE: tools/testing/selftests/bpf/veristat.c:1331: +static int snprintf_trunc(char *str, volatile size_t size, const char *fmt, ...) WARNING: line length of 88 exceeds 80 columns #180: FILE: tools/testing/selftests/bpf/veristat.c:1346: + * Enters new cgroup namespace and mounts cgroupfs at /tmp/veristat-cgroup-mount-XXXXXX, WARNING: line length of 86 exceeds 80 columns #196: FILE: tools/testing/selftests/bpf/veristat.c:1362: + snprintf_trunc(buf, sizeof(buf), "%s/veristat-cgroup-mount-XXXXXX", P_tmpdir); CHECK: Comparison to NULL could be written "!mkdtemp" #197: FILE: tools/testing/selftests/bpf/veristat.c:1363: + if (mkdtemp(buf) == NULL) { WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #201: FILE: tools/testing/selftests/bpf/veristat.c:1367: + strcpy(env.cgroup_fs_mount, buf); WARNING: line length of 81 exceeds 80 columns #205: FILE: tools/testing/selftests/bpf/veristat.c:1371: + err = log_errno("mount none %s -t cgroup2", env.cgroup_fs_mount); WARNING: line length of 91 exceeds 80 columns #209: FILE: tools/testing/selftests/bpf/veristat.c:1375: + snprintf_trunc(buf, sizeof(buf), "%s/cgroup.subtree_control", env.cgroup_fs_mount); WARNING: line length of 92 exceeds 80 columns #255: FILE: tools/testing/selftests/bpf/veristat.c:1421: + snprintf_trunc(buf, sizeof(buf), "%s/accounting-%d", env.cgroup_fs_mount, getpid()); WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #261: FILE: tools/testing/selftests/bpf/veristat.c:1427: + strcpy(env.stat_cgroup, buf); WARNING: line length of 89 exceeds 80 columns #292: FILE: tools/testing/selftests/bpf/veristat.c:1458: + snprintf_trunc(buf, sizeof(buf), "%s/cgroup.procs", env.cgroup_fs_mount); WARNING: line length of 85 exceeds 80 columns #307: FILE: tools/testing/selftests/bpf/veristat.c:1473: +/* Current value of /tmp/veristat-cgroup-mount-XXXXXX/accounting-/memory.peak */ WARNING: line length of 90 exceeds 80 columns #326: FILE: tools/testing/selftests/bpf/veristat.c:1492: + log_errno("unrecognized %s/memory.peak format: %s", env.stat_cgroup, buf); total: 0 errors, 12 warnings, 1 checks, 357 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit a52601bc49f6 ("veristat: memory accounting for bpf programs") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 12 warnings, 1 checks, 357 lines checked