WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #52: new file mode 100644 WARNING: line length of 81 exceeds 80 columns #92: FILE: drivers/net/pse-pd/ltc4266.c:36: +#define TWO_BIT_WORD_MASK(_pid) TWO_BIT_WORD_OFFSET(0x03, (_pid)) WARNING: line length of 83 exceeds 80 columns #112: FILE: drivers/net/pse-pd/ltc4266.c:56: +#define LTC4266_REG_DISENA 0x13 /* Disconnect detect enable */ WARNING: line length of 81 exceeds 80 columns #138: FILE: drivers/net/pse-pd/ltc4266.c:82: +#define LTC4266_PORT_CLASS(_stat) FIELD_GET(GENMASK(6, 4), (_stat)) WARNING: line length of 93 exceeds 80 columns #232: FILE: drivers/net/pse-pd/ltc4266.c:176: + dev_warn(ltc4266->dev, "Failed to read register 0x%02x, err=%d\n", reg, ret); WARNING: line length of 84 exceeds 80 columns #268: FILE: drivers/net/pse-pd/ltc4266.c:212: + /* LTC4266 expects the MSB register to be read immediately following the LSB WARNING: line length of 87 exceeds 80 columns #269: FILE: drivers/net/pse-pd/ltc4266.c:213: + * register, so we need to ensure other parts aren't reading other registers in WARNING: line length of 91 exceeds 80 columns #289: FILE: drivers/net/pse-pd/ltc4266.c:233: + if (ltc4266->ports[port]->rsense == LTC4266_RSENSE_250) /* 122.07 uA/LSB */ WARNING: line length of 95 exceeds 80 columns #304: FILE: drivers/net/pse-pd/ltc4266.c:248: + /* We want to set 425 mA for class 3 and lower; 850 mA otherwise for IEEE compliance */ WARNING: line length of 126 exceeds 80 columns #308: FILE: drivers/net/pse-pd/ltc4266.c:252: + return i2c_smbus_write_byte_data(ltc4266->client, LTC4266_REG_ILIM(port), LTC4266_ILIM_AF_RSENSE_025); WARNING: line length of 118 exceeds 80 columns #309: FILE: drivers/net/pse-pd/ltc4266.c:253: + return i2c_smbus_write_byte_data(ltc4266->client, LTC4266_REG_ILIM(port), LTC4266_ILIM_AF_RSENSE_050); WARNING: line length of 118 exceeds 80 columns #314: FILE: drivers/net/pse-pd/ltc4266.c:258: + return i2c_smbus_write_byte_data(ltc4266->client, LTC4266_REG_ILIM(port), LTC4266_ILIM_AT_RSENSE_025); WARNING: line length of 110 exceeds 80 columns #316: FILE: drivers/net/pse-pd/ltc4266.c:260: + return i2c_smbus_write_byte_data(ltc4266->client, LTC4266_REG_ILIM(port), LTC4266_ILIM_AT_RSENSE_050); WARNING: line length of 90 exceeds 80 columns #331: FILE: drivers/net/pse-pd/ltc4266.c:275: + return i2c_smbus_write_byte_data(ltc4266->client, LTC4266_REG_ICUT_HP(port), val); WARNING: line length of 92 exceeds 80 columns #339: FILE: drivers/net/pse-pd/ltc4266.c:283: + return ltc4266_write_reg(ltc4266, LTC4266_REG_OPMD, TWO_BIT_WORD_OFFSET(opmd, port), WARNING: line length of 84 exceeds 80 columns #345: FILE: drivers/net/pse-pd/ltc4266.c:289: + int result = i2c_smbus_read_byte_data(ltc4266->client, LTC4266_REG_STATPWR); WARNING: line length of 94 exceeds 80 columns #350: FILE: drivers/net/pse-pd/ltc4266.c:294: + return !!((result & LTC4266_STATPWR_PG(port)) && (result & LTC4266_STATPWR_PE(port))); WARNING: line length of 87 exceeds 80 columns #360: FILE: drivers/net/pse-pd/ltc4266.c:304: + ret = i2c_smbus_write_byte_data(ltc4266->client, LTC4266_REG_RSTPB, BIT(port)); WARNING: line length of 82 exceeds 80 columns #382: FILE: drivers/net/pse-pd/ltc4266.c:326: + LTC4266_ICUT_RSENSE, LTC4266_ICUT_RSENSE); WARNING: line length of 82 exceeds 80 columns #400: FILE: drivers/net/pse-pd/ltc4266.c:344: + ret = ltc4266_write_reg(ltc4266, tlim_reg, LTC4266_TLIM_VALUE, tlim_mask); WARNING: line length of 83 exceeds 80 columns #405: FILE: drivers/net/pse-pd/ltc4266.c:349: + ret = ltc4266_write_reg(ltc4266, LTC4266_REG_DISENA, BIT(port), BIT(port)); WARNING: line length of 85 exceeds 80 columns #409: FILE: drivers/net/pse-pd/ltc4266.c:353: + /* Enable detection (low nibble), classification (high nibble) on the port */ WARNING: line length of 100 exceeds 80 columns #451: FILE: drivers/net/pse-pd/ltc4266.c:395: + return 1; /* If a port is in OPMODE SEMI, we'll just assume admin has it enabled */ WARNING: line length of 82 exceeds 80 columns #469: FILE: drivers/net/pse-pd/ltc4266.c:413: + pw_status->c33_pw_status = ETHTOOL_C33_PSE_PW_D_STATUS_DELIVERING; WARNING: line length of 86 exceeds 80 columns #475: FILE: drivers/net/pse-pd/ltc4266.c:419: + dev_warn(pcdev->dev, "Failed to read status register, err=%d\n", ret); WARNING: line length of 85 exceeds 80 columns #497: FILE: drivers/net/pse-pd/ltc4266.c:441: + ret = i2c_smbus_write_byte_data(ltc4266->client, LTC4266_REG_RSTPB, BIT(id)); WARNING: line length of 88 exceeds 80 columns #534: FILE: drivers/net/pse-pd/ltc4266.c:478: + dev_warn(ltc4266->dev, "Failed to read status register, err=%d\n", ret); WARNING: line length of 96 exceeds 80 columns #606: FILE: drivers/net/pse-pd/ltc4266.c:550: + temp = DIV_ROUND_CLOSEST_ULL((238856ULL * (uint64_t)max_mW + 22833714ULL), 10000000ULL); WARNING: line length of 117 exceeds 80 columns #608: FILE: drivers/net/pse-pd/ltc4266.c:552: + dev_dbg(ltc4266->dev, "%s passed max_mW=%d, linear regression results in %d\n", __func__, max_mW, (int)temp); WARNING: line length of 81 exceeds 80 columns #625: FILE: drivers/net/pse-pd/ltc4266.c:569: + ret = i2c_smbus_read_byte_data(ltc4266->client, LTC4266_REG_ICUT_HP(id)); WARNING: line length of 114 exceeds 80 columns #649: FILE: drivers/net/pse-pd/ltc4266.c:593: + dev_dbg(ltc4266->dev, "%s(id=%d) current limit is 0x%02X, power limit is %llu\n", __func__, id, icut, mW); WARNING: line length of 91 exceeds 80 columns #689: FILE: drivers/net/pse-pd/ltc4266.c:633: + port = devm_kzalloc(ltc4266->dev, sizeof(struct ltc4266_port), GFP_KERNEL); WARNING: line length of 91 exceeds 80 columns #697: FILE: drivers/net/pse-pd/ltc4266.c:641: + ret = of_property_read_u32(port_node, "sense-resistor-micro-ohms", &sense); WARNING: line length of 120 exceeds 80 columns #706: FILE: drivers/net/pse-pd/ltc4266.c:650: + dev_err(ltc4266->dev, "sense resistor value of %d is invalid in node %pOF\n", sense, port_node); WARNING: line length of 83 exceeds 80 columns #716: FILE: drivers/net/pse-pd/ltc4266.c:660: + dev_err(ltc4266->dev, "Failed to initialize port %d\n", i); WARNING: line length of 179 exceeds 80 columns #747: FILE: drivers/net/pse-pd/ltc4266.c:691: +#define LTC4266_INTERRUPT_SOURCES (LTC4266_INT_SUPPLY | LTC4266_INT_TSTART | LTC4266_INT_TCUT | LTC4266_INT_CLASS | LTC4266_INT_DIS | LTC4266_INT_PWRENA | LTC4266_INT_PWRGD) WARNING: line length of 114 exceeds 80 columns #751: FILE: drivers/net/pse-pd/ltc4266.c:695: + i2c_smbus_write_byte_data(client, LTC4266_REG_INTMASK, LTC4266_INTERRUPT_SOURCES); /* Unmask interrupts */ WARNING: line length of 83 exceeds 80 columns #760: FILE: drivers/net/pse-pd/ltc4266.c:704: + dev_err(&client->dev, "Failed to disable interrupts, err %d\n", r); WARNING: line length of 83 exceeds 80 columns #764: FILE: drivers/net/pse-pd/ltc4266.c:708: + i2c_smbus_write_byte_data(client, LTC4266_REG_RSTPB, LTC4266_RSTPB_PINCLR); WARNING: line length of 82 exceeds 80 columns #768: FILE: drivers/net/pse-pd/ltc4266.c:712: +static void handle_classification_event(struct ltc4266 *ltc4266, int detect_event) WARNING: line length of 97 exceeds 80 columns #778: FILE: drivers/net/pse-pd/ltc4266.c:722: + classified_ports && i < LTC4266_MAX_PORTS; classified_ports >>= 1, i++) { WARNING: line length of 83 exceeds 80 columns #786: FILE: drivers/net/pse-pd/ltc4266.c:730: + dev_warn(<c4266->client->dev, "Invalid class %d\n", ret); WARNING: line length of 93 exceeds 80 columns #789: FILE: drivers/net/pse-pd/ltc4266.c:733: + dev_dbg(ltc4266->dev, "port %d has a classification result of %d\n", i, ret); WARNING: line length of 88 exceeds 80 columns #792: FILE: drivers/net/pse-pd/ltc4266.c:736: + /* It is possible we're in this handler before the ports are non-null */ WARNING: line length of 109 exceeds 80 columns #796: FILE: drivers/net/pse-pd/ltc4266.c:740: + dev_dbg(<c4266->client->dev, "%s is powering port %d because it's enabled\n", __func__, i); WARNING: line length of 142 exceeds 80 columns #798: FILE: drivers/net/pse-pd/ltc4266.c:742: + dev_dbg(ltc4266->dev, "Port %d is using a previously set current limit of %d\n", i, ltc4266->ports[i]->current_limit); WARNING: line length of 92 exceeds 80 columns #799: FILE: drivers/net/pse-pd/ltc4266.c:743: + ltc4266_port_set_icut(ltc4266, i, ltc4266->ports[i]->current_limit); WARNING: line length of 86 exceeds 80 columns #801: FILE: drivers/net/pse-pd/ltc4266.c:745: + ltc4266_port_set_icut(ltc4266, i, ltc4266_class_to_icut[ret]); WARNING: line length of 86 exceeds 80 columns #803: FILE: drivers/net/pse-pd/ltc4266.c:747: + i2c_smbus_write_byte_data(ltc4266->client, LTC4266_REG_PWRPB, BIT(i)); WARNING: line length of 81 exceeds 80 columns #814: FILE: drivers/net/pse-pd/ltc4266.c:758: + intstat = i2c_smbus_read_byte_data(ltc4266->client, LTC4266_REG_INTSTAT); WARNING: line length of 113 exceeds 80 columns #816: FILE: drivers/net/pse-pd/ltc4266.c:760: + dev_err(<c4266->client->dev, "Error %d reading register 0x%02X", intstat, LTC4266_REG_INTSTAT); WARNING: line length of 90 exceeds 80 columns #826: FILE: drivers/net/pse-pd/ltc4266.c:770: + event = i2c_smbus_read_byte_data(ltc4266->client, LTC4266_REG_SUPEVN_COR); WARNING: line length of 83 exceeds 80 columns #834: FILE: drivers/net/pse-pd/ltc4266.c:778: + * Tstart/Tcut/Disconnect events here, except for reading the clear-on-read WARNING: line length of 82 exceeds 80 columns #837: FILE: drivers/net/pse-pd/ltc4266.c:781: + if (intstat & (LTC4266_INT_TCUT | LTC4266_INT_TSTART | LTC4266_INT_DIS)) { WARNING: line length of 81 exceeds 80 columns #838: FILE: drivers/net/pse-pd/ltc4266.c:782: + i2c_smbus_read_byte_data(ltc4266->client, LTC4266_REG_TSEVN_COR); WARNING: line length of 82 exceeds 80 columns #839: FILE: drivers/net/pse-pd/ltc4266.c:783: + i2c_smbus_read_byte_data(ltc4266->client, LTC4266_REG_FLTEVN_COR); WARNING: line length of 120 exceeds 80 columns #843: FILE: drivers/net/pse-pd/ltc4266.c:787: + handle_classification_event(ltc4266, i2c_smbus_read_byte_data(ltc4266->client, LTC4266_REG_DETEVN_COR)); WARNING: line length of 82 exceeds 80 columns #846: FILE: drivers/net/pse-pd/ltc4266.c:790: + i2c_smbus_read_byte_data(ltc4266->client, LTC4266_REG_PWREVN_COR); WARNING: line length of 105 exceeds 80 columns #860: FILE: drivers/net/pse-pd/ltc4266.c:804: + return dev_err_probe(&client->dev, -ENODEV, "I2C Bus Adapter needs I2C functionality\n"); WARNING: line length of 84 exceeds 80 columns #863: FILE: drivers/net/pse-pd/ltc4266.c:807: + * the include file. Lets make sure we've got something at address 0x2F that WARNING: line length of 108 exceeds 80 columns #868: FILE: drivers/net/pse-pd/ltc4266.c:812: + return dev_err_probe(&client->dev, -ENODEV, "Expected an ID of 0x64, saw 0x%02X\n", id_reg); WARNING: line length of 107 exceeds 80 columns #871: FILE: drivers/net/pse-pd/ltc4266.c:815: + i2c_smbus_write_byte_data(client, LTC4266_REG_RSTPB, LTC4266_RSTPB_INTCLR | LTC4266_RSTPB_RSTALL); WARNING: line length of 86 exceeds 80 columns #874: FILE: drivers/net/pse-pd/ltc4266.c:818: + * isn't, then there is typically an undervoltage lockout/something pretty bad WARNING: line length of 98 exceeds 80 columns #875: FILE: drivers/net/pse-pd/ltc4266.c:819: + * going on. We give it 50 ms here so we don't need to poll the chip and use I2C bandwidth WARNING: line length of 83 exceeds 80 columns #879: FILE: drivers/net/pse-pd/ltc4266.c:823: + /* Let's make sure the chip came out of reset (if not, the chip is probably WARNING: line length of 85 exceeds 80 columns #880: FILE: drivers/net/pse-pd/ltc4266.c:824: + * either (no longer?) present, in thermal shutdown, or watchdogged....either WARNING: line length of 128 exceeds 80 columns #885: FILE: drivers/net/pse-pd/ltc4266.c:829: + return dev_err_probe(&client->dev, -ENODEV, "Failed to re-read LTC4266 device ID after reset 0x%02X\n", id_reg); WARNING: line length of 81 exceeds 80 columns #887: FILE: drivers/net/pse-pd/ltc4266.c:831: + ltc4266 = devm_kzalloc(&client->dev, sizeof(struct ltc4266), GFP_KERNEL); WARNING: line length of 98 exceeds 80 columns #921: FILE: drivers/net/pse-pd/ltc4266.c:865: + LTC4266_MCONF_INTERRUPT_ENABLE, LTC4266_MCONF_INTERRUPT_ENABLE); WARNING: line length of 110 exceeds 80 columns #925: FILE: drivers/net/pse-pd/ltc4266.c:869: + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "ltc4266-irq", ltc4266); WARNING: line length of 93 exceeds 80 columns #927: FILE: drivers/net/pse-pd/ltc4266.c:871: + dev_err_probe(&client->dev, ret, "Failed to request threaded IRQ\n"); WARNING: line length of 83 exceeds 80 columns #940: FILE: drivers/net/pse-pd/ltc4266.c:884: + i2c_smbus_write_byte_data(client, LTC4266_REG_RSTPB, LTC4266_RSTPB_RSTALL); total: 0 errors, 72 warnings, 0 checks, 942 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 43a10f3b91b2 ("net: pse-pd: Add LTC4266 PSE controller driver") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 72 warnings, 0 checks, 942 lines checked