========== checkpatch - FAILED WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #93: FILE: tools/bpf/bpftool/common.c:1217: + strcpy(buf, key_pass); CHECK: spaces preferred around that '*' (ctx:WxV) #105: FILE: tools/bpf/bpftool/common.c:1229: + OSSL_STORE_CTX *store; ^ CHECK: spaces preferred around that '*' (ctx:WxV) #132: FILE: tools/bpf/bpftool/common.c:1256: + ENGINE *e; ^ WARNING: line length of 87 exceeds 80 columns #143: FILE: tools/bpf/bpftool/common.c:1267: + ERR(!ENGINE_ctrl_cmd_string(e, "PIN", key_pass, 0), "Set PKCS#11 PIN"); WARNING: else is not generally useful after a break or return #157: FILE: tools/bpf/bpftool/common.c:1281: + return read_private_key_pkcs11(private_key_name); + } else { ERROR: "foo* bar" should be "foo *bar" #211: FILE: tools/bpf/bpftool/common.c:1335: +BIO* generate_signature(const void *buffer, size_t length) CHECK: spaces preferred around that '*' (ctx:WxV) #216: FILE: tools/bpf/bpftool/common.c:1340: + CMS_ContentInfo *cms = NULL; ^ CHECK: spaces preferred around that '*' (ctx:WxV) #219: FILE: tools/bpf/bpftool/common.c:1343: + PKCS7 *pkcs7 = NULL; ^ WARNING: line length of 94 exceeds 80 columns #291: FILE: tools/bpf/bpftool/gen.c:508: + SHA256((const unsigned char *)opts->data, opts->data_sz, hash + SHA256_DIGEST_LENGTH); WARNING: Avoid line continuations in quoted strings #325: FILE: tools/bpf/bpftool/gen.c:812: + codegen("\ WARNING: line length of 100 exceeds 80 columns #328: FILE: tools/bpf/bpftool/gen.c:815: + static const char opts_signature[] __attribute__((__aligned__(8))) = \"\\\n\ WARNING: Prefer __aligned(8) over __attribute__((__aligned__(8))) #328: FILE: tools/bpf/bpftool/gen.c:815: + static const char opts_signature[] __attribute__((__aligned__(8))) = \"\\\n\ WARNING: Avoid line continuations in quoted strings #331: FILE: tools/bpf/bpftool/gen.c:818: + codegen("\ WARNING: unnecessary whitespace before a quoted newline #333: FILE: tools/bpf/bpftool/gen.c:820: + \"; \n\ WARNING: line length of 106 exceeds 80 columns #334: FILE: tools/bpf/bpftool/gen.c:821: + static const int opts_signature_maps[1] __attribute__((__aligned__(8))) = {0}; \n\ WARNING: Prefer __aligned(8) over __attribute__((__aligned__(8))) #334: FILE: tools/bpf/bpftool/gen.c:821: + static const int opts_signature_maps[1] __attribute__((__aligned__(8))) = {0}; \n\ WARNING: Avoid line continuations in quoted strings #336: FILE: tools/bpf/bpftool/gen.c:823: + codegen("\ WARNING: Avoid line continuations in quoted strings #355: FILE: tools/bpf/bpftool/gen.c:842: + codegen("\ WARNING: unnecessary whitespace before a quoted newline #357: FILE: tools/bpf/bpftool/gen.c:844: + \"; \n\ total: 1 errors, 14 warnings, 4 checks, 425 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 84a6ff8c11f5 ("bpftool: Allow signing of light-skeleton programs") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.