WARNING: line length of 92 exceeds 80 columns #78: FILE: include/uapi/linux/bpf.h:1593: + __u32 signature_maps_size; /* size of maps used in signature */ WARNING: line length of 91 exceeds 80 columns #158: FILE: kernel/bpf/syscall.c:2767: +static int bpf_check_signature(struct bpf_prog *prog, union bpf_attr *attr, bpfptr_t uattr, WARNING: line length of 93 exceeds 80 columns #187: FILE: kernel/bpf/syscall.c:2796: + sha256((u8 *)prog->insnsi, prog->len * sizeof(struct bpf_insn), (u8 *)&hash); WARNING: line length of 97 exceeds 80 columns #188: FILE: kernel/bpf/syscall.c:2797: + err = verify_pkcs7_signature(hash, sizeof(hash), signature, attr->signature_size, CHECK: Alignment should match open parenthesis #189: FILE: kernel/bpf/syscall.c:2798: + err = verify_pkcs7_signature(hash, sizeof(hash), signature, attr->signature_size, + VERIFY_USE_SECONDARY_KEYRING, WARNING: line length of 100 exceeds 80 columns #202: FILE: kernel/bpf/syscall.c:2811: + err = copy_from_bpfptr_offset(&map_fd, make_bpfptr(attr->fd_array, uattr.is_kernel), WARNING: line length of 99 exceeds 80 columns #225: FILE: kernel/bpf/syscall.c:2834: + make_bpfptr(attr->fd_array, uattr.is_kernel), WARNING: line length of 84 exceeds 80 columns #226: FILE: kernel/bpf/syscall.c:2835: + used_maps[n] * sizeof(map_fd), CHECK: spaces preferred around that '+' (ctx:VxV) #237: FILE: kernel/bpf/syscall.c:2846: + if (__map_get_hash(map, (u8 *)buffer+4)) { ^ WARNING: line length of 95 exceeds 80 columns #245: FILE: kernel/bpf/syscall.c:2854: + sha256((u8 *)prog->insnsi, prog->len * sizeof(struct bpf_insn), (u8 *)&buffer); CHECK: spaces preferred around that '+' (ctx:VxV) #246: FILE: kernel/bpf/syscall.c:2855: + memcpy(buffer+4, hash, sizeof(hash)); ^ WARNING: line length of 97 exceeds 80 columns #248: FILE: kernel/bpf/syscall.c:2857: + err = verify_pkcs7_signature(hash, sizeof(hash), signature, attr->signature_size, CHECK: Alignment should match open parenthesis #249: FILE: kernel/bpf/syscall.c:2858: + err = verify_pkcs7_signature(hash, sizeof(hash), signature, attr->signature_size, + VERIFY_USE_SECONDARY_KEYRING, WARNING: line length of 92 exceeds 80 columns #292: FILE: tools/include/uapi/linux/bpf.h:1593: + __u32 signature_maps_size; /* size of maps used in signature */ total: 0 errors, 10 warnings, 4 checks, 224 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 43e10be6f8c0 ("bpf: Add bpf_check_signature") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 10 warnings, 4 checks, 224 lines checked