WARNING: line length of 86 exceeds 80 columns #375: FILE: tools/testing/selftests/bpf/prog_tests/modify_return.c:52: +static void run_multi_test(__u32 input_retval, __u16 want_side_effect, __s16 want_ret) WARNING: Missing a blank line after declarations #381: FILE: tools/testing/selftests/bpf/prog_tests/modify_return.c:58: + __s16 ret; + LIBBPF_OPTS(bpf_test_run_opts, topts); WARNING: line length of 82 exceeds 80 columns #420: FILE: tools/testing/selftests/bpf/prog_tests/modify_return.c:97: + ASSERT_EQ(skel->bss->fmod_ret_result, 1, "modify_return fmod_ret_result"); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #443: new file mode 100644 WARNING: Macros with flow control statements should be avoided #520: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi_link.c:73: +#define ATTACH_PROG(name, success) \ +do { \ + link = bpf_program__attach(skel->progs.name); \ + err = libbpf_get_error(link); \ + if (!ASSERT_OK(success ? err : !err, \ + "bpf_program__attach: " #name)) \ + goto cleanup; \ + skel->links.name = err ? NULL : link; \ +} while (0) WARNING: line length of 84 exceeds 80 columns #581: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi_link.c:134: + link = bpf_program__attach_trace_multi_opts(skel->progs.fentry_cookie_test1, CHECK: No space is necessary after a cast #611: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi_link.c:164: + opts.syms = (const char **) syms; WARNING: line length of 83 exceeds 80 columns #616: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi_link.c:169: + link = bpf_program__attach_trace_multi_opts(skel->progs.fentry_multi_empty, WARNING: Missing a blank line after declarations #643: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi_link.c:196: + struct tracing_multi_override *skel; + LIBBPF_OPTS(bpf_test_run_opts, topts); WARNING: Missing a blank line after declarations #673: FILE: tools/testing/selftests/bpf/prog_tests/tracing_multi_link.c:226: + struct tracing_multi_override *skel; + LIBBPF_OPTS(bpf_test_run_opts, topts); CHECK: Please use a blank line after function/struct/union/enum declarations #794: FILE: tools/testing/selftests/bpf/progs/tracing_multi_test.c:12: +}; +struct bpf_testmod_struct_arg_2 { WARNING: externs should be avoided in .c files #813: FILE: tools/testing/selftests/bpf/progs/tracing_multi_test.c:31: +extern const void bpf_fentry_test1 __ksym; WARNING: externs should be avoided in .c files #814: FILE: tools/testing/selftests/bpf/progs/tracing_multi_test.c:32: +extern const void bpf_fentry_test2 __ksym; WARNING: externs should be avoided in .c files #815: FILE: tools/testing/selftests/bpf/progs/tracing_multi_test.c:33: +extern const void bpf_fentry_test3 __ksym; WARNING: externs should be avoided in .c files #816: FILE: tools/testing/selftests/bpf/progs/tracing_multi_test.c:34: +extern const void bpf_fentry_test4 __ksym; WARNING: externs should be avoided in .c files #817: FILE: tools/testing/selftests/bpf/progs/tracing_multi_test.c:35: +extern const void bpf_fentry_test5 __ksym; WARNING: externs should be avoided in .c files #818: FILE: tools/testing/selftests/bpf/progs/tracing_multi_test.c:36: +extern const void bpf_fentry_test6 __ksym; WARNING: externs should be avoided in .c files #819: FILE: tools/testing/selftests/bpf/progs/tracing_multi_test.c:37: +extern const void bpf_fentry_test7 __ksym; WARNING: externs should be avoided in .c files #820: FILE: tools/testing/selftests/bpf/progs/tracing_multi_test.c:38: +extern const void bpf_fentry_test8 __ksym; WARNING: line length of 108 exceeds 80 columns #895: FILE: tools/testing/selftests/bpf/progs/tracing_multi_test.c:113: +SEC("fexit.multi/bpf_testmod_test_struct_arg_1,bpf_testmod_test_struct_arg_2,bpf_testmod_test_struct_arg_3") CHECK: Macro argument '__addr' may be better as '(__addr)' to avoid precedence issues #943: FILE: tools/testing/selftests/bpf/progs/tracing_multi_test.c:161: +#define SET(__var, __addr, __cookie) ({ \ + if (((const void *) addr == __addr) && \ + (!test_cookie || (cookie == __cookie))) \ + __var = 1; \ +}) CHECK: Macro argument '__cookie' may be better as '(__cookie)' to avoid precedence issues #943: FILE: tools/testing/selftests/bpf/progs/tracing_multi_test.c:161: +#define SET(__var, __addr, __cookie) ({ \ + if (((const void *) addr == __addr) && \ + (!test_cookie || (cookie == __cookie))) \ + __var = 1; \ +}) CHECK: No space is necessary after a cast #944: FILE: tools/testing/selftests/bpf/progs/tracing_multi_test.c:162: + if (((const void *) addr == __addr) && \ CHECK: Unnecessary parentheses around 'cookie == __cookie' #944: FILE: tools/testing/selftests/bpf/progs/tracing_multi_test.c:162: + if (((const void *) addr == __addr) && \ + (!test_cookie || (cookie == __cookie))) \ WARNING: line length of 155 exceeds 80 columns #958: FILE: tools/testing/selftests/bpf/progs/tracing_multi_test.c:176: +SEC("fentry.multi/bpf_fentry_test1,bpf_fentry_test2,bpf_fentry_test3,bpf_fentry_test4,bpf_fentry_test5,bpf_fentry_test6,bpf_fentry_test7,bpf_fentry_test8") WARNING: line length of 81 exceeds 80 columns #979: FILE: tools/testing/selftests/bpf/test_kmods/bpf_testmod.c:138: +bpf_testmod_test_struct_arg_11(int a, struct bpf_testmod_struct_arg_2 b, int c) { WARNING: line length of 82 exceeds 80 columns #985: FILE: tools/testing/selftests/bpf/test_kmods/bpf_testmod.c:144: +bpf_testmod_test_struct_arg_12(int a, struct bpf_testmod_struct_arg_2 b, int *c) { WARNING: From:/Signed-off-by: email address mismatch: 'From: Menglong Dong ' != 'Signed-off-by: Menglong Dong ' total: 0 errors, 22 warnings, 6 checks, 1029 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit e6f23b569e22 ("selftests/bpf: add testcases for multi-link of tracing") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 22 warnings, 6 checks, 1029 lines checked