WARNING: line length of 96 exceeds 80 columns #60: FILE: tools/bpf/bpftool/gen.c:95: + static const char *sfxs[] = { ".data..percpu", ".data", ".rodata", ".bss", ".kconfig" }; WARNING: static const char * array should probably be static const char * const #60: FILE: tools/bpf/bpftool/gen.c:95: + static const char *sfxs[] = { ".data..percpu", ".data", ".rodata", ".bss", ".kconfig" }; WARNING: line length of 96 exceeds 80 columns #69: FILE: tools/bpf/bpftool/gen.c:120: + static const char *pfxs[] = { ".data..percpu", ".data", ".rodata", ".bss", ".kconfig" }; WARNING: static const char * array should probably be static const char * const #69: FILE: tools/bpf/bpftool/gen.c:120: + static const char *pfxs[] = { ".data..percpu", ".data", ".rodata", ".bss", ".kconfig" }; WARNING: line length of 82 exceeds 80 columns #88: FILE: tools/bpf/bpftool/gen.c:232: + printf(" }%s *%s;\n", is_percpu ? " __aligned(8)" : "", sec_ident); WARNING: line length of 84 exceeds 80 columns #118: FILE: tools/bpf/bpftool/gen.c:308: + bpf_map__is_internal_percpu(map)); ERROR: trailing statements should be on next line #140: FILE: tools/bpf/bpftool/gen.c:1443: + if (err) \n\ CHECK: spaces preferred around that '%' (ctx:OxV) #149: FILE: tools/bpf/bpftool/gen.c:1452: + printf("\tobj->%s = NULL;\n", ident); ^ WARNING: Avoid unnecessary line continuations #153: FILE: tools/bpf/bpftool/gen.c:1456: + codegen("\ WARNING: Avoid line continuations in quoted strings #153: FILE: tools/bpf/bpftool/gen.c:1456: + codegen("\ total: 1 errors, 8 warnings, 1 checks, 96 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 1eb29cc550a9 ("bpf, bpftool: Generate skeleton for global percpu data") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.