CHECK: Please don't use multiple blank lines #167: FILE: include/linux/bpf.h:2444: + WARNING: line length of 105 exceeds 80 columns #202: FILE: include/linux/bpf.h:3609: +int bpf_prog_stream_read(struct bpf_prog *prog, enum bpf_stream_id stream_id, void __user *buf, int len); WARNING: line length of 86 exceeds 80 columns #310: FILE: kernel/bpf/core.c:2888: + WARN_ON_ONCE(!llist_empty(&aux->func[i]->aux->stream[0].log)); WARNING: line length of 86 exceeds 80 columns #311: FILE: kernel/bpf/core.c:2889: + WARN_ON_ONCE(!llist_empty(&aux->func[i]->aux->stream[1].log)); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #389: new file mode 100644 WARNING: line length of 86 exceeds 80 columns #431: FILE: kernel/bpf/stream.c:38: +#define BPF_STREAM_PAGE_SZ (PAGE_SIZE - offsetofend(struct bpf_stream_page, consumed)) WARNING: line length of 83 exceeds 80 columns #491: FILE: kernel/bpf/stream.c:98: +static int bpf_stream_page_check_room(struct bpf_stream_page *stream_page, int len) WARNING: line length of 86 exceeds 80 columns #511: FILE: kernel/bpf/stream.c:118: +static struct bpf_stream_page *bpf_stream_page_from_elem(struct bpf_stream_elem *elem) WARNING: line length of 102 exceeds 80 columns #518: FILE: kernel/bpf/stream.c:125: +static struct bpf_stream_elem *bpf_stream_page_push_elem(struct bpf_stream_page *stream_page, int len) WARNING: line length of 89 exceeds 80 columns #522: FILE: kernel/bpf/stream.c:129: + stream_page->consumed += round_up(offsetof(struct bpf_stream_elem, str[len]), 8); ERROR: space required after that close brace '}' #554: FILE: kernel/bpf/stream.c:161: + const int max_len = ARRAY_SIZE((struct bpf_bprintf_buffers){}.buf); WARNING: line length of 85 exceeds 80 columns #560: FILE: kernel/bpf/stream.c:167: + * Length denotes the amount of data to be written as part of stream element, WARNING: line length of 84 exceeds 80 columns #561: FILE: kernel/bpf/stream.c:168: + * thus includes '\0' byte. We're capped by how much bpf_bprintf_buffers can WARNING: 'accomodate' may be misspelled - perhaps 'accommodate'? #562: FILE: kernel/bpf/stream.c:169: + * accomodate, therefore deny allocations that won't fit into them. ^^^^^^^^^^ WARNING: line length of 82 exceeds 80 columns #574: FILE: kernel/bpf/stream.c:181: +static int __bpf_stream_push_str(struct llist_head *log, const char *str, int len) WARNING: line length of 83 exceeds 80 columns #596: FILE: kernel/bpf/stream.c:203: + if (atomic_add_return(len, &stream->capacity) >= BPF_STREAM_MAX_CAPACITY) { WARNING: line length of 96 exceeds 80 columns #603: FILE: kernel/bpf/stream.c:210: +static void bpf_stream_release_capacity(struct bpf_stream *stream, struct bpf_stream_elem *elem) WARNING: line length of 83 exceeds 80 columns #610: FILE: kernel/bpf/stream.c:217: +static int bpf_stream_push_str(struct bpf_stream *stream, const char *str, int len) WARNING: line length of 96 exceeds 80 columns #617: FILE: kernel/bpf/stream.c:224: +static struct bpf_stream *bpf_stream_get(enum bpf_stream_id stream_id, struct bpf_prog_aux *aux) CHECK: multiple assignments should be avoided #651: FILE: kernel/bpf/stream.c:258: + stream->backlog_head = stream->backlog_tail = NULL; WARNING: void function return statements are not generally useful #677: FILE: kernel/bpf/stream.c:284: + return; +} WARNING: line length of 104 exceeds 80 columns #735: FILE: kernel/bpf/stream.c:342: +int bpf_prog_stream_read(struct bpf_prog *prog, enum bpf_stream_id stream_id, void __user *buf, int len) WARNING: line length of 119 exceeds 80 columns #751: FILE: kernel/bpf/stream.c:358: +__bpf_kfunc int bpf_stream_vprintk(int stream_id, const char *fmt__str, const void *args, u32 len__sz, void *aux__prog) WARNING: line length of 82 exceeds 80 columns #777: FILE: kernel/bpf/stream.c:384: + /* If the string was truncated, we only wrote until the size of buffer. */ WARNING: line length of 86 exceeds 80 columns #798: FILE: kernel/bpf/stream.c:405: + return register_btf_kfunc_id_set(BPF_PROG_TYPE_UNSPEC, &bpf_stream_kfunc_set); WARNING: line length of 82 exceeds 80 columns #856: FILE: kernel/bpf/stream.c:463: + /* If the string was truncated, we only wrote until the size of buffer. */ WARNING: line length of 85 exceeds 80 columns #924: FILE: kernel/bpf/syscall.c:5813: + ret = bpf_prog_stream_read(prog, attr->prog_stream_read.stream_id, buf, len); WARNING: line length of 88 exceeds 80 columns #952: FILE: kernel/bpf/verifier.c:13885: + if (meta.func_id == special_kfunc_list[KF_bpf_get_kmem_cache]) { total: 1 errors, 25 warnings, 2 checks, 834 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 5d7daeddaf9e ("bpf: Introduce BPF standard streams") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.