WARNING: line length of 97 exceeds 80 columns #51: FILE: include/linux/bpf_verifier.h:842: +#define verifier_bug_if(cond, env, fmt, args...) \ CHECK: Macro argument 'env' may be better as '(env)' to avoid precedence issues #51: FILE: include/linux/bpf_verifier.h:842: +#define verifier_bug_if(cond, env, fmt, args...) \ + ({ \ + bool __cond = unlikely(cond); \ + if (__cond) { \ + BPF_WARN_ONCE(1, "verifier bug: " fmt "(" #cond ")\n", ##args); \ + bpf_log(&env->log, "verifier bug: " fmt "(" #cond ")\n", ##args); \ + } \ + (__cond); \ + }) WARNING: line length of 97 exceeds 80 columns #52: FILE: include/linux/bpf_verifier.h:843: + ({ \ WARNING: line length of 97 exceeds 80 columns #53: FILE: include/linux/bpf_verifier.h:844: + bool __cond = unlikely(cond); \ WARNING: line length of 97 exceeds 80 columns #54: FILE: include/linux/bpf_verifier.h:845: + if (__cond) { \ WARNING: line length of 97 exceeds 80 columns #55: FILE: include/linux/bpf_verifier.h:846: + BPF_WARN_ONCE(1, "verifier bug: " fmt "(" #cond ")\n", ##args); \ WARNING: line length of 97 exceeds 80 columns #56: FILE: include/linux/bpf_verifier.h:847: + bpf_log(&env->log, "verifier bug: " fmt "(" #cond ")\n", ##args); \ WARNING: line length of 97 exceeds 80 columns #57: FILE: include/linux/bpf_verifier.h:848: + } \ WARNING: line length of 97 exceeds 80 columns #58: FILE: include/linux/bpf_verifier.h:849: + (__cond); \ WARNING: line length of 86 exceeds 80 columns #131: FILE: kernel/bpf/verifier.c:3859: + (env->cur_hist_ent->flags & insn_flags) != insn_flags, WARNING: line length of 91 exceeds 80 columns #132: FILE: kernel/bpf/verifier.c:3860: + env, "insn history: insn_idx %d cur flags %x new flags %x", WARNING: line length of 85 exceeds 80 columns #133: FILE: kernel/bpf/verifier.c:3861: + env->insn_idx, env->cur_hist_ent->flags, insn_flags); WARNING: line length of 85 exceeds 80 columns #178: FILE: kernel/bpf/verifier.c:4283: + verifier_bug(env, "scratch reg set: regs %x", WARNING: line length of 87 exceeds 80 columns #189: FILE: kernel/bpf/verifier.c:4298: + verifier_bug(env, "unexpected precise regs %x", WARNING: line length of 94 exceeds 80 columns #199: FILE: kernel/bpf/verifier.c:4306: + verifier_bug(env, "subprog leftover stack slots %llx", WARNING: line length of 87 exceeds 80 columns #217: FILE: kernel/bpf/verifier.c:4335: + verifier_bug(env, "callback leftover stack slots %llx", WARNING: line length of 88 exceeds 80 columns #228: FILE: kernel/bpf/verifier.c:4358: + verifier_bug(env, "regs not found %x", bt_reg_mask(bt)); WARNING: line length of 88 exceeds 80 columns #238: FILE: kernel/bpf/verifier.c:4376: + verifier_bug(env, "regs not found %x", bt_reg_mask(bt)); WARNING: line length of 107 exceeds 80 columns #249: FILE: kernel/bpf/verifier.c:4717: + verifier_bug(env, "backtracking func entry subprog %d reg_mask %x stack_mask %llx", WARNING: line length of 98 exceeds 80 columns #250: FILE: kernel/bpf/verifier.c:4718: + st->frame[0]->subprogno, bt_reg_mask(bt), bt_stack_mask(bt)); WARNING: line length of 96 exceeds 80 columns #259: FILE: kernel/bpf/verifier.c:4747: + if (verifier_bug_if(i >= env->prog->len, env, "backtracking idx %d", i)) WARNING: line length of 94 exceeds 80 columns #281: FILE: kernel/bpf/verifier.c:4777: + if (verifier_bug_if(i >= func->allocated_stack / BPF_REG_SIZE, WARNING: line length of 89 exceeds 80 columns #282: FILE: kernel/bpf/verifier.c:4778: + env, "stack slot %d, total slots %d", WARNING: line length of 93 exceeds 80 columns #283: FILE: kernel/bpf/verifier.c:4779: + i, func->allocated_stack / BPF_REG_SIZE)) WARNING: line length of 94 exceeds 80 columns #296: FILE: kernel/bpf/verifier.c:6553: + if (verifier_bug_if(sidx < 0, env, "No program starts at insn %d", next_insn)) WARNING: line length of 88 exceeds 80 columns #302: FILE: kernel/bpf/verifier.c:6557: + verifier_bug(env, "subprog has tail_call and async cb"); WARNING: line length of 93 exceeds 80 columns #310: FILE: kernel/bpf/verifier.c:6564: + verbose(env, "insn %d cannot call exception cb directly", i); WARNING: line length of 85 exceeds 80 columns #321: FILE: kernel/bpf/verifier.c:6664: + if (verifier_bug_if(subprog < 0, env, "No program starts at insn %d", start)) WARNING: line length of 91 exceeds 80 columns #391: FILE: kernel/bpf/verifier.c:10508: + if (verifier_bug_if(subprog < 0, env, "No program starts at insn %d", target_insn)) WARNING: line length of 92 exceeds 80 columns #412: FILE: kernel/bpf/verifier.c:19689: + if (verifier_bug_if(env->cur_state->loop_entry, env, WARNING: line length of 85 exceeds 80 columns #413: FILE: kernel/bpf/verifier.c:19690: + "broken loop detection")) WARNING: line length of 85 exceeds 80 columns #439: FILE: kernel/bpf/verifier.c:21068: + if (verifier_bug_if(subprog < 0, env, "No program starts at insn %d", WARNING: The commit message has 'syzkaller', perhaps it also needs a 'Fixes:' tag? total: 0 errors, 32 warnings, 1 checks, 383 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 8f236c78612c ("bpf: WARN_ONCE on verifier bugs") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 32 warnings, 1 checks, 383 lines checked