WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #73: new file mode 100644 WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #78: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:1: +#include WARNING: line length of 81 exceeds 80 columns #149: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:72: +#define DEFINE_FUNC_CTX_POINTER(FIELD) \ WARNING: macros should not use a trailing semicolon #149: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:72: +#define DEFINE_FUNC_CTX_POINTER(FIELD) \ +static __always_inline void * \ +ctx_ ## FIELD(const struct __sk_buff *ctx) \ +{ \ + void *ptr; \ + \ + /* LLVM may generate u32 assignments of ctx->{data,data_end,data_meta}. \ WARNING: line length of 81 exceeds 80 columns #150: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:73: +static __always_inline void * \ WARNING: line length of 81 exceeds 80 columns #151: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:74: +ctx_ ## FIELD(const struct __sk_buff *ctx) \ WARNING: line length of 81 exceeds 80 columns #152: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:75: +{ \ WARNING: line length of 81 exceeds 80 columns #153: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:76: + void *ptr; \ WARNING: line length of 81 exceeds 80 columns #154: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:77: + \ WARNING: line length of 81 exceeds 80 columns #155: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:78: + /* LLVM may generate u32 assignments of ctx->{data,data_end,data_meta}. \ WARNING: line length of 81 exceeds 80 columns #156: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:79: + * With this inline asm, LLVM loses track of the fact this field is on \ WARNING: line length of 81 exceeds 80 columns #157: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:80: + * 32 bits. \ WARNING: line length of 81 exceeds 80 columns #158: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:81: + */ \ WARNING: Avoid unnecessary line continuations #158: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:81: + */ \ WARNING: line length of 81 exceeds 80 columns #159: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:82: + asm volatile("%0 = *(u32 *)(%1 + %2)" \ WARNING: line length of 81 exceeds 80 columns #160: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:83: + : "=r"(ptr) \ WARNING: line length of 81 exceeds 80 columns #161: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:84: + : "r"(ctx), "i"(offsetof(struct __sk_buff, FIELD))); \ WARNING: line length of 81 exceeds 80 columns #162: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:85: + return ptr; \ CHECK: Please use a blank line after function/struct/union/enum declarations #164: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:87: +} +/* This defines ctx_data(). */ CHECK: Please don't use multiple blank lines #168: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:91: + + WARNING: Prefer __aligned(8) over __attribute__((aligned(8))) #183: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:106: + struct ipv6_opt_hdr opthdr __attribute__((aligned(8))); CHECK: Alignment should match open parenthesis #200: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:123: + if (bpf_skb_load_bytes(ctx, l3_off + len, &opthdr, + sizeof(opthdr)) < 0) CHECK: Please use a blank line after function/struct/union/enum declarations #223: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:146: +} +static __always_inline WARNING: Consider removing the code enclosed by this #if 0 and its #endif #249: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:172: +#if 0 CHECK: Lines should not end with a '(' #287: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:210: + asm volatile ( CHECK: Lines should not end with a '(' #300: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:223: + asm volatile ( WARNING: line length of 95 exceeds 80 columns #312: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:235: +__failure __msg("unexpected hit bpf_unreachable, due to uninit var or incorrect verification?") CHECK: Lines should not end with a '(' #315: FILE: tools/testing/selftests/bpf/progs/verifier_uninit_var.c:238: + asm volatile ( total: 0 errors, 21 warnings, 7 checks, 262 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 68c09f45130c ("selftests/bpf: Add a test with bpf_unreachable() kfunc") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 21 warnings, 7 checks, 262 lines checked