CHECK: Please use a blank line after function/struct/union/enum declarations #59: FILE: net/core/net-sysfs.c:656: } +static struct device_attribute dev_attr_phys_port_id = CHECK: Please use a blank line after function/struct/union/enum declarations #83: FILE: net/core/net-sysfs.c:678: } +static struct device_attribute dev_attr_phys_port_name = CHECK: Please use a blank line after function/struct/union/enum declarations #108: FILE: net/core/net-sysfs.c:700: } +static struct device_attribute dev_attr_phys_switch_id = WARNING: line length of 87 exceeds 80 columns #125: FILE: net/core/net-sysfs.c:717: + /* The check is also done in dev_get_phys_port_id; this helps returning WARNING: line length of 81 exceeds 80 columns #131: FILE: net/core/net-sysfs.c:723: + /* The checks are also done in dev_get_phys_port_name; this helps WARNING: line length of 81 exceeds 80 columns #138: FILE: net/core/net-sysfs.c:730: + /* The checks are also done in dev_get_phys_port_name; this helps WARNING: line length of 88 exceeds 80 columns #139: FILE: net/core/net-sysfs.c:731: + * returning early without hitting the locking section below. This works total: 0 errors, 4 warnings, 3 checks, 134 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit ff1974007790 ("net: sysfs: Implement is_visible for phys_(port_id, port_name, switch_id)") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 4 warnings, 3 checks, 134 lines checked