CHECK: Macro argument 'env' may be better as '(env)' to avoid precedence issues #51: FILE: include/linux/bpf_verifier.h:842: +#define verifier_bug(env, fmt, args...) \ + do { \ + BPF_WARN_ONCE(1, "verifier bug: " fmt, ##args); \ + bpf_log(&env->log, "verifier bug: " fmt, ##args); \ + } while (0) WARNING: Prefer using '"%s...", __func__' to using 'get_loop_entry', this function's name, in a string #92: FILE: kernel/bpf/verifier.c:1928: + verifier_bug(env, "infinite loop in get_loop_entry\n"); WARNING: line length of 84 exceeds 80 columns #118: FILE: kernel/bpf/verifier.c:3861: + (env->cur_hist_ent->flags & insn_flags) != insn_flags)) WARNING: line length of 98 exceeds 80 columns #119: FILE: kernel/bpf/verifier.c:3862: + verifier_bug(env, "insn history: insn_idx %d cur flags %x new flags %x\n", WARNING: line length of 90 exceeds 80 columns #120: FILE: kernel/bpf/verifier.c:3863: + env->insn_idx, env->cur_hist_ent->flags, insn_flags); WARNING: line length of 96 exceeds 80 columns #126: FILE: kernel/bpf/verifier.c:3866: + verifier_bug(env, "insn history: insn_idx %d linked_regs != 0: %#llx\n", WARNING: line length of 84 exceeds 80 columns #127: FILE: kernel/bpf/verifier.c:3867: + env->insn_idx, env->cur_hist_ent->linked_regs); WARNING: line length of 82 exceeds 80 columns #137: FILE: kernel/bpf/verifier.c:3990: + verifier_bug(bt->env, "subprog enter from frame %d\n", bt->frame); WARNING: line length of 85 exceeds 80 columns #157: FILE: kernel/bpf/verifier.c:4279: + verifier_bug(env, "extra insn from subprog"); WARNING: line length of 87 exceeds 80 columns #165: FILE: kernel/bpf/verifier.c:4285: + verifier_bug(env, "scratch reg set: regs %x\n", WARNING: line length of 89 exceeds 80 columns #176: FILE: kernel/bpf/verifier.c:4300: + verifier_bug(env, "unexpected precise regs %x\n", WARNING: line length of 96 exceeds 80 columns #186: FILE: kernel/bpf/verifier.c:4308: + verifier_bug(env, "subprog leftover stack slots %llx\n", WARNING: line length of 81 exceeds 80 columns #197: FILE: kernel/bpf/verifier.c:4332: + verifier_bug(env, "unexpected precise regs %x\n", WARNING: line length of 89 exceeds 80 columns #204: FILE: kernel/bpf/verifier.c:4337: + verifier_bug(env, "callback leftover stack slots %llx\n", WARNING: line length of 90 exceeds 80 columns #215: FILE: kernel/bpf/verifier.c:4360: + verifier_bug(env, "regs not found %x\n", bt_reg_mask(bt)); WARNING: line length of 90 exceeds 80 columns #225: FILE: kernel/bpf/verifier.c:4378: + verifier_bug(env, "regs not found %x\n", bt_reg_mask(bt)); WARNING: line length of 109 exceeds 80 columns #236: FILE: kernel/bpf/verifier.c:4719: + verifier_bug(env, "backtracking func entry subprog %d reg_mask %x stack_mask %llx\n", WARNING: line length of 98 exceeds 80 columns #237: FILE: kernel/bpf/verifier.c:4720: + st->frame[0]->subprogno, bt_reg_mask(bt), bt_stack_mask(bt)); WARNING: line length of 92 exceeds 80 columns #258: FILE: kernel/bpf/verifier.c:4782: + verifier_bug(env, "stack slot %d, total slots %d\n", WARNING: line length of 94 exceeds 80 columns #259: FILE: kernel/bpf/verifier.c:4783: + i, func->allocated_stack / BPF_REG_SIZE); WARNING: line length of 90 exceeds 80 columns #276: FILE: kernel/bpf/verifier.c:6565: + verifier_bug(env, "subprog has tail_call and async cb\n"); WARNING: line length of 81 exceeds 80 columns #337: FILE: kernel/bpf/verifier.c:10461: + verifier_bug(env, "kfunc %s#%d not marked as callback-calling\n", WARNING: line length of 82 exceeds 80 columns #344: FILE: kernel/bpf/verifier.c:10466: + verifier_bug(env, "helper %s#%d not marked as callback-calling\n", WARNING: line length of 81 exceeds 80 columns #354: FILE: kernel/bpf/verifier.c:10520: + verifier_bug(env, "No program starts at insn %d\n", target_insn); WARNING: line length of 83 exceeds 80 columns #373: FILE: kernel/bpf/verifier.c:19702: + if (unlikely(env->cur_state->loop_entry)) { WARNING: line length of 106 exceeds 80 columns #374: FILE: kernel/bpf/verifier.c:19703: + verifier_bug(env, "env->cur_state->loop_entry != NULL\n"); WARNING: line length of 86 exceeds 80 columns #385: FILE: kernel/bpf/verifier.c:20764: + verifier_bug(env, "zext_dst is set, but no reg is defined\n"); WARNING: line length of 82 exceeds 80 columns #405: FILE: kernel/bpf/verifier.c:22450: + verifier_bug(env, "stack_slots supports may_goto only\n"); WARNING: The commit message has 'syzkaller', perhaps it also needs a 'Fixes:' tag? total: 0 errors, 28 warnings, 1 checks, 337 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit d0accafa2146 ("bpf: WARN_ONCE on verifier bugs") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 28 warnings, 1 checks, 337 lines checked