========== checkpatch - FAILED CHECK: Macro argument 'm' may be better as '(m)' to avoid precedence issues #44: FILE: drivers/net/ethernet/broadcom/genet/bcmgenet.c:992: +#define STAT_RTNL(m) { \ .stat_string = __stringify(m), \ + .stat_sizeof = sizeof(((struct rtnl_link_stats64 *)0)->m), \ + .stat_offset = offsetof(struct rtnl_link_stats64, m), \ + .type = BCMGENET_STAT_RTNL, \ } CHECK: Macro argument 's' may be better as '(s)' to avoid precedence issues #59: FILE: drivers/net/ethernet/broadcom/genet/bcmgenet.c:1006: +#define STAT_GENET_SOFT_MIB64(str, s, m) { \ + .stat_string = str, \ + .stat_sizeof = sizeof(((struct bcmgenet_priv *)0)->s.m), \ + .stat_offset = offsetof(struct bcmgenet_priv, s.m), \ + .type = BCMGENET_STAT_SOFT64, \ + .syncp_offset = offsetof(struct bcmgenet_priv, s.syncp), \ +} CHECK: Please don't use multiple blank lines #141: FILE: drivers/net/ethernet/broadcom/genet/bcmgenet.c:1265: + WARNING: line length of 107 exceeds 80 columns #174: FILE: drivers/net/ethernet/broadcom/genet/bcmgenet.c:1294: + s->syncp_offset); WARNING: line length of 97 exceeds 80 columns #360: FILE: drivers/net/ethernet/broadcom/genet/bcmgenet.c:3565: + struct rtnl_link_stats64 *stats) CHECK: Alignment should match open parenthesis #360: FILE: drivers/net/ethernet/broadcom/genet/bcmgenet.c:3565: +static void bcmgenet_get_stats64(struct net_device *dev, + struct rtnl_link_stats64 *stats) ERROR: trailing whitespace #387: FILE: drivers/net/ethernet/broadcom/genet/bcmgenet.c:3584: +^I^I^I$ CHECK: Blank lines aren't necessary after an open brace '{' #387: FILE: drivers/net/ethernet/broadcom/genet/bcmgenet.c:3584: + do { + WARNING: line length of 84 exceeds 80 columns #415: FILE: drivers/net/ethernet/broadcom/genet/bcmgenet.c:3606: + rx_length_errors = u64_stats_read(&rx_stats->length_errors); WARNING: line length of 82 exceeds 80 columns #418: FILE: drivers/net/ethernet/broadcom/genet/bcmgenet.c:3609: + rx_frame_errors = u64_stats_read(&rx_stats->frame_errors); WARNING: line length of 92 exceeds 80 columns #419: FILE: drivers/net/ethernet/broadcom/genet/bcmgenet.c:3610: + rx_fragmented_errors = u64_stats_read(&rx_stats->fragmented_errors); total: 1 errors, 5 warnings, 5 checks, 467 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit 60ae5525f616 ("net: bcmgenet: switch to use 64bit statistics") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.