CHECK: Blank lines aren't necessary before a close brace '}' #156: FILE: tools/testing/selftests/net/can/test_raw_filter.c:57: + +} WARNING: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #173: FILE: tools/testing/selftests/net/can/test_raw_filter.c:74: + strncpy(ifr.ifr_name, VCANIF, sizeof(ifr.ifr_name)); CHECK: Please use a blank line after function/struct/union/enum declarations #203: FILE: tools/testing/selftests/net/can/test_raw_filter.c:104: +}; +#define T_EFF (CAN_EFF_FLAG >> 28) CHECK: Please use a blank line after function/struct/union/enum declarations #219: FILE: tools/testing/selftests/net/can/test_raw_filter.c:120: +}; +/* Ignore EFF flag in filter ID if not covered by filter mask */ CHECK: Please use a blank line after function/struct/union/enum declarations #232: FILE: tools/testing/selftests/net/can/test_raw_filter.c:133: +}; +/* Ignore RTR flag in filter ID if not covered by filter mask */ CHECK: Please use a blank line after function/struct/union/enum declarations #245: FILE: tools/testing/selftests/net/can/test_raw_filter.c:146: +}; +/* Ignore EFF and RTR flags in filter ID if not covered by filter mask */ CHECK: Please use a blank line after function/struct/union/enum declarations #270: FILE: tools/testing/selftests/net/can/test_raw_filter.c:171: +}; +/* Receive only EFF frames when filter id and filter mask include EFF flag */ CHECK: Please use a blank line after function/struct/union/enum declarations #281: FILE: tools/testing/selftests/net/can/test_raw_filter.c:182: +}; +/* Receive only SFF frames when expecting no EFF flag, ignoring RTR flag */ CHECK: Please use a blank line after function/struct/union/enum declarations #292: FILE: tools/testing/selftests/net/can/test_raw_filter.c:193: +}; +/* Receive only EFF frames when filter id and filter mask include EFF flag, CHECK: Please use a blank line after function/struct/union/enum declarations #317: FILE: tools/testing/selftests/net/can/test_raw_filter.c:218: +}; +/* Receive no remote frames when filtering for no RTR flag, ignoring EFF flag */ CHECK: Please use a blank line after function/struct/union/enum declarations #328: FILE: tools/testing/selftests/net/can/test_raw_filter.c:229: +}; +/* Receive only remote frames when filter includes RTR flag */ CHECK: Please use a blank line after function/struct/union/enum declarations #339: FILE: tools/testing/selftests/net/can/test_raw_filter.c:240: +}; +/* Receive only remote frames when filter includes RTR flag, ignoring EFF CHECK: Please use a blank line after function/struct/union/enum declarations #363: FILE: tools/testing/selftests/net/can/test_raw_filter.c:264: +}; +/* Receive only EFF data frame when filtering for EFF but no RTR flag */ CHECK: Please use a blank line after function/struct/union/enum declarations #373: FILE: tools/testing/selftests/net/can/test_raw_filter.c:274: +}; +/* Receive only SFF remote frame when filtering for RTR but no EFF flag */ CHECK: Please use a blank line after function/struct/union/enum declarations #383: FILE: tools/testing/selftests/net/can/test_raw_filter.c:284: +}; +/* Receive only EFF remote frame when filtering for EFF and RTR flag */ CHECK: Please use a blank line after function/struct/union/enum declarations #406: FILE: tools/testing/selftests/net/can/test_raw_filter.c:307: +}; +/* Receive only EFF data frame when filtering for EFF flag and no RTR flag but CHECK: Alignment should match open parenthesis #435: FILE: tools/testing/selftests/net/can/test_raw_filter.c:336: + TH_LOG("filters: can_id = 0x%08X can_mask = 0x%08X", + rfilter.can_id, rfilter.can_mask); WARNING: line length of 81 exceeds 80 columns #453: FILE: tools/testing/selftests/net/can/test_raw_filter.c:354: + TH_LOG("failed select for frame %d, err: %d)", i, errno); WARNING: line length of 85 exceeds 80 columns #465: FILE: tools/testing/selftests/net/can/test_raw_filter.c:366: + TH_LOG("failed to read frame %d, err: %d", i, errno); CHECK: Blank lines aren't necessary before a close brace '}' #478: FILE: tools/testing/selftests/net/can/test_raw_filter.c:379: + + } WARNING: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #487: FILE: tools/testing/selftests/net/can/test_raw_filter.c:388: + strncpy(VCANIF, ifname, sizeof(VCANIF) - 1); WARNING: line length of 88 exceeds 80 columns #489: FILE: tools/testing/selftests/net/can/test_raw_filter.c:390: + printf("VCANIF environment variable must contain the test interface\n"); total: 0 errors, 5 warnings, 17 checks, 466 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 3b4ce2cc7cf3 ("selftests: can: Import tst-filter from can-tests") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 5 warnings, 17 checks, 466 lines checked