WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 WARNING: void function return statements are not generally useful #51: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:21: + return; +} CHECK: multiple assignments should be avoided #75: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:45: + skel->bss->written_count = skel->bss->written_size = 0; WARNING: line length of 107 exceeds 80 columns #76: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:46: + ret = bpf_prog_test_run_opts(bpf_program__fd(skel->progs.bpftool_dump_prog_stream), &opts); ERROR: do not initialise globals to 0 #92: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:62: +int cnt = 0; WARNING: line length of 122 exceeds 80 columns #115: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:85: + ASSERT_OK(bpf_prog_get_info_by_fd(bpf_program__fd(skel->progs.stream_test_output), &info, &info_len), "get info"); WARNING: line length of 93 exceeds 80 columns #116: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:86: + ret = bpf_prog_test_run_opts(bpf_program__fd(skel->progs.stream_test_output), &opts); WARNING: void function return statements are not generally useful #125: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:95: + return; +} ERROR: Macros with complex values should be enclosed in parentheses #141: FILE: tools/testing/selftests/bpf/progs/stream.c:10: +#define STREAM_STR (u64)(_STR _STR _STR _STR) WARNING: line length of 100 exceeds 80 columns #157: FILE: tools/testing/selftests/bpf/progs/stream.c:26: + if ((ret = bpf_stream_vprintk(stream, "%llu%s", &(u64[]){i, STREAM_STR}, 16)) < 0) { CHECK: Unnecessary parentheses around u64[] #157: FILE: tools/testing/selftests/bpf/progs/stream.c:26: + if ((ret = bpf_stream_vprintk(stream, "%llu%s", &(u64[]){i, STREAM_STR}, 16)) < 0) { ERROR: do not use assignment in if condition #157: FILE: tools/testing/selftests/bpf/progs/stream.c:26: + if ((ret = bpf_stream_vprintk(stream, "%llu%s", &(u64[]){i, STREAM_STR}, 16)) < 0) { WARNING: line length of 105 exceeds 80 columns #248: FILE: tools/testing/selftests/bpf/progs/stream.c:117: + failed = bpf_stream_vprintk(stream, "%s%s%s", &(u64[]){STREAM_STR, STREAM_STR}, 16) != 0; CHECK: Unnecessary parentheses around u64[] #248: FILE: tools/testing/selftests/bpf/progs/stream.c:117: + failed = bpf_stream_vprintk(stream, "%s%s%s", &(u64[]){STREAM_STR, STREAM_STR}, 16) != 0; WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #265: FILE: tools/testing/selftests/bpf/progs/stream_bpftool.c:1: +../../../../bpf/bpftool/skeleton/stream.bpf.c WARNING: adding a line without newline at end of file #265: FILE: tools/testing/selftests/bpf/progs/stream_bpftool.c:1: +../../../../bpf/bpftool/skeleton/stream.bpf.c CHECK: spaces preferred around that '/' (ctx:VxV) #265: FILE: tools/testing/selftests/bpf/progs/stream_bpftool.c:1: +../../../../bpf/bpftool/skeleton/stream.bpf.c ^ CHECK: spaces preferred around that '/' (ctx:VxV) #265: FILE: tools/testing/selftests/bpf/progs/stream_bpftool.c:1: +../../../../bpf/bpftool/skeleton/stream.bpf.c ^ CHECK: spaces preferred around that '/' (ctx:VxV) #265: FILE: tools/testing/selftests/bpf/progs/stream_bpftool.c:1: +../../../../bpf/bpftool/skeleton/stream.bpf.c ^ CHECK: spaces preferred around that '/' (ctx:VxV) #265: FILE: tools/testing/selftests/bpf/progs/stream_bpftool.c:1: +../../../../bpf/bpftool/skeleton/stream.bpf.c ^ CHECK: spaces preferred around that '/' (ctx:VxV) #265: FILE: tools/testing/selftests/bpf/progs/stream_bpftool.c:1: +../../../../bpf/bpftool/skeleton/stream.bpf.c ^ CHECK: spaces preferred around that '/' (ctx:VxV) #265: FILE: tools/testing/selftests/bpf/progs/stream_bpftool.c:1: +../../../../bpf/bpftool/skeleton/stream.bpf.c ^ CHECK: spaces preferred around that '/' (ctx:VxV) #265: FILE: tools/testing/selftests/bpf/progs/stream_bpftool.c:1: +../../../../bpf/bpftool/skeleton/stream.bpf.c ^ ERROR: open brace '{' following function definitions go on the next line #283: FILE: tools/testing/selftests/bpf/progs/stream_fail.c:11: +int stream_get_trusted(void *ctx) { ERROR: open brace '{' following function definitions go on the next line #293: FILE: tools/testing/selftests/bpf/progs/stream_fail.c:21: +int stream_get_prog_fail(void *ctx) { ERROR: open brace '{' following function definitions go on the next line #305: FILE: tools/testing/selftests/bpf/progs/stream_fail.c:33: +int stream_get_prog_trusted(void *ctx) { ERROR: open brace '{' following function definitions go on the next line #315: FILE: tools/testing/selftests/bpf/progs/stream_fail.c:43: +int stream_get_put_missing(void *ctx) { total: 7 errors, 10 warnings, 10 checks, 313 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit def2a6283e75 ("selftests/bpf: Add tests for prog streams") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.