CHECK: Please don't use multiple blank lines #173: FILE: include/linux/bpf.h:2429: + WARNING: line length of 86 exceeds 80 columns #272: FILE: kernel/bpf/core.c:2888: + WARN_ON_ONCE(!llist_empty(&aux->func[i]->aux->stream[0].log)); WARNING: line length of 86 exceeds 80 columns #273: FILE: kernel/bpf/core.c:2889: + WARN_ON_ONCE(!llist_empty(&aux->func[i]->aux->stream[1].log)); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #351: new file mode 100644 WARNING: line length of 86 exceeds 80 columns #393: FILE: kernel/bpf/stream.c:38: +#define BPF_STREAM_PAGE_SZ (PAGE_SIZE - offsetofend(struct bpf_stream_page, consumed)) WARNING: line length of 83 exceeds 80 columns #453: FILE: kernel/bpf/stream.c:98: +static int bpf_stream_page_check_room(struct bpf_stream_page *stream_page, int len) WARNING: line length of 86 exceeds 80 columns #473: FILE: kernel/bpf/stream.c:118: +static struct bpf_stream_page *bpf_stream_page_from_elem(struct bpf_stream_elem *elem) WARNING: line length of 102 exceeds 80 columns #480: FILE: kernel/bpf/stream.c:125: +static struct bpf_stream_elem *bpf_stream_page_push_elem(struct bpf_stream_page *stream_page, int len) WARNING: line length of 89 exceeds 80 columns #484: FILE: kernel/bpf/stream.c:129: + stream_page->consumed += round_up(offsetof(struct bpf_stream_elem, str[len]), 8); ERROR: space required after that close brace '}' #516: FILE: kernel/bpf/stream.c:161: + const int max_len = ARRAY_SIZE((struct bpf_bprintf_buffers){}.buf); WARNING: line length of 85 exceeds 80 columns #527: FILE: kernel/bpf/stream.c:172: + * Length denotes the amount of data to be written as part of stream element, WARNING: line length of 84 exceeds 80 columns #528: FILE: kernel/bpf/stream.c:173: + * thus includes '\0' byte. We're capped by how much bpf_bprintf_buffers can WARNING: 'accomodate' may be misspelled - perhaps 'accommodate'? #529: FILE: kernel/bpf/stream.c:174: + * accomodate, therefore deny allocations that won't fit into them. ^^^^^^^^^^ WARNING: line length of 82 exceeds 80 columns #543: FILE: kernel/bpf/stream.c:188: +static int __bpf_stream_push_str(struct llist_head *log, const char *str, int len) WARNING: line length of 83 exceeds 80 columns #565: FILE: kernel/bpf/stream.c:210: + if (atomic_add_return(len, &stream->capacity) >= BPF_STREAM_MAX_CAPACITY) { WARNING: line length of 96 exceeds 80 columns #572: FILE: kernel/bpf/stream.c:217: +static void bpf_stream_release_capacity(struct bpf_stream *stream, struct bpf_stream_elem *elem) WARNING: line length of 83 exceeds 80 columns #579: FILE: kernel/bpf/stream.c:224: +static int bpf_stream_push_str(struct bpf_stream *stream, const char *str, int len) WARNING: line length of 114 exceeds 80 columns #586: FILE: kernel/bpf/stream.c:231: +__bpf_kfunc int bpf_stream_vprintk(struct bpf_stream *stream, const char *fmt__str, const void *args, u32 len__sz) WARNING: line length of 82 exceeds 80 columns #606: FILE: kernel/bpf/stream.c:251: + /* If the string was truncated, we only wrote until the size of buffer. */ WARNING: line length of 91 exceeds 80 columns #614: FILE: kernel/bpf/stream.c:259: +__bpf_kfunc struct bpf_stream *bpf_stream_get(enum bpf_stream_id stream_id, void *aux__ign) CHECK: multiple assignments should be avoided #645: FILE: kernel/bpf/stream.c:290: + stream->backlog_head = stream->backlog_tail = NULL; WARNING: line length of 83 exceeds 80 columns #682: FILE: kernel/bpf/stream.c:327: +__bpf_kfunc struct bpf_stream_elem *bpf_stream_next_elem(struct bpf_stream *stream) WARNING: line length of 93 exceeds 80 columns #708: FILE: kernel/bpf/stream.c:353: +__bpf_kfunc struct bpf_stream *bpf_prog_stream_get(enum bpf_stream_id stream_id, u32 prog_id) WARNING: line length of 86 exceeds 80 columns #727: FILE: kernel/bpf/stream.c:372: + prog = container_of(stream, struct bpf_prog_aux, stream[stream_id - 1])->prog; WARNING: line length of 84 exceeds 80 columns #736: FILE: kernel/bpf/stream.c:381: +BTF_ID_FLAGS(func, bpf_stream_next_elem, KF_ACQUIRE | KF_RET_NULL | KF_TRUSTED_ARGS) WARNING: line length of 85 exceeds 80 columns #759: FILE: kernel/bpf/stream.c:404: + ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_UNSPEC, &bpf_stream_kfunc_set); WARNING: line length of 95 exceeds 80 columns #762: FILE: kernel/bpf/stream.c:407: + return register_btf_kfunc_id_set(BPF_PROG_TYPE_SYSCALL, &bpf_stream_syscall_kfunc_set); WARNING: line length of 82 exceeds 80 columns #820: FILE: kernel/bpf/stream.c:465: + /* If the string was truncated, we only wrote until the size of buffer. */ WARNING: line length of 88 exceeds 80 columns #893: FILE: kernel/bpf/verifier.c:13891: + if (meta.func_id == special_kfunc_list[KF_bpf_get_kmem_cache]) { WARNING: line length of 91 exceeds 80 columns #897: FILE: kernel/bpf/verifier.c:13893: + } else if (meta.func_id == special_kfunc_list[KF_bpf_stream_get]) { WARNING: line length of 101 exceeds 80 columns #911: FILE: kernel/bpf/verifier.c:21529: + u32 regno = is_bpf_wq_set_callback_impl_kfunc(desc->func_id) ? BPF_REG_4 : BPF_REG_2; WARNING: line length of 92 exceeds 80 columns #912: FILE: kernel/bpf/verifier.c:21530: + struct bpf_insn ld_addrs[2] = { BPF_LD_IMM64(regno, (long)env->prog->aux) }; total: 1 errors, 29 warnings, 2 checks, 752 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 4b61521fee1b ("bpf: Introduce BPF standard streams") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.