WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 WARNING: line length of 93 exceeds 80 columns #95: FILE: tools/testing/selftests/bpf/prog_tests/string_kfuncs.c:51: + ASSERT_EQ(topts.retval, -E2BIG, "reading too long string fails with -E2BIG"); WARNING: line length of 107 exceeds 80 columns #125: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:10: +/* Passing NULL by value to string kfuncs is allowed by the verifier but the kfunc should return -EINVAL */ WARNING: line length of 95 exceeds 80 columns #126: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:11: +SEC("syscall") __retval(-14) int test_strcmp_null(void *ctx) { return bpf_strcmp(NULL, NULL); } WARNING: line length of 99 exceeds 80 columns #127: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:12: +SEC("syscall") __retval(-14) int test_strchr_null(void *ctx) { return (u64)bpf_strchr(NULL, 'a'); } WARNING: line length of 105 exceeds 80 columns #128: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:13: +SEC("syscall") __retval(-14) int test_strchrnul_null(void *ctx) { return (u64)bpf_strchrnul(NULL, 'a'); } WARNING: line length of 104 exceeds 80 columns #129: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:14: +SEC("syscall") __retval(-14) int test_strnchr_null(void *ctx) { return (u64)bpf_strnchr(NULL, 1, 'a'); } WARNING: line length of 101 exceeds 80 columns #130: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:15: +SEC("syscall") __retval(-14) int test_strrchr_null(void *ctx) { return (u64)bpf_strrchr(NULL, 'a'); } WARNING: line length of 89 exceeds 80 columns #131: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:16: +SEC("syscall") __retval(-14) int test_strlen_null(void *ctx) { return bpf_strlen(NULL); } WARNING: line length of 94 exceeds 80 columns #132: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:17: +SEC("syscall") __retval(-14) int test_strnlen_null(void *ctx) { return bpf_strnlen(NULL, 1); } WARNING: line length of 95 exceeds 80 columns #133: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:18: +SEC("syscall") __retval(-14) int test_strspn_null(void *ctx) { return bpf_strspn(NULL, NULL); } WARNING: line length of 97 exceeds 80 columns #134: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:19: +SEC("syscall") __retval(-14) int test_strcspn_null(void *ctx) { return bpf_strcspn(NULL, NULL); } WARNING: line length of 102 exceeds 80 columns #135: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:20: +SEC("syscall") __retval(-14) int test_strpbrk_null(void *ctx) { return (u64)bpf_strpbrk(NULL, NULL); } WARNING: line length of 100 exceeds 80 columns #136: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:21: +SEC("syscall") __retval(-14) int test_strstr_null(void *ctx) { return (u64)bpf_strstr(NULL, NULL); } WARNING: line length of 105 exceeds 80 columns #137: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:22: +SEC("syscall") __retval(-14) int test_strnstr_null(void *ctx) { return (u64)bpf_strnstr(NULL, NULL, 1); } WARNING: line length of 93 exceeds 80 columns #139: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:24: +/* Passing a NULL or an invalid pointer to string kfuncs should be rejected by the verifier*/ WARNING: line length of 100 exceeds 80 columns #140: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:25: +SEC("syscall") __failure int test_strcmp_nullptr(void *ctx) { return bpf_strcmp(nullptr, nullptr); } WARNING: line length of 101 exceeds 80 columns #141: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:26: +SEC("syscall") __failure int test_strchr_nullptr(void *ctx) { return (u64)bpf_strchr(nullptr, 'a'); } WARNING: line length of 107 exceeds 80 columns #142: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:27: +SEC("syscall") __failure int test_strchrnul_nullptr(void *ctx) { return (u64)bpf_strchrnul(nullptr, 'a'); } WARNING: line length of 106 exceeds 80 columns #143: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:28: +SEC("syscall") __failure int test_strnchr_nullptr(void *ctx) { return (u64)bpf_strnchr(nullptr, 1, 'a'); } WARNING: line length of 103 exceeds 80 columns #144: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:29: +SEC("syscall") __failure int test_strrchr_nullptr(void *ctx) { return (u64)bpf_strrchr(nullptr, 'a'); } WARNING: line length of 91 exceeds 80 columns #145: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:30: +SEC("syscall") __failure int test_strlen_nullptr(void *ctx) { return bpf_strlen(nullptr); } WARNING: line length of 96 exceeds 80 columns #146: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:31: +SEC("syscall") __failure int test_strnlen_nullptr(void *ctx) { return bpf_strnlen(nullptr, 1); } WARNING: line length of 100 exceeds 80 columns #147: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:32: +SEC("syscall") __failure int test_strspn_nullptr(void *ctx) { return bpf_strspn(nullptr, nullptr); } WARNING: line length of 102 exceeds 80 columns #148: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:33: +SEC("syscall") __failure int test_strcspn_nullptr(void *ctx) { return bpf_strcspn(nullptr, nullptr); } WARNING: line length of 107 exceeds 80 columns #149: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:34: +SEC("syscall") __failure int test_strpbrk_nullptr(void *ctx) { return (u64)bpf_strpbrk(nullptr, nullptr); } WARNING: line length of 105 exceeds 80 columns #150: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:35: +SEC("syscall") __failure int test_strstr_nullptr(void *ctx) { return (u64)bpf_strstr(nullptr, nullptr); } WARNING: line length of 110 exceeds 80 columns #151: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:36: +SEC("syscall") __failure int test_strnstr_nullptr(void *ctx) { return (u64)bpf_strnstr(nullptr, nullptr, 1); } WARNING: line length of 112 exceeds 80 columns #153: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:38: +SEC("syscall") __failure int test_strcmp_invalid_ptr(void *ctx) { return bpf_strcmp(invalid_ptr, invalid_ptr); } WARNING: line length of 109 exceeds 80 columns #154: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:39: +SEC("syscall") __failure int test_strchr_invalid_ptr(void *ctx) { return (u64)bpf_strchr(invalid_ptr, 'a'); } WARNING: line length of 115 exceeds 80 columns #155: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:40: +SEC("syscall") __failure int test_strchrnul_invalid_ptr(void *ctx) { return (u64)bpf_strchrnul(invalid_ptr, 'a'); } WARNING: line length of 114 exceeds 80 columns #156: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:41: +SEC("syscall") __failure int test_strnchr_invalid_ptr(void *ctx) { return (u64)bpf_strnchr(invalid_ptr, 1, 'a'); } WARNING: line length of 111 exceeds 80 columns #157: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:42: +SEC("syscall") __failure int test_strrchr_invalid_ptr(void *ctx) { return (u64)bpf_strrchr(invalid_ptr, 'a'); } WARNING: line length of 99 exceeds 80 columns #158: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:43: +SEC("syscall") __failure int test_strlen_invalid_ptr(void *ctx) { return bpf_strlen(invalid_ptr); } WARNING: line length of 104 exceeds 80 columns #159: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:44: +SEC("syscall") __failure int test_strnlen_invalid_ptr(void *ctx) { return bpf_strnlen(invalid_ptr, 1); } WARNING: line length of 112 exceeds 80 columns #160: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:45: +SEC("syscall") __failure int test_strspn_invalid_ptr(void *ctx) { return bpf_strspn(invalid_ptr, invalid_ptr); } WARNING: line length of 114 exceeds 80 columns #161: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:46: +SEC("syscall") __failure int test_strcspn_invalid_ptr(void *ctx) { return bpf_strcspn(invalid_ptr, invalid_ptr); } WARNING: line length of 119 exceeds 80 columns #162: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:47: +SEC("syscall") __failure int test_strpbrk_invalid_ptr(void *ctx) { return (u64)bpf_strpbrk(invalid_ptr, invalid_ptr); } WARNING: line length of 117 exceeds 80 columns #163: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:48: +SEC("syscall") __failure int test_strstr_invalid_ptr(void *ctx) { return (u64)bpf_strstr(invalid_ptr, invalid_ptr); } WARNING: line length of 122 exceeds 80 columns #164: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c:49: +SEC("syscall") __failure int test_strnstr_invalid_ptr(void *ctx) { return (u64)bpf_strnstr(invalid_ptr, invalid_ptr, 1); } WARNING: line length of 93 exceeds 80 columns #183: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure2.c:11: +SEC("syscall") int test_strcmp_too_long(void *ctx) { return bpf_strcmp(long_str, long_str); } WARNING: line length of 96 exceeds 80 columns #184: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure2.c:12: +SEC("syscall") const char *test_strchr_too_long(void *ctx) { return bpf_strchr(long_str, 'b'); } WARNING: line length of 102 exceeds 80 columns #185: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure2.c:13: +SEC("syscall") const char *test_strchrnul_too_long(void *ctx) { return bpf_strchrnul(long_str, 'b'); } WARNING: line length of 116 exceeds 80 columns #186: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure2.c:14: +SEC("syscall") const char *test_strnchr_too_long(void *ctx) { return bpf_strnchr(long_str, sizeof(long_str), 'b'); } WARNING: line length of 98 exceeds 80 columns #187: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure2.c:15: +SEC("syscall") const char *test_strrchr_too_long(void *ctx) { return bpf_strrchr(long_str, 'b'); } WARNING: line length of 83 exceeds 80 columns #188: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure2.c:16: +SEC("syscall") int test_strlen_too_long(void *ctx) { return bpf_strlen(long_str); } WARNING: line length of 103 exceeds 80 columns #189: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure2.c:17: +SEC("syscall") int test_strnlen_too_long(void *ctx) { return bpf_strnlen(long_str, sizeof(long_str)); } WARNING: line length of 86 exceeds 80 columns #190: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure2.c:18: +SEC("syscall") int test_strspn_too_long(void *ctx) { return bpf_strspn(long_str, a); } WARNING: line length of 88 exceeds 80 columns #191: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure2.c:19: +SEC("syscall") int test_strcspn_too_long(void *ctx) { return bpf_strcspn(long_str, b); } WARNING: line length of 96 exceeds 80 columns #192: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure2.c:20: +SEC("syscall") const char *test_strpbrk_too_long(void *ctx) { return bpf_strpbrk(long_str, b); } WARNING: line length of 101 exceeds 80 columns #193: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure2.c:21: +SEC("syscall") const char *test_strstr_too_long(void *ctx) { return bpf_strstr(long_str, long_str); } WARNING: line length of 121 exceeds 80 columns #194: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_failure2.c:22: +SEC("syscall") const char *test_strnstr_too_long(void *ctx) { return bpf_strnstr(long_str, long_str, sizeof(long_str)); } ERROR: Macros with complex values should be enclosed in parentheses #211: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:9: +#define __test(retval) SEC("syscall") __success __retval(retval) WARNING: line length of 82 exceeds 80 columns #214: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:12: +__test(0) int test_strcmp_eq(void *ctx) { return bpf_strcmp(str, "hello world"); } WARNING: line length of 81 exceeds 80 columns #216: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:14: +__test(1) int test_strchr_found(void *ctx) { return bpf_strchr(str, 'e') - str; } WARNING: line length of 82 exceeds 80 columns #217: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:15: +__test(11) int test_strchr_null(void *ctx) { return bpf_strchr(str, '\0') - str; } WARNING: line length of 83 exceeds 80 columns #218: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:16: +__test(0) u64 test_strchr_notfound(void *ctx) { return (u64)bpf_strchr(str, 'x'); } WARNING: line length of 87 exceeds 80 columns #219: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:17: +__test(1) int test_strchrnul_found(void *ctx) { return bpf_strchrnul(str, 'e') - str; } WARNING: line length of 91 exceeds 80 columns #220: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:18: +__test(11) int test_strchrnul_notfound(void *ctx) { return bpf_strchrnul(str, 'x') - str; } WARNING: line length of 86 exceeds 80 columns #221: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:19: +__test(1) int test_strnchr_found(void *ctx) { return bpf_strnchr(str, 5, 'e') - str; } WARNING: line length of 88 exceeds 80 columns #222: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:20: +__test(11) int test_strnchr_null(void *ctx) { return bpf_strnchr(str, 12, '\0') - str; } WARNING: line length of 88 exceeds 80 columns #223: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:21: +__test(0) u64 test_strnchr_notfound(void *ctx) { return (u64)bpf_strnchr(str, 5, 'w'); } WARNING: line length of 83 exceeds 80 columns #224: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:22: +__test(9) int test_strrchr_found(void *ctx) { return bpf_strrchr(str, 'l') - str; } WARNING: line length of 85 exceeds 80 columns #225: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:23: +__test(0) u64 test_strrchr_notfound(void *ctx) { return (u64)bpf_strrchr(str, 'x'); } WARNING: line length of 84 exceeds 80 columns #230: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:28: +__test(2) int test_strpbrk_found(void *ctx) { return bpf_strpbrk(str, "lo") - str; } WARNING: line length of 87 exceeds 80 columns #231: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:29: +__test(0) u64 test_strpbrk_notfound(void *ctx) { return (u64)bpf_strpbrk(str, "abc"); } WARNING: line length of 85 exceeds 80 columns #232: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:30: +__test(6) int test_strstr_found(void *ctx) { return bpf_strstr(str, "world") - str; } WARNING: line length of 84 exceeds 80 columns #233: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:31: +__test(0) u64 test_strstr_notfound(void *ctx) { return (u64)bpf_strstr(str, "hi"); } WARNING: line length of 90 exceeds 80 columns #235: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:33: +__test(0) int test_strnstr_found(void *ctx) { return bpf_strnstr(str, "hello", 6) - str; } WARNING: line length of 90 exceeds 80 columns #236: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:34: +__test(0) u64 test_strnstr_notfound(void *ctx) { return (u64)bpf_strnstr(str, "hi", 10); } WARNING: line length of 85 exceeds 80 columns #237: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:35: +__test(0) int test_strnstr_empty(void *ctx) { return bpf_strnstr(str, "", 1) - str; } ERROR: trailing statements should be on next line #248: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:46: + if (bpf_strcmp("abc", "abc") != 0) return -1; ERROR: trailing statements should be on next line #249: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:47: + if (bpf_strchr("abc", 'x') != NULL) return -1; CHECK: Comparison to NULL could be written "bpf_strchr" #249: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:47: + if (bpf_strchr("abc", 'x') != NULL) return -1; ERROR: trailing statements should be on next line #250: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:48: + if (bpf_strchrnul("abc", 'x') == NULL) return -1; CHECK: Comparison to NULL could be written "!bpf_strchrnul" #250: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:48: + if (bpf_strchrnul("abc", 'x') == NULL) return -1; ERROR: trailing statements should be on next line #251: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:49: + if (bpf_strnchr("abc", 3, 'x') != NULL) return -1; CHECK: Comparison to NULL could be written "bpf_strnchr" #251: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:49: + if (bpf_strnchr("abc", 3, 'x') != NULL) return -1; ERROR: trailing statements should be on next line #252: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:50: + if (bpf_strrchr("abc", 'x') != NULL) return -1; CHECK: Comparison to NULL could be written "bpf_strrchr" #252: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:50: + if (bpf_strrchr("abc", 'x') != NULL) return -1; ERROR: trailing statements should be on next line #253: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:51: + if (bpf_strlen("abc") != 3) return -1; ERROR: trailing statements should be on next line #254: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:52: + if (bpf_strnlen("abc", 3) != 3) return -1; ERROR: trailing statements should be on next line #255: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:53: + if (bpf_strspn("abc", "abc") != 3) return -1; ERROR: trailing statements should be on next line #256: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:54: + if (bpf_strcspn("abc", "abc") != 0) return -1; ERROR: trailing statements should be on next line #257: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:55: + if (bpf_strpbrk("abc", "def") != NULL) return -1; CHECK: Comparison to NULL could be written "bpf_strpbrk" #257: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:55: + if (bpf_strpbrk("abc", "def") != NULL) return -1; ERROR: trailing statements should be on next line #258: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:56: + if (bpf_strstr("abc", "def") != NULL) return -1; CHECK: Comparison to NULL could be written "bpf_strstr" #258: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:56: + if (bpf_strstr("abc", "def") != NULL) return -1; ERROR: trailing statements should be on next line #259: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:57: + if (bpf_strnstr("abc", "def", 3) != NULL) return -1; CHECK: Comparison to NULL could be written "bpf_strnstr" #259: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:57: + if (bpf_strnstr("abc", "def", 3) != NULL) return -1; ERROR: trailing statements should be on next line #273: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:71: + if (bpf_strcmp(buffer, buffer) != 0) return -1; ERROR: trailing statements should be on next line #274: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:72: + if (bpf_strchr(buffer, 'a') != buffer) return -1; ERROR: trailing statements should be on next line #275: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:73: + if (bpf_strchrnul(buffer, 'a') != buffer) return -1; ERROR: trailing statements should be on next line #276: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:74: + if (bpf_strnchr(buffer, sizeof(buffer), 'a') != buffer) return -1; ERROR: trailing statements should be on next line #277: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:75: + if (bpf_strrchr(buffer, 'b') != NULL) return -1; CHECK: Comparison to NULL could be written "bpf_strrchr" #277: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:75: + if (bpf_strrchr(buffer, 'b') != NULL) return -1; ERROR: trailing statements should be on next line #278: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:76: + if (bpf_strlen(buffer) != sizeof(buffer) - 1) return -1; WARNING: line length of 81 exceeds 80 columns #279: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:77: + if (bpf_strnlen(buffer, sizeof(buffer)) != sizeof(buffer) - 1) return -1; ERROR: trailing statements should be on next line #279: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:77: + if (bpf_strnlen(buffer, sizeof(buffer)) != sizeof(buffer) - 1) return -1; ERROR: trailing statements should be on next line #280: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:78: + if (bpf_strspn(buffer, buffer) != sizeof(buffer) - 1) return -1; ERROR: trailing statements should be on next line #281: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:79: + if (bpf_strcspn(buffer, buffer) != 0) return -1; ERROR: trailing statements should be on next line #282: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:80: + if (bpf_strpbrk(buffer, buffer) != buffer) return -1; ERROR: trailing statements should be on next line #283: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:81: + if (bpf_strstr(buffer, buffer) != buffer) return -1; ERROR: trailing statements should be on next line #284: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_success.c:82: + if (bpf_strnstr(buffer, buffer, sizeof(buffer)) != buffer) return -1; total: 25 errors, 71 warnings, 8 checks, 227 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 3bdf8ced238d ("selftests/bpf: Add tests for string kfuncs") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.