CHECK: Please use a blank line after function/struct/union/enum declarations #89: FILE: include/linux/filter.h:1084: +} +static inline int sk_filter_reason(struct sock *sk, struct sk_buff *skb, CHECK: Please don't use multiple blank lines #95: FILE: include/linux/filter.h:1090: + WARNING: line length of 83 exceeds 80 columns #123: FILE: include/net/tcp.h:1563: +int tcp_filter(struct sock *sk, struct sk_buff *skb, enum skb_drop_reason *reason); ERROR: do not use assignment in if condition #233: FILE: net/core/sock.c:580: + } else if ((err = sk_add_backlog(sk, skb, READ_ONCE(sk->sk_rcvbuf)))) { ERROR: do not use assignment in if condition #268: FILE: net/ipv4/tcp_ipv4.c:2139: + if (unlikely((err = sk_add_backlog(sk, skb, limit)))) { WARNING: line length of 82 exceeds 80 columns #286: FILE: net/ipv4/tcp_ipv4.c:2154: +int tcp_filter(struct sock *sk, struct sk_buff *skb, enum skb_drop_reason *reason) WARNING: line length of 82 exceeds 80 columns #431: FILE: net/rose/rose_in.c:166: + if (sk_filter_trim_cap(sk, skb, ROSE_MIN_LEN, &dr) == 0 && total: 2 errors, 3 warnings, 2 checks, 316 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit f02d794dd82d ("net: track pfmemalloc drops via SKB_DROP_REASON_PFMEMALLOC") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.