CHECK: Alignment should match open parenthesis #415: FILE: kernel/kexec_pe_image.c:317: +static void *get_symbol_from_elf(const char *elf_data, size_t elf_size, + const char *symbol_name, unsigned int *symbol_size) CHECK: multiple assignments should be avoided #424: FILE: kernel/kexec_pe_image.c:326: + symtab_shdr = strtab_shdr = NULL; WARNING: braces {} are not necessary for any arm of this statement #432: FILE: kernel/kexec_pe_image.c:334: + if (shdr[i].sh_type == SHT_SYMTAB) { [...] + } else if (shdr[i].sh_type == SHT_STRTAB && i != ehdr->e_shstrndx) { [...] WARNING: line length of 84 exceeds 80 columns #434: FILE: kernel/kexec_pe_image.c:336: + } else if (shdr[i].sh_type == SHT_STRTAB && i != ehdr->e_shstrndx) { WARNING: suspect code indent for conditional statements (24, 28) #448: FILE: kernel/kexec_pe_image.c:350: + if (sym->st_shndx >= SHN_LORESERVE) + return NULL; // No section data for these WARNING: Statements should start on a tabstop #449: FILE: kernel/kexec_pe_image.c:351: + return NULL; // No section data for these WARNING: line length of 95 exceeds 80 columns #451: FILE: kernel/kexec_pe_image.c:353: + symbol_data = (void *)(elf_data + dst_shdr->sh_offset + sym->st_value); WARNING: please, no spaces at the start of a line #458: FILE: kernel/kexec_pe_image.c:360: + return symbol_data;$ WARNING: line length of 81 exceeds 80 columns #464: FILE: kernel/kexec_pe_image.c:366: + opts_data = get_symbol_from_elf(bpf_elf, sz, "opts_data", &opts_data_sz); WARNING: line length of 81 exceeds 80 columns #465: FILE: kernel/kexec_pe_image.c:367: + opts_insn = get_symbol_from_elf(bpf_elf, sz, "opts_insn", &opts_insn_sz); WARNING: line length of 82 exceeds 80 columns #469: FILE: kernel/kexec_pe_image.c:371: + * When light skeleton generates opts_data[] and opts_insn[], it appends a total: 0 errors, 9 warnings, 2 checks, 423 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 96b933fb3437 ("kexec: Integrate bpf light skeleton to load zboot image") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 9 warnings, 2 checks, 423 lines checked