WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #52: new file mode 100644 CHECK: Please don't use multiple blank lines #127: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:8: + + CHECK: Prefer using the BIT macro #129: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:10: +#define MAX_BUF_SIZE (1 << 28) CHECK: Prefer using the BIT macro #131: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:12: +#define MAX_RECORD_SIZE (1 << 27) WARNING: line length of 81 exceeds 80 columns #161: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:42: + * This function ensures that the sections .rodata, .data .bss and .rodata.str1.1 WARNING: Prefer __used over __attribute__((used)) #164: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:45: +__attribute__((used)) static int dummy(void) WARNING: line length of 107 exceeds 80 columns #166: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:47: + static const char res_kernel[16] __attribute__((used, section(".rodata"))) = KEXEC_RES_KERNEL_NAME; WARNING: Prefer __used over __attribute__((used)) #166: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:47: + static const char res_kernel[16] __attribute__((used, section(".rodata"))) = KEXEC_RES_KERNEL_NAME; WARNING: Prefer __section(".rodata") over __attribute__((section(".rodata"))) #166: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:47: + static const char res_kernel[16] __attribute__((used, section(".rodata"))) = KEXEC_RES_KERNEL_NAME; WARNING: line length of 100 exceeds 80 columns #167: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:48: + static char local_name[16] __attribute__((used, section(".data"))) = KEXEC_RES_CMDLINE_NAME; WARNING: Prefer __used over __attribute__((used)) #167: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:48: + static char local_name[16] __attribute__((used, section(".data"))) = KEXEC_RES_CMDLINE_NAME; WARNING: Prefer __section(".data") over __attribute__((section(".data"))) #167: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:48: + static char local_name[16] __attribute__((used, section(".data"))) = KEXEC_RES_CMDLINE_NAME; WARNING: Prefer __used over __attribute__((used)) #168: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:49: + static char res_cmdline[16] __attribute__((used, section(".bss"))); WARNING: Prefer __section(".bss") over __attribute__((section(".bss"))) #168: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:49: + static char res_cmdline[16] __attribute__((used, section(".bss"))); WARNING: line length of 98 exceeds 80 columns #175: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:56: +__attribute__((used)) int BPF_PROG(parse_pe, char *image_buf, unsigned int image_sz, char *initrd, WARNING: Prefer __used over __attribute__((used)) #175: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:56: +__attribute__((used)) int BPF_PROG(parse_pe, char *image_buf, unsigned int image_sz, char *initrd, CHECK: Alignment should match open parenthesis #176: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:57: +__attribute__((used)) int BPF_PROG(parse_pe, char *image_buf, unsigned int image_sz, char *initrd, + unsigned int initrd_sz, char *cmdline) WARNING: Prefer __used over __attribute__((used)) #182: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.c:63: +__attribute__((used)) int BPF_PROG(post_parse_pe, char *image_buf, int buf_sz) CHECK: Please use a blank line after function/struct/union/enum declarations #259: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:68: +} +static void CHECK: Please use a blank line after function/struct/union/enum declarations #277: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:86: +} +static inline struct kexec_pe_parser_bpf * WARNING: Avoid line continuations in quoted strings #297: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:106: + static const char opts_data[] __attribute__((__aligned__(8))) = "\ WARNING: Prefer __aligned(8) over __attribute__((__aligned__(8))) #297: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:106: + static const char opts_data[] __attribute__((__aligned__(8))) = "\ WARNING: Avoid line continuations in quoted strings #428: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:237: + static const char opts_insn[] __attribute__((__aligned__(8))) = "\ WARNING: Prefer __aligned(8) over __attribute__((__aligned__(8))) #428: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:237: + static const char opts_insn[] __attribute__((__aligned__(8))) = "\ WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #609: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:418: +__attribute__((unused)) static void WARNING: line length of 82 exceeds 80 columns #610: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:419: +kexec_pe_parser_bpf__assert(struct kexec_pe_parser_bpf *s __attribute__((unused))) WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #610: FILE: kernel/kexec_bpf/kexec_pe_parser_bpf.lskel.h:419: +kexec_pe_parser_bpf__assert(struct kexec_pe_parser_bpf *s __attribute__((unused))) total: 0 errors, 21 warnings, 6 checks, 552 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 2cb959fdb97f ("kexec: Introduce a bpf-prog lskel to parse PE file") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 21 warnings, 6 checks, 552 lines checked