WARNING: Block comments should align the * on each line #169: FILE: drivers/mfd/zl3073x-core.c:300: + * Writes selected fields from the mailbox into device. + * WARNING: Block comments should align the * on each line #170: FILE: drivers/mfd/zl3073x-core.c:301: + * + * Return: 0 on success, <0 on error CHECK: Please use a blank line after function/struct/union/enum declarations #575: FILE: include/linux/mfd/zl3073x.h:43: +}; +#define ZL3073X_MB_DPLL_REF_PRIO(_ref_pair) BIT(_ref_pair) CHECK: Please use a blank line after function/struct/union/enum declarations #617: FILE: include/linux/mfd/zl3073x.h:85: +}; +#define ZL3073X_MB_OUTPUT_MODE BIT(0) CHECK: Please use a blank line after function/struct/union/enum declarations #660: FILE: include/linux/mfd/zl3073x.h:128: +}; +#define ZL3073X_MB_REF_FREQ_BASE BIT(0) CHECK: Please use a blank line after function/struct/union/enum declarations #684: FILE: include/linux/mfd/zl3073x.h:152: +}; +#define ZL3073X_MB_SYNTH_FREQ_BASE BIT(0) CHECK: Alignment should match open parenthesis #690: FILE: include/linux/mfd/zl3073x.h:158: +int zl3073x_mb_synth_read(struct zl3073x_dev *zldev, u8 index, u32 fields, + struct zl3073x_mb_synth *mb); total: 0 errors, 2 warnings, 5 checks, 645 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 16f7365711d6 ("mfd: zl3073x: Add functions to work with register mailboxes") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 2 warnings, 5 checks, 645 lines checked