WARNING: line length of 120 exceeds 80 columns #116: FILE: tools/testing/selftests/net/can/test_raw_filter.c:25: +const int rxbits_res[TC] = {4369, 4369, 4369, 4369, 17, 4352, 17, 4352, 257, 257, 4112, 4112, 1, 256, 16, 4096, 1, 256}; ERROR: do not use assignment in if condition #164: FILE: tools/testing/selftests/net/can/test_raw_filter.c:73: + if ((s = socket(PF_CAN, SOCK_RAW, CAN_RAW)) < 0) { WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #170: FILE: tools/testing/selftests/net/can/test_raw_filter.c:79: + strcpy(ifr.ifr_name, VCANIF); CHECK: Blank lines aren't necessary after an open brace '{' #191: FILE: tools/testing/selftests/net/can/test_raw_filter.c:100: + for (testcase = 0; testcase < TC; testcase++) { + WARNING: line length of 84 exceeds 80 columns #197: FILE: tools/testing/selftests/net/can/test_raw_filter.c:106: + printf("testcase %2d filters : can_id = 0x%08X can_mask = 0x%08X\n", CHECK: Blank lines aren't necessary after an open brace '{' #233: FILE: tools/testing/selftests/net/can/test_raw_filter.c:142: + while (have_rx) { + CHECK: spaces preferred around that '+' (ctx:VxV) #240: FILE: tools/testing/selftests/net/can/test_raw_filter.c:149: + ret = select(s+1, &rdfs, NULL, NULL, &tv); ^ WARNING: line length of 84 exceeds 80 columns #254: FILE: tools/testing/selftests/net/can/test_raw_filter.c:163: + fprintf(stderr, "received wrong can_id!\n"); WARNING: line length of 86 exceeds 80 columns #258: FILE: tools/testing/selftests/net/can/test_raw_filter.c:167: + fprintf(stderr, "received wrong testcase!\n"); WARNING: line length of 114 exceeds 80 columns #263: FILE: tools/testing/selftests/net/can/test_raw_filter.c:172: + rxbitval = 1 << ((frame.can_id & (CAN_EFF_FLAG|CAN_RTR_FLAG|CAN_ERR_FLAG)) >> 28); CHECK: spaces preferred around that '|' (ctx:VxV) #263: FILE: tools/testing/selftests/net/can/test_raw_filter.c:172: + rxbitval = 1 << ((frame.can_id & (CAN_EFF_FLAG|CAN_RTR_FLAG|CAN_ERR_FLAG)) >> 28); ^ CHECK: spaces preferred around that '|' (ctx:VxV) #263: FILE: tools/testing/selftests/net/can/test_raw_filter.c:172: + rxbitval = 1 << ((frame.can_id & (CAN_EFF_FLAG|CAN_RTR_FLAG|CAN_ERR_FLAG)) >> 28); ^ WARNING: line length of 99 exceeds 80 columns #267: FILE: tools/testing/selftests/net/can/test_raw_filter.c:176: + fprintf(stderr, "received rxbitval %d twice!\n", rxbitval); WARNING: line length of 97 exceeds 80 columns #273: FILE: tools/testing/selftests/net/can/test_raw_filter.c:182: + printf("testcase %2d rx : can_id = 0x%08X rx = %d rxbits = %d\n", WARNING: line length of 93 exceeds 80 columns #279: FILE: tools/testing/selftests/net/can/test_raw_filter.c:188: + fprintf(stderr, "wrong rx value in testcase %d : %d (expected %d)\n", WARNING: line length of 97 exceeds 80 columns #284: FILE: tools/testing/selftests/net/can/test_raw_filter.c:193: + fprintf(stderr, "wrong rxbits value in testcase %d : %d (expected %d)\n", total: 1 errors, 10 warnings, 5 checks, 273 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit ab554b27ad39 ("selftests: can: Import tst-filter from can-tests") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.