========== checkpatch - FAILED WARNING: line length of 84 exceeds 80 columns #27: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:733: +__description("unpriv: Spectre v1 path-based type confusion of scalar as stack-ptr") ERROR: spaces required around that ':' (ctx:VxW) #27: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:733: +__description("unpriv: Spectre v1 path-based type confusion of scalar as stack-ptr") ^ CHECK: spaces preferred around that '-' (ctx:VxV) #27: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:733: +__description("unpriv: Spectre v1 path-based type confusion of scalar as stack-ptr") ^ CHECK: spaces preferred around that '-' (ctx:VxV) #27: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:733: +__description("unpriv: Spectre v1 path-based type confusion of scalar as stack-ptr") ^ CHECK: spaces preferred around that '+' (ctx:VxV) #30: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:736: +__xlated_unpriv("if r0 != 0x1 goto pc+2") ^ WARNING: please, no spaces at the start of a line #32: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:738: + * taken) `if r0 != 0x0 goto l0_%=` to resolve before using r6 as a pointer.$ WARNING: please, no spaces at the start of a line #33: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:739: + * This causes the CPU to realize that `r6 = r9` should have never executed. It$ WARNING: please, no spaces at the start of a line #34: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:740: + * ensures that r6 always contains a readable stack slot ptr when the insn after$ WARNING: please, no spaces at the start of a line #35: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:741: + * the nospec executes.$ WARNING: please, no spaces at the start of a line #36: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:742: + */$ CHECK: spaces preferred around that '+' (ctx:WxV) #38: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:744: +__xlated_unpriv("r9 = *(u8 *)(r6 +0)") ^ WARNING: Avoid unnecessary line continuations #42: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:748: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #42: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:748: + asm volatile (" \ ERROR: "(foo*)" should be "(foo *)" #44: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:750: + *(u64*)(r10 - 8) = r1; \ CHECK: spaces preferred around that '%' (ctx:WxV) #47: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:753: + r1 = %[map_hash_8b] ll; \ ^ CHECK: spaces preferred around that '%' (ctx:WxV) #48: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:754: + call %[bpf_map_lookup_elem]; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #49: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:755: + if r0 == 0 goto l2_%=; \ ^ CHECK: spaces preferred around that '%' (ctx:WxV) #53: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:759: + r1 = %[map_hash_8b] ll; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #62: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:768: + if r0 != 0x0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #64: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:770: +l0_%=: if r0 != 0x1 goto l1_%=; \ ^ ERROR: spaces required around that ':' (ctx:OxW) #64: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:770: +l0_%=: if r0 != 0x1 goto l1_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #64: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:770: +l0_%=: if r0 != 0x1 goto l1_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #66: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:772: +l1_%=: /* leak r9 */ \ ^ ERROR: spaces required around that ':' (ctx:OxW) #66: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:772: +l1_%=: /* leak r9 */ \ ^ ERROR: "(foo*)" should be "(foo *)" #69: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:775: + *(u64*)(r10 - 8) = r9; \ CHECK: spaces preferred around that '%' (ctx:WxV) #70: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:776: + call %[bpf_map_lookup_elem]; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #71: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:777: + if r0 == 0 goto l2_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #74: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:780: +l2_%=: \ ^ ERROR: spaces required around that ':' (ctx:OxE) #74: FILE: tools/testing/selftests/bpf/progs/verifier_unpriv.c:780: +l2_%=: \ ^ total: 13 errors, 8 warnings, 8 checks, 61 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 95ea6fe09e33 ("selftests/bpf: Add test for Spectre v1 mitigation") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.