ERROR: Macros with multiple statements should be enclosed in a do - while loop #158: FILE: include/net/libeth/xdp.h:1521: +#define LIBETH_XDP_DEFINE_START() \ + __diag_push(); \ + __diag_ignore(GCC, 8, "-Wold-style-declaration", \ + "Allow specifying \'static\' after the return type") WARNING: Macros with flow control statements should be avoided #195: FILE: include/net/libeth/xdp.h:1558: +#define LIBETH_XDP_DEFINE_FLUSH_XMIT(name, prep, xmit) \ +bool name(struct libeth_xdp_tx_bulk *bq, u32 flags) \ +{ \ + return libeth_xdp_xmit_flush_bulk(bq, flags, prep, xmit); \ +} ERROR: Macros with complex values should be enclosed in parentheses #209: FILE: include/net/libeth/xdp.h:1572: +#define __LIBETH_XDP_DEFINE_RUN_PROG(name, flush, pfx) \ +name(struct libeth_xdp_buff *xdp, struct libeth_xdp_tx_bulk *bq) \ +{ \ + return libeth_##pfx##_run_prog(xdp, bq, flush); \ +} ERROR: Macros with complex values should be enclosed in parentheses #224: FILE: include/net/libeth/xdp.h:1587: +#define __LIBETH_XDP_DEFINE_RUN_PASS(name, run, populate, pfx) \ +name(struct libeth_xdp_buff *xdp, struct libeth_xdp_tx_bulk *bq, \ + struct napi_struct *napi, struct libeth_rq_napi_stats *ss, \ + const void *desc) \ +{ \ + return libeth_##pfx##_run_pass(xdp, bq, napi, ss, desc, run, \ + populate); \ +} WARNING: please, no spaces at the start of a line #226: FILE: include/net/libeth/xdp.h:1589: + struct napi_struct *napi, struct libeth_rq_napi_stats *ss,^I^I \$ WARNING: please, no spaces at the start of a line #227: FILE: include/net/libeth/xdp.h:1590: + const void *desc)^I^I^I^I^I^I^I \$ ERROR: Macros with multiple statements should be enclosed in a do - while loop #243: FILE: include/net/libeth/xdp.h:1606: +#define __LIBETH_XDP_DEFINE_RUN(name, run, flush, populate, pfx) \ + LIBETH_##pfx##_DEFINE_RUN_PROG(static run, flush); \ + LIBETH_##pfx##_DEFINE_RUN_PASS(name, run, populate) total: 4 errors, 3 warnings, 0 checks, 231 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit e868ee549926 ("libeth: xdp: add templates for building driver-side callbacks") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.