WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100644 CHECK: Please don't use multiple blank lines #57: FILE: tools/testing/selftests/bpf/prog_tests/dmabuf_iter.c:21: + + WARNING: Missing a blank line after declarations #66: FILE: tools/testing/selftests/bpf/prog_tests/dmabuf_iter.c:30: + int memfd = memfd_create("memfd_test", MFD_ALLOW_SEALING); + ASSERT_OK_FD(memfd, "memfd_create"); WARNING: Missing a blank line after declarations #73: FILE: tools/testing/selftests/bpf/prog_tests/dmabuf_iter.c:37: + int dev_udmabuf = open("/dev/udmabuf", O_RDONLY); + ASSERT_OK_FD(dev_udmabuf, "open udmabuf"); WARNING: Missing a blank line after declarations #76: FILE: tools/testing/selftests/bpf/prog_tests/dmabuf_iter.c:40: + struct udmabuf_create create; + create.memfd = memfd; WARNING: Missing a blank line after declarations #82: FILE: tools/testing/selftests/bpf/prog_tests/dmabuf_iter.c:46: + int udmabuf = ioctl(dev_udmabuf, UDMABUF_CREATE, &create); + close(dev_udmabuf); WARNING: line length of 82 exceeds 80 columns #87: FILE: tools/testing/selftests/bpf/prog_tests/dmabuf_iter.c:51: + int iter_fd = bpf_iter_create(bpf_link__fd(skel->links.dmabuf_collector)); WARNING: Missing a blank line after declarations #88: FILE: tools/testing/selftests/bpf/prog_tests/dmabuf_iter.c:52: + int iter_fd = bpf_iter_create(bpf_link__fd(skel->links.dmabuf_collector)); + ASSERT_OK_FD(iter_fd, "iter_create"); WARNING: Missing a blank line after declarations #91: FILE: tools/testing/selftests/bpf/prog_tests/dmabuf_iter.c:55: + FILE *iter_file = fdopen(iter_fd, "r"); + ASSERT_OK_PTR(iter_file, "fdopen"); WARNING: Missing a blank line after declarations #96: FILE: tools/testing/selftests/bpf/prog_tests/dmabuf_iter.c:60: + bool found_test_udmabuf = false; + while (getline(&line, &linesize, iter_file) != -1) { WARNING: line length of 84 exceeds 80 columns #100: FILE: tools/testing/selftests/bpf/prog_tests/dmabuf_iter.c:64: + int nelements = sscanf(line, "ino:%ld size:%ld name:%s exp_name:%s", CHECK: Alignment should match open parenthesis #104: FILE: tools/testing/selftests/bpf/prog_tests/dmabuf_iter.c:68: + if (nelements == 4 && size == test_buffer_size && + !strcmp(name, test_buffer_name) && WARNING: braces {} are not necessary for single statement blocks #138: FILE: tools/testing/selftests/bpf/prog_tests/dmabuf_iter.c:102: + while (read(iter_fd, buf, sizeof(buf) > 0)) { + /* Read out all contents */ + } WARNING: line length of 82 exceeds 80 columns #181: FILE: tools/testing/selftests/bpf/progs/dmabuf_iter.c:23: + bpf_core_read(&exp_name, sizeof(exp_name), &dmabuf->exp_name)) WARNING: line length of 81 exceeds 80 columns #185: FILE: tools/testing/selftests/bpf/progs/dmabuf_iter.c:27: + inode, size, name ? name : "", exp_name ? exp_name : ""); CHECK: Alignment should match open parenthesis #185: FILE: tools/testing/selftests/bpf/progs/dmabuf_iter.c:27: + BPF_SEQ_PRINTF(seq, "ino:%lu size:%llu name:%s exp_name:%s\n", + inode, size, name ? name : "", exp_name ? exp_name : ""); total: 0 errors, 13 warnings, 3 checks, 154 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 0cad039b1a90 ("selftests/bpf: Add test for dmabuf_iter") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 13 warnings, 3 checks, 154 lines checked