WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 WARNING: void function return statements are not generally useful #50: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:21: + return; +} CHECK: multiple assignments should be avoided #76: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:47: + skel->bss->written_count = skel->bss->written_size = 0; WARNING: line length of 114 exceeds 80 columns #77: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:48: + ret = bpf_prog_test_run_opts(bpf_program__fd(skel->progs.stream_bpftool_dump_prog_stream), &opts); WARNING: line length of 122 exceeds 80 columns #78: FILE: tools/testing/selftests/bpf/prog_tests/stream.c:49: + ASSERT_EQ(ring_buffer__consume_n(ringbuf, skel->bss->written_count), skel->bss->written_count, "consume"); ERROR: Macros with complex values should be enclosed in parentheses #138: FILE: tools/testing/selftests/bpf/progs/stream.c:10: +#define STREAM_STR (u64)(_STR _STR _STR _STR) WARNING: line length of 100 exceeds 80 columns #170: FILE: tools/testing/selftests/bpf/progs/stream.c:42: + if ((ret = bpf_stream_vprintk(stream, "%llu%s", &(u64[]){i, STREAM_STR}, 16)) < 0) { CHECK: Unnecessary parentheses around u64[] #170: FILE: tools/testing/selftests/bpf/progs/stream.c:42: + if ((ret = bpf_stream_vprintk(stream, "%llu%s", &(u64[]){i, STREAM_STR}, 16)) < 0) { ERROR: do not use assignment in if condition #170: FILE: tools/testing/selftests/bpf/progs/stream.c:42: + if ((ret = bpf_stream_vprintk(stream, "%llu%s", &(u64[]){i, STREAM_STR}, 16)) < 0) { CHECK: spaces preferred around that '*' (ctx:WxV) #300: FILE: tools/testing/selftests/bpf/progs/stream_bpftool.c:16: + struct bpf_stream_elem_batch __kptr *batch; ^ CHECK: Blank lines aren't necessary before a close brace '}' #358: FILE: tools/testing/selftests/bpf/progs/stream_bpftool.c:74: + +} WARNING: return of an errno should typically be negative (ie: return -ENOENT) #375: FILE: tools/testing/selftests/bpf/progs/stream_bpftool.c:91: + return ENOENT; WARNING: line length of 87 exceeds 80 columns #407: FILE: tools/testing/selftests/bpf/progs/stream_bpftool.c:123: + /* Probe and exit if no more space, probe for twice the typical size.*/ CHECK: spaces preferred around that '*' (ctx:WxV) #441: FILE: tools/testing/selftests/bpf/progs/stream_fail.c:9: + struct bpf_stream_elem_batch __kptr *batch; ^ CHECK: Please don't use multiple blank lines #451: FILE: tools/testing/selftests/bpf/progs/stream_fail.c:19: + + total: 2 errors, 7 warnings, 6 checks, 418 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 7f1e0d5a5bce ("selftests/bpf: Add tests for prog streams") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.