WARNING: line length of 87 exceeds 80 columns #66: FILE: tools/bpf/bpftool/prog.c:714: +prog_dump_stream(struct bpf_prog_info *info, enum dump_mode mode, const char *filepath) WARNING: Missing a blank line after declarations #69: FILE: tools/bpf/bpftool/prog.c:717: + FILE *file = mode == DUMP_STDOUT ? stdout : stderr; + LIBBPF_OPTS(bpf_test_run_opts, opts); CHECK: multiple assignments should be avoided #91: FILE: tools/bpf/bpftool/prog.c:739: + skel->bss->written_count = skel->bss->written_size = 0; WARNING: line length of 107 exceeds 80 columns #92: FILE: tools/bpf/bpftool/prog.c:740: + ret = bpf_prog_test_run_opts(bpf_program__fd(skel->progs.bpftool_dump_prog_stream), &opts); WARNING: line length of 106 exceeds 80 columns #94: FILE: tools/bpf/bpftool/prog.c:742: + if (ring_buffer__consume_n(ringbuf, skel->bss->written_count) != skel->bss->written_count) WARNING: line length of 90 exceeds 80 columns #133: FILE: tools/bpf/bpftool/prog.c:959: + p_err("expected 'stdout', 'stderr', 'xlated' or 'jited', got: %s", *argv); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #162: new file mode 100644 CHECK: spaces preferred around that '*' (ctx:WxV) #179: FILE: tools/bpf/bpftool/skeleton/stream.bpf.c:13: + struct bpf_stream_elem_batch __kptr *batch; ^ WARNING: return of an errno should typically be negative (ie: return -ENOENT) #210: FILE: tools/bpf/bpftool/skeleton/stream.bpf.c:44: + return ENOENT; WARNING: line length of 87 exceeds 80 columns #243: FILE: tools/bpf/bpftool/skeleton/stream.bpf.c:77: + /* Probe and exit if no more space, probe for twice the typical size.*/ total: 0 errors, 8 warnings, 2 checks, 224 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 820d4e72814e ("bpftool: Add support for dumping streams") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 8 warnings, 2 checks, 224 lines checked