WARNING: line length of 84 exceeds 80 columns #58: FILE: include/linux/bpf.h:1534: + BPF_STREAM_ELEM_F_MASK = (BPF_STREAM_ELEM_F_PAGE | BPF_STREAM_ELEM_F_NEXT), CHECK: Please don't use multiple blank lines #95: FILE: include/linux/bpf.h:2424: + WARNING: line length of 86 exceeds 80 columns #178: FILE: kernel/bpf/core.c:2883: + WARN_ON_ONCE(!llist_empty(&aux->func[i]->aux->stream[0].log)); WARNING: line length of 86 exceeds 80 columns #179: FILE: kernel/bpf/core.c:2884: + WARN_ON_ONCE(!llist_empty(&aux->func[i]->aux->stream[1].log)); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #257: new file mode 100644 WARNING: line length of 86 exceeds 80 columns #301: FILE: kernel/bpf/stream.c:40: +#define BPF_STREAM_PAGE_SZ (PAGE_SIZE - offsetofend(struct bpf_stream_page, consumed)) WARNING: line length of 83 exceeds 80 columns #361: FILE: kernel/bpf/stream.c:100: +static int bpf_stream_page_check_room(struct bpf_stream_page *stream_page, int len) WARNING: line length of 86 exceeds 80 columns #381: FILE: kernel/bpf/stream.c:120: +static struct bpf_stream_page *bpf_stream_page_from_elem(struct bpf_stream_elem *elem) WARNING: line length of 102 exceeds 80 columns #388: FILE: kernel/bpf/stream.c:127: +static struct bpf_stream_elem *bpf_stream_page_push_elem(struct bpf_stream_page *stream_page, int len) WARNING: line length of 89 exceeds 80 columns #392: FILE: kernel/bpf/stream.c:131: + stream_page->consumed += round_up(offsetof(struct bpf_stream_elem, str[len]), 8); ERROR: space required after that close brace '}' #483: FILE: kernel/bpf/stream.c:222: + const int max_len = ARRAY_SIZE((struct bpf_bprintf_buffers){}.buf); WARNING: line length of 85 exceeds 80 columns #493: FILE: kernel/bpf/stream.c:232: + * Length denotes the amount of data to be written as part of stream element, WARNING: line length of 84 exceeds 80 columns #494: FILE: kernel/bpf/stream.c:233: + * thus includes '\0' byte. We're capped by how much bpf_bprintf_buffers can WARNING: 'accomodate' may be misspelled - perhaps 'accommodate'? #495: FILE: kernel/bpf/stream.c:234: + * accomodate, therefore deny allocations that won't fit into them. ^^^^^^^^^^ WARNING: line length of 83 exceeds 80 columns #508: FILE: kernel/bpf/stream.c:247: +static int bpf_stream_push_str(struct bpf_stream *stream, const char *str, int len) WARNING: line length of 103 exceeds 80 columns #522: FILE: kernel/bpf/stream.c:261: + next = (struct bpf_stream_elem *)((unsigned long)elem->next & ~BPF_STREAM_ELEM_F_MASK); WARNING: line length of 114 exceeds 80 columns #542: FILE: kernel/bpf/stream.c:281: +__bpf_kfunc int bpf_stream_vprintk(struct bpf_stream *stream, const char *fmt__str, const void *args, u32 len__sz) WARNING: line length of 82 exceeds 80 columns #562: FILE: kernel/bpf/stream.c:301: + /* If the string was truncated, we only wrote until the size of buffer. */ WARNING: line length of 91 exceeds 80 columns #570: FILE: kernel/bpf/stream.c:309: +__bpf_kfunc struct bpf_stream *bpf_stream_get(enum bpf_stream_id stream_id, void *aux__ign) WARNING: line length of 95 exceeds 80 columns #579: FILE: kernel/bpf/stream.c:318: +__bpf_kfunc struct bpf_stream_elem_batch *bpf_stream_next_elem_batch(struct bpf_stream *stream) WARNING: line length of 85 exceeds 80 columns #641: FILE: kernel/bpf/stream.c:380: +__bpf_kfunc void bpf_stream_free_elem_batch(struct bpf_stream_elem_batch *elem_batch) CHECK: Blank lines aren't necessary after an open brace '{' #643: FILE: kernel/bpf/stream.c:382: +{ + WARNING: line length of 93 exceeds 80 columns #650: FILE: kernel/bpf/stream.c:389: +__bpf_kfunc struct bpf_stream *bpf_prog_stream_get(enum bpf_stream_id stream_id, u32 prog_id) WARNING: line length of 86 exceeds 80 columns #669: FILE: kernel/bpf/stream.c:408: + prog = container_of(stream, struct bpf_prog_aux, stream[stream_id - 1])->prog; WARNING: line length of 90 exceeds 80 columns #701: FILE: kernel/bpf/stream.c:440: +BTF_ID_FLAGS(func, bpf_stream_next_elem_batch, KF_ACQUIRE | KF_RET_NULL | KF_TRUSTED_ARGS) WARNING: line length of 84 exceeds 80 columns #703: FILE: kernel/bpf/stream.c:442: +BTF_ID_FLAGS(func, bpf_stream_next_elem, KF_ACQUIRE | KF_RET_NULL | KF_TRUSTED_ARGS) WARNING: line length of 103 exceeds 80 columns #733: FILE: kernel/bpf/stream.c:472: + ret = register_btf_id_dtor_kfuncs(bpf_stream_dtors, ARRAY_SIZE(bpf_stream_dtors), THIS_MODULE); WARNING: line length of 92 exceeds 80 columns #734: FILE: kernel/bpf/stream.c:473: + ret = ret ?: register_btf_kfunc_id_set(BPF_PROG_TYPE_UNSPEC, &bpf_stream_kfunc_set); WARNING: line length of 103 exceeds 80 columns #735: FILE: kernel/bpf/stream.c:474: + return ret ?: register_btf_kfunc_id_set(BPF_PROG_TYPE_SYSCALL, &bpf_stream_consumer_kfunc_set); WARNING: line length of 82 exceeds 80 columns #752: FILE: kernel/bpf/stream.c:491: + /* If the string was truncated, we only wrote until the size of buffer. */ WARNING: line length of 88 exceeds 80 columns #796: FILE: kernel/bpf/verifier.c:13888: + if (meta.func_id == special_kfunc_list[KF_bpf_get_kmem_cache]) { WARNING: line length of 91 exceeds 80 columns #800: FILE: kernel/bpf/verifier.c:13890: + } else if (meta.func_id == special_kfunc_list[KF_bpf_stream_get]) { WARNING: line length of 101 exceeds 80 columns #814: FILE: kernel/bpf/verifier.c:21528: + u32 regno = is_bpf_wq_set_callback_impl_kfunc(desc->func_id) ? BPF_REG_4 : BPF_REG_2; WARNING: line length of 92 exceeds 80 columns #815: FILE: kernel/bpf/verifier.c:21529: + struct bpf_insn ld_addrs[2] = { BPF_LD_IMM64(regno, (long)env->prog->aux) }; total: 1 errors, 31 warnings, 2 checks, 729 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit f17237b29d24 ("bpf: Introduce per-prog stdout/stderr streams") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.