WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #70: new file mode 100644 CHECK: struct mutex definition without comment #122: FILE: drivers/ptp/ptp_marvell_tai.c:48: + struct mutex mutex; CHECK: Please use a blank line after function/struct/union/enum declarations #568: FILE: drivers/ptp/ptp_marvell_ts.c:39: +}; +#define MARVELL_PTP_CB(skb) ((struct marvell_ptp_cb *)(skb)->cb) CHECK: Comparison to NULL could be written "cmpxchg" #903: FILE: drivers/ptp/ptp_marvell_ts.c:374: + if (cmpxchg(&ptp->tx_skb, NULL, skb) != NULL) WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") #1122: FILE: drivers/ptp/ptp_marvell_ts.c:593: +MODULE_LICENSE("GPL v2"); ERROR: code indent should use tabs where possible #1187: FILE: include/linux/marvell_ptp.h:59: +^I^I^I u8 reg);$ CHECK: Alignment should match open parenthesis #1187: FILE: include/linux/marvell_ptp.h:59: + int (*ptp_port_read_ts)(struct device *dev, struct marvell_ts *ts, + u8 reg); CHECK: struct mutex definition without comment #1221: FILE: include/linux/marvell_ptp.h:93: + struct mutex rx_mutex; total: 1 errors, 2 warnings, 5 checks, 1189 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit ef63e7b8fe18 ("ptp: marvell: add core support for Marvell PTP v2.1") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.