CHECK: Please don't use multiple blank lines #96: FILE: kernel/bpf/core.c:106: + + CHECK: Please don't use multiple blank lines #102: FILE: kernel/bpf/core.c:112: + + WARNING: const array should probably be static const #112: FILE: kernel/bpf/core.c:122: + const char prefix[] = "btf_trace_"; WARNING: line length of 90 exceeds 80 columns #181: FILE: kernel/bpf/core.c:191: + ? aux->func[subprog]->aux->changes_pkt_data WARNING: line length of 83 exceeds 80 columns #183: FILE: kernel/bpf/core.c:193: + if (prog->aux->changes_pkt_data && !tgt_changes_pkt_data) { WARNING: line length of 94 exceeds 80 columns #205: FILE: kernel/bpf/core.c:215: + * Target program is an fentry/fexit which is already attached WARNING: line length of 85 exceeds 80 columns #206: FILE: kernel/bpf/core.c:216: + * to another tracing program. More levels of nesting WARNING: line length of 100 exceeds 80 columns #209: FILE: kernel/bpf/core.c:219: + bpf_log(log, "Cannot nest tracing program attach more than once\n"); WARNING: line length of 87 exceeds 80 columns #214: FILE: kernel/bpf/core.c:224: + * To avoid potential call chain cycles, prevent attaching of a WARNING: line length of 84 exceeds 80 columns #215: FILE: kernel/bpf/core.c:225: + * program extension to another extension. It's ok to attach WARNING: line length of 81 exceeds 80 columns #229: FILE: kernel/bpf/core.c:239: + * type. When extension program is replacing XDP function WARNING: line length of 82 exceeds 80 columns #234: FILE: kernel/bpf/core.c:244: + * fentry/fexit was allowed it would be possible to create WARNING: line length of 87 exceeds 80 columns #262: FILE: kernel/bpf/core.c:272: + bpf_log(log, "attach_btf_id %u points to wrong type name %s\n", WARNING: line length of 99 exceeds 80 columns #268: FILE: kernel/bpf/core.c:278: + /* The func_proto of "btf_trace_##tname" is generated from typedef without argument WARNING: line length of 87 exceeds 80 columns #274: FILE: kernel/bpf/core.c:284: + fname = kallsyms_lookup((unsigned long)btp->bpf_func, NULL, NULL, NULL, WARNING: line length of 100 exceeds 80 columns #282: FILE: kernel/bpf/core.c:292: + bpf_log(log, "Cannot find btf of tracepoint template, fall back to %s%s.\n", WARNING: line length of 84 exceeds 80 columns #310: FILE: kernel/bpf/core.c:320: + ret = btf_distill_func_proto(log, btf, t, tname, &tgt_info->fmodel); WARNING: line length of 91 exceeds 80 columns #335: FILE: kernel/bpf/core.c:345: + if ((prog->aux->saved_dst_prog_type || prog->aux->saved_dst_attach_type) && WARNING: line length of 85 exceeds 80 columns #336: FILE: kernel/bpf/core.c:346: + (!tgt_prog || prog->aux->saved_dst_prog_type != tgt_prog->type || WARNING: line length of 89 exceeds 80 columns #337: FILE: kernel/bpf/core.c:347: + prog->aux->saved_dst_attach_type != tgt_prog->expected_attach_type)) WARNING: line length of 84 exceeds 80 columns #343: FILE: kernel/bpf/core.c:353: + ret = btf_distill_func_proto(log, btf, t, tname, &tgt_info->fmodel); CHECK: No space is necessary after a cast #349: FILE: kernel/bpf/core.c:359: + addr = (long) tgt_prog->bpf_func; WARNING: line length of 85 exceeds 80 columns #351: FILE: kernel/bpf/core.c:361: + addr = (long) tgt_prog->aux->func[subprog]->bpf_func; CHECK: No space is necessary after a cast #351: FILE: kernel/bpf/core.c:361: + addr = (long) tgt_prog->aux->func[subprog]->bpf_func; WARNING: line length of 86 exceeds 80 columns #356: FILE: kernel/bpf/core.c:366: + addr = find_kallsyms_symbol_value(mod, tname); WARNING: line length of 91 exceeds 80 columns #376: FILE: kernel/bpf/core.c:386: + /* fentry/fexit/fmod_ret progs can be sleepable if they are WARNING: line length of 93 exceeds 80 columns #377: FILE: kernel/bpf/core.c:387: + * attached to ALLOW_ERROR_INJECTION and are not in denylist. WARNING: line length of 96 exceeds 80 columns #382: FILE: kernel/bpf/core.c:392: + /* fentry/fexit/fmod_ret progs can also be sleepable if they are WARNING: line length of 84 exceeds 80 columns #383: FILE: kernel/bpf/core.c:393: + * in the fmodret id set with the KF_SLEEPABLE flag. CHECK: Unbalanced braces around else statement #385: FILE: kernel/bpf/core.c:395: + else { WARNING: line length of 92 exceeds 80 columns #386: FILE: kernel/bpf/core.c:396: + u32 *flags = btf_kfunc_is_modify_return(btf, btf_id, WARNING: line length of 86 exceeds 80 columns #387: FILE: kernel/bpf/core.c:397: + prog); WARNING: line length of 95 exceeds 80 columns #394: FILE: kernel/bpf/core.c:404: + /* LSM progs check that they are attached to bpf_lsm_*() funcs. WARNING: line length of 92 exceeds 80 columns #411: FILE: kernel/bpf/core.c:421: + bpf_log(log, "can't modify return codes of BPF programs\n"); total: 0 errors, 29 warnings, 5 checks, 778 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 8024fddac05e ("bpf: Move bpf_check_attach_target() to core") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 29 warnings, 5 checks, 778 lines checked