WARNING: externs should be avoided in .c files #62: FILE: tools/testing/selftests/bpf/bench.c:286: +extern struct argp bench_sockmap_argp; WARNING: externs should be avoided in .c files #78: FILE: tools/testing/selftests/bpf/bench.c:554: +extern const struct bench bench_sockmap; WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #91: new file mode 100644 WARNING: line length of 82 exceeds 80 columns #361: FILE: tools/testing/selftests/bpf/benchs/bench_sockmap.c:266: + err = bpf_prog_attach(verdict, map, BPF_SK_SKB_STREAM_VERDICT, 0); WARNING: line length of 86 exceeds 80 columns #493: FILE: tools/testing/selftests/bpf/benchs/bench_sockmap.c:398: + /* consumer 1 is unused for tx test and stream verdict test */ WARNING: line length of 89 exceeds 80 columns #496: FILE: tools/testing/selftests/bpf/benchs/bench_sockmap.c:401: + /* it's only for RX_NORMAL which service as reserve-proxy mode */ WARNING: line length of 92 exceeds 80 columns #519: FILE: tools/testing/selftests/bpf/benchs/bench_sockmap.c:424: + fprintf(stderr, "%s fail to read c2 %d\n", __func__, errno); WARNING: line length of 85 exceeds 80 columns #578: FILE: tools/testing/selftests/bpf/benchs/bench_sockmap.c:483: + if (errno != EAGAIN && errno != ENOMEM && errno != ENOBUFS) { WARNING: line length of 86 exceeds 80 columns #579: FILE: tools/testing/selftests/bpf/benchs/bench_sockmap.c:484: + fprintf(stderr, "sendfile return %d, errorno %d:%s\n", WARNING: line length of 81 exceeds 80 columns #604: FILE: tools/testing/selftests/bpf/benchs/bench_sockmap.c:509: + send_hz = (res->important_hits & 0xFFFFFFFF) / (delta_ns / 1000000000.0); WARNING: line length of 81 exceeds 80 columns #609: FILE: tools/testing/selftests/bpf/benchs/bench_sockmap.c:514: + printf("Send Speed %8.3lf MB/s (%8.3lf calls/s), BPF Speed %8.3lf MB/s, " WARNING: quoted string split across lines #610: FILE: tools/testing/selftests/bpf/benchs/bench_sockmap.c:515: + printf("Send Speed %8.3lf MB/s (%8.3lf calls/s), BPF Speed %8.3lf MB/s, " + "Rcv Speed %8.3lf MB/s (%8.3lf calls/s)\n", total: 0 errors, 12 warnings, 0 checks, 706 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 01ae9bc16459 ("selftest/bpf/benchs: Add benchmark for sockmap usage") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 12 warnings, 0 checks, 706 lines checked