WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#67: FILE: tools/testing/selftests/net/tcp_ao/connect-deny.c:7:
+static volatile int sk_pair;

WARNING: line length of 81 exceeds 80 columns
#111: FILE: tools/testing/selftests/net/tcp_ao/connect-deny.c:116:
+		   "TCPAOKeyNotFound", TEST_CNT_NS_KEY_NOT_FOUND, FAULT_TIMEOUT);

WARNING: line length of 87 exceeds 80 columns
#141: FILE: tools/testing/selftests/net/tcp_ao/connect-deny.c:186:
+	ret = test_skpair_connect_poll(sk, this_ip_dest, port, cnt_expected, &sk_pair);

CHECK: extern prototypes should be avoided in .h files
#198: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:595:
+extern int test_skpair_wait_poll(int sk, bool write, test_cnt cond,

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#199: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:596:
+				 volatile int *err);

CHECK: extern prototypes should be avoided in .h files
#200: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:597:
+extern int _test_skpair_connect_poll(int sk, const char *device,

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#202: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:599:
+				     test_cnt cond, volatile int *err);

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#205: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:602:
+					   test_cnt cond, volatile int *err)

WARNING: line length of 81 exceeds 80 columns
#211: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:608:
+					 (void *)&addr, sizeof(addr), cond, err);

CHECK: extern prototypes should be avoided in .h files
#214: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:611:
+extern int test_skpair_client(int sk, const size_t msg_len, const size_t nr,

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#215: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:612:
+			      test_cnt cond, volatile int *err);

CHECK: extern prototypes should be avoided in .h files
#216: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:613:
+extern int test_skpair_server(int sk, ssize_t quota,

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#217: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:614:
+			      test_cnt cond, volatile int *err);

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#284: FILE: tools/testing/selftests/net/tcp_ao/lib/sock.c:92:
+			      volatile int *err)

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#313: FILE: tools/testing/selftests/net/tcp_ao/lib/sock.c:158:
+			  test_cnt cond, volatile int *err)

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#330: FILE: tools/testing/selftests/net/tcp_ao/lib/sock.c:175:
+			      test_cnt condition, volatile int *err)

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#358: FILE: tools/testing/selftests/net/tcp_ao/lib/sock.c:597:
+				test_cnt cond, volatile int *err,

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#393: FILE: tools/testing/selftests/net/tcp_ao/lib/sock.c:639:
+int test_skpair_server(int sk, ssize_t quota, test_cnt cond, volatile int *err)

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#410: FILE: tools/testing/selftests/net/tcp_ao/lib/sock.c:656:
+				volatile int *err, time_t timeout_sec)

WARNING: line length of 83 exceeds 80 columns
#439: FILE: tools/testing/selftests/net/tcp_ao/lib/sock.c:689:
+			ret = __test_skpair_poll(sk, 0, timeout_sec, c, cond, err);

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#459: FILE: tools/testing/selftests/net/tcp_ao/lib/sock.c:721:
+		       test_cnt cond, volatile int *err)

WARNING: line length of 86 exceeds 80 columns
#532: FILE: tools/testing/selftests/net/tcp_ao/restore.c:174:
+			test_fail("%s: post-migrate connection is working", tst_name);

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#548: FILE: tools/testing/selftests/net/tcp_ao/unsigned-md5.c:9:
+static volatile int sk_pair;

total: 0 errors, 19 warnings, 4 checks, 585 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 485efadb8f39 ("selftests/net: Add mixed select()+polling mode to TCP-AO tests") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 19 warnings, 4 checks, 585 lines checked