WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #19: new file mode 100644 WARNING: do not add new typedefs #31: FILE: tools/testing/selftests/bpf/prog_tests/arena_spin_lock.c:8: +typedef struct qspinlock arena_spinlock_t; WARNING: Missing a blank line after declarations #49: FILE: tools/testing/selftests/bpf/prog_tests/arena_spin_lock.c:26: + int err, prog_fd = *(u32 *)arg; + LIBBPF_OPTS(bpf_test_run_opts, topts, CHECK: Alignment should match open parenthesis #50: FILE: tools/testing/selftests/bpf/prog_tests/arena_spin_lock.c:27: + LIBBPF_OPTS(bpf_test_run_opts, topts, + .data_in = &pkt_v4, WARNING: line length of 99 exceeds 80 columns #58: FILE: tools/testing/selftests/bpf/prog_tests/arena_spin_lock.c:35: + ASSERT_OK(pthread_setaffinity_np(pthread_self(), sizeof(cpuset), &cpuset), "cpu affinity"); WARNING: line length of 87 exceeds 80 columns #101: FILE: tools/testing/selftests/bpf/prog_tests/arena_spin_lock.c:78: + err = pthread_create(&thread_id[i], NULL, &spin_lock_thread, &prog_fd); WARNING: line length of 81 exceeds 80 columns #107: FILE: tools/testing/selftests/bpf/prog_tests/arena_spin_lock.c:84: + if (!ASSERT_OK(pthread_join(thread_id[i], &ret), "pthread_join")) WARNING: void function return statements are not generally useful #117: FILE: tools/testing/selftests/bpf/prog_tests/arena_spin_lock.c:94: + return; +} ERROR: do not use assignment in if condition #174: FILE: tools/testing/selftests/bpf/progs/arena_spin_lock.c:39: + if ((ret = arena_spin_lock_irqsave(&lock, flags))) total: 1 errors, 7 warnings, 1 checks, 155 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 0f6949bdb6a8 ("selftests/bpf: Add tests for arena spin lock") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.